From: Andrew Lunn <andrew@lunn.ch>
To: Kyle Hendry <khendry@reliablecontrols.com>
Cc: "Clément Léger" <clement.leger@bootlin.com>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Lad Prabhakar" <prabhakar.mahadev-lad.rj@bp.renesas.com>,
linux-renesas-soc@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] net: pcs: rzn1-miic: Verify port number from dtb
Date: Mon, 14 Sep 2026 19:08:25 +0200 [thread overview]
Message-ID: <948a213d-df62-4e4d-87c5-a7f063938acd@lunn.ch> (raw)
In-Reply-To: <3b638508-6c03-47e5-80ef-49b05961c9cb@reliablecontrols.com>
> > While reviewing this, i noticed:
> >
> > /* Adjust for 0 based index */
> > dt_val[port + !miic->of_data->miic_port_start] = conf;
> >
> > Is the ! correct?
> >
> > Andrew
>
> Yes, this is correct because dt_val[1] is where the port config entries
> start.
>
> Depending on the SoC, the port numbering might be 0 or 1 based, so this
> prevents the input config entry at dt_val[0] from being overwritten. The
> logic works out to the same as:
>
> index = port + 1 - miic->of_data->miic_port_start
It is unusual to see a ! used like this in the middle of an
addition. Sometimes the more verbose form is less likely to get
questioned asked...
Andrew
next prev parent reply other threads:[~2026-09-14 17:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 18:37 [PATCH v3 0/2] net: pcs: rzn1-miic: Fix config array initialization Kyle Hendry via B4 Relay
2026-09-02 18:37 ` [PATCH v3 1/2] " Kyle Hendry via B4 Relay
2026-09-07 19:26 ` Lad, Prabhakar
2026-09-02 18:37 ` [PATCH v3 2/2] net: pcs: rzn1-miic: Verify port number from dtb Kyle Hendry via B4 Relay
2026-09-02 18:50 ` Andrew Lunn
2026-09-14 16:37 ` Kyle Hendry
2026-09-14 17:08 ` Andrew Lunn [this message]
2026-09-02 22:12 ` Jakub Kicinski
2026-09-07 19:39 ` Lad, Prabhakar
2026-09-07 20:49 ` Andrew Lunn
2026-09-07 21:23 ` Lad, Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=948a213d-df62-4e4d-87c5-a7f063938acd@lunn.ch \
--to=andrew@lunn.ch \
--cc=clement.leger@bootlin.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=khendry@reliablecontrols.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®