From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDC3A2C15BC for ; Wed, 10 Dec 2025 21:54:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765403698; cv=none; b=scIlgNlvbPbRa1bcvln9cgZNg0nqEef0Je0EwTSNwa38cMmCAeeTqyPxVdlecSgIjoHBEP4wRlrkULjBMAnqebjrZrU3uNwSqhLAdVqv3m47qSk4DViM2XSLPAA/acgWySYMJUyj/P/uv/QDUOdqCT6z6/mJ0CU9VlPNryuS+Ds= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765403698; c=relaxed/simple; bh=5YwpXNXvcLTBq0oNgmw9x1QAwZftECAxJVHOX2AQRRg=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=j1UsAHZ4wgoOkxFpDoy8tWTxu1LVitW4Kho4UkZAQVGNpcqJjYBoaHmr7n/1fqezwyW4T9SzVEKZUHy7SiTCTGafS98gkAfV0ZFqH4HOkSvTpfH7+sx19+vh7AFPwvPTx8p0ilOL0gp5/FFQ69/B+gD/T/32yvAr3fl1Bs0SIgQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Spe7qYGb; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Spe7qYGb" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-3436d6ca17bso361693a91.3 for ; Wed, 10 Dec 2025 13:54:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765403696; x=1766008496; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=1Q/N6Uzgtd9W0PPDYHHZqCanA8rMUoUOPcmZJxcA4kU=; b=Spe7qYGbLzSB5ZXvUOwyWutx14cJ5N1UlVDcFbbuiDnfSbshRn7t6AjUzz8toS9djO DDLUBoPMrPLmTsjpT56E0+OGw3qMTkEPLGtUSnAgU2XMvYWjJ5aBw9764b/F5uCsV14E 447JUAJypEtgi+mZEkiBU0/OezAowlVffGoDz1petfbeoOP/heXnTDUnzbVEs1kGx8qy hlvm58pdnI/oXu+pCWNMCq2UommYnDOB4qdl65jEJtCbeMA67eRhIiZj0ndmwUE23EP8 SFgFkdM/3t7PRnLTJ0rZKE6hIkKTPrM21CU/hLE3EzHxrmuyy7TVuk1gyCYqyfCrn/Xc 6KRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765403696; x=1766008496; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:sender:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=1Q/N6Uzgtd9W0PPDYHHZqCanA8rMUoUOPcmZJxcA4kU=; b=CsBFoie0mUSyZ1ec+6m8V4sez6kGev4itzK0iu1V1xXROFr3H/eZRCnDxsCiTugYSq DEQPDyyZ+xOGOxpc273bmnjal5bM7kBvz/v2cj21XuCxwx6B3xAgErIaM3f8cJAiPEXE i2LTsMkC/LQDKdw0pMWl9EHZQOK2IF75c5j72ppjUkiH2pNtBjdFRT4p6Eanz1oB1xW/ 5tQOO1I781jR9ZuezuuMUh5TZgUMGKCWDUZQeIVQaAy2DtYyEkF9e8h5TAUR5u832gKX pCgjQlUXbhLw9/U4umFyKZE3FdA3ctBsH1eAm6C9Nlw4Y6YTOhYLI1MFOZAX6BV0kio6 6oFg== X-Gm-Message-State: AOJu0YwLTtf+m0LHQV3/jHENyq8B03tqU9z8wkeZ/OomV7lK8gngHR5b uAU109/QYUfOvUUxjHR/2jlTX/ksxhk5qXGxnTeOOws9hfl+qnXq4Rsf X-Gm-Gg: ASbGnct4Hr2rFT8ZQzAJhXgUqqH/puvc9BRJprpJl9+CV9wEKlv5t7zzxwiYKopO71y om85MJ+h4/bXVE92dyQyuwCrf/3M8WTSlg/vWdjhxaJ6yAYD99l+2ene2AiND3Yf6GW9HYsuAkd 8fJlwhEbgFbJehVbtm/YrCOqYjopxwswRxU58s8blCfkgFPEFGY17Tq8wsWMTY8Y+eGH0ubexaw Ri5vRWWpebDWo/SAPC+pVE+zCqnnAUrK9hkEP/LS1c2zNnbE4Nw5QDWTVBBw6SYW/Lk6PPm1a1i MDiqRegIpkTtCfg4bXG+f8qtxlDK+oNP9DendlisckicAAeNlp/0A6muU7XH+AT/tI78Zp/UP1T wfbVto5jeTygZIYujMMnYAArip5/PshgIkRsSMwcw2/wSe33zKnU2UtDivAXOYs6rNMkKQW+H++ I1AQN7FEKDexiDRBZPsKw+PMGoAkio4NGAxrEMtNvKm7q0oFBlFW6bGf73CYk= X-Google-Smtp-Source: AGHT+IGAitpzNlXFAlm7Gxbv/xB709F7p4Nfg32Gsw4inP8aDaRyJyZY8gYglMYlNj6wzyCdiFfNJg== X-Received: by 2002:a05:7022:239d:b0:11a:51a8:ec9 with SMTP id a92af1059eb24-11f296c8d5dmr2588664c88.29.1765403695820; Wed, 10 Dec 2025 13:54:55 -0800 (PST) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-11f2e2ff624sm1849393c88.12.2025.12.10.13.54.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Dec 2025 13:54:55 -0800 (PST) Sender: Guenter Roeck Message-ID: <948c31b5-8fc9-4efc-aa75-e25d25f178a2@roeck-us.net> Date: Wed, 10 Dec 2025 13:54:53 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 03/30] objtool: Disassemble code with libopcodes instead of running objdump From: Guenter Roeck To: Alexandre Chartre , "Maciej W. Rozycki" Cc: linux-kernel@vger.kernel.org, Ingo Molnar , jpoimboe@kernel.org, peterz@infradead.org, david.laight.linux@gmail.com References: <20251121095340.464045-1-alexandre.chartre@oracle.com> <20251121095340.464045-4-alexandre.chartre@oracle.com> <26a97504-36ac-4005-a146-09895ae76645@roeck-us.net> <28034b3c-b3f9-4ca6-a735-5f53da887391@oracle.com> <60c5972a-5ee5-4d9a-b71c-f2645f834dd0@roeck-us.net> <145fe5b9-59a1-4b70-a7f0-ff353f311cb2@oracle.com> <9c5c46a7-ce06-4a25-8f53-f5b461ed7829@roeck-us.net> <89da2d1e-698c-488a-b634-eafcb4dcb31a@oracle.com> Content-Language: en-US Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAmgrMyQFCSbODQkACgkQyx8mb86fmYGcWRAA oRwrk7V8fULqnGGpBIjp7pvR187Yzx+lhMGUHuM5H56TFEqeVwCMLWB2x1YRolYbY4MEFlQg VUFcfeW0OknSr1s6wtrtQm0gdkolM8OcCL9ptTHOg1mmXa4YpW8QJiL0AVtbpE9BroeWGl9v 2TGILPm9mVp+GmMQgkNeCS7Jonq5f5pDUGumAMguWzMFEg+Imt9wr2YA7aGen7KPSqJeQPpj onPKhu7O/KJKkuC50ylxizHzmGx+IUSmOZxN950pZUFvVZH9CwhAAl+NYUtcF5ry/uSYG2U7 DCvpzqOryJRemKN63qt1bjF6cltsXwxjKOw6CvdjJYA3n6xCWLuJ6yk6CAy1Ukh545NhgBAs rGGVkl6TUBi0ixL3EF3RWLa9IMDcHN32r7OBhw6vbul8HqyTFZWY2ksTvlTl+qG3zV6AJuzT WdXmbcKN+TdhO5XlxVlbZoCm7ViBj1+PvIFQZCnLAhqSd/DJlhaq8fFXx1dCUPgQDcD+wo65 qulV/NijfU8bzFfEPgYP/3LP+BSAyFs33y/mdP8kbMxSCjnLEhimQMrSSo/To1Gxp5C97fw5 3m1CaMILGKCmfI1B8iA8zd8ib7t1Rg0qCwcAnvsM36SkrID32GfFbv873bNskJCHAISK3Xkz qo7IYZmjk/IJGbsiGzxUhvicwkgKE9r7a1rOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAmgrMyQFCSbODQkACgkQyx8mb86fmYHlgg/9 H5JeDmB4jsreE9Bn621wZk7NMzxy9STxiVKSh8Mq4pb+IDu1RU2iLyetCY1TiJlcxnE362kj njrfAdqyPteHM+LU59NtEbGwrfcXdQoh4XdMuPA5ADetPLma3YiRa3VsVkLwpnR7ilgwQw6u dycEaOxQ7LUXCs0JaGVVP25Z2hMkHBwx6BlW6EZLNgzGI2rswSZ7SKcsBd1IRHVf0miwIFYy j/UEfAFNW+tbtKPNn3xZTLs3quQN7GdYLh+J0XxITpBZaFOpwEKV+VS36pSLnNl0T5wm0E/y scPJ0OVY7ly5Vm1nnoH4licaU5Y1nSkFR/j2douI5P7Cj687WuNMC6CcFd6j72kRfxklOqXw zvy+2NEcXyziiLXp84130yxAKXfluax9sZhhrhKT6VrD45S6N3HxJpXQ/RY/EX35neH2/F7B RgSloce2+zWfpELyS1qRkCUTt1tlGV2p+y2BPfXzrHn2vxvbhEn1QpQ6t+85FKN8YEhJEygJ F0WaMvQMNrk9UAUziVcUkLU52NS9SXqpVg8vgrO0JKx97IXFPcNh0DWsSj/0Y8HO/RDkGXYn FDMj7fZSPKyPQPmEHg+W/KzxSSfdgWIHF2QaQ0b2q1wOSec4Rti52ohmNSY+KNIW/zODhugJ np3900V20aS7eD9K8GTU0TGC1pyz6IVJwIE= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 12/10/25 10:42, Guenter Roeck wrote: ... >> That's weird because the "clean" rule in tools/objtool/Makefile should remove the >> entire tools/objtool/feature directory: >> >> $ cat tools/objtool/Makefile >> ... >> clean: $(LIBSUBCMD)-clean >>      $(call QUIET_CLEAN, objtool) $(RM) $(OBJTOOL) >>      $(Q)find $(OUTPUT) -name '*.o' -delete -o -name '\.*.cmd' -delete -o -name '\.*.d' -delete >>      $(Q)$(RM) $(OUTPUT)arch/x86/lib/cpu-feature-names.c $(OUTPUT)fixdep >>      $(Q)$(RM) $(OUTPUT)arch/x86/lib/inat-tables.c $(OUTPUT)fixdep >>      $(Q)$(RM) -- $(OUTPUT)FEATURE-DUMP.objtool >>      $(Q)$(RM) -r -- $(OUTPUT)feature >> >> see $(Q)$(RM) -r -- $(OUTPUT)feature >> > > $ find . -name test-disassembler-init-styled* > ./tools/build/feature/test-disassembler-init-styled.c > ./tools/objtool/feature/test-disassembler-init-styled.make.output > ./tools/objtool/feature/test-disassembler-init-styled.d > $ make clean >   CLEAN   arch/x86/lib >   CLEAN   certs >   CLEAN   arch/x86/entry/vdso >   CLEAN   init >   CLEAN   lib/crc >   CLEAN   arch/x86/tools >   CLEAN   arch/x86/realmode/rm >   CLEAN   security/selinux >   CLEAN   usr >   CLEAN   . > $ find . -name test-disassembler-init-styled* > ./tools/build/feature/test-disassembler-init-styled.c > ./tools/objtool/feature/test-disassembler-init-styled.make.output > ./tools/objtool/feature/test-disassembler-init-styled.d > $ > > "make clean" does not execute the cleanup in tools/objtool. I have to run > "make -C tools/objtool clean". "make mrproper" doesn't clean tools either. > > I guess that is on purpose ? > > Anyway, even "make -C tools/objtool clean" doesn't solve my problem if I build with > an out-of-tree toolchain. Turns out that, in this case, test-disassembler-init-styled > is build with binutils from the toolchain (which succeeds because its binutils > version is more recent). Later on, the actual build of disas.c fails because it uses > the system toolchain. > This is actually even worse than I thought. $ git clean -d -x -f -q $ make defconfig $ make -j40 $ find . -name test-disassembler-init-styled* ./tools/build/feature/test-disassembler-init-styled.c ./tools/objtool/feature/test-disassembler-init-styled.make.output ./tools/objtool/feature/test-disassembler-init-styled.d $ make -C tools/objtool/ clean $ find . -name test-disassembler-init-styled* ./tools/build/feature/test-disassembler-init-styled.make.output ./tools/build/feature/test-disassembler-init-styled.c ./tools/build/feature/test-disassembler-init-styled.d $ rm -f ./tools/build/feature/test-disassembler-init-styled.make.output ./tools/build/feature/test-disassembler-init-styled.d $ find . -name test-disassembler-init-styled* ./tools/build/feature/test-disassembler-init-styled.c $ make -C tools/objtool/ clean $ find . -name test-disassembler-init-styled* ./tools/build/feature/test-disassembler-init-styled.make.output ./tools/build/feature/test-disassembler-init-styled.c ./tools/build/feature/test-disassembler-init-styled.d Repeated with local toolchain: $ git clean -d -x -f -q $ make-x86 defconfig $ make-x86 -j40 (fails) $ make-x86 -C tools/objtool clean $ find . -name test-disassembler-init-styled* ./tools/build/feature/test-disassembler-init-styled.c ./tools/objtool/feature/test-disassembler-init-styled.make.output ./tools/objtool/feature/test-disassembler-init-styled.bin ./tools/objtool/feature/test-disassembler-init-styled.d So the "make clean" command actually (re-)creates the .bin file. Worse, if I now run $ make -C tools/objtool clean with the system toolchain, the .bin file is not removed. $ find . -name test-disassembler-init-styled* ./tools/build/feature/test-disassembler-init-styled.make.output ./tools/build/feature/test-disassembler-init-styled.bin ./tools/build/feature/test-disassembler-init-styled.c ./tools/build/feature/test-disassembler-init-styled.d The local toolchain used in this example is gcc 13.3.0 with binutils 2.42. Guenter