From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CB49C77B7A for ; Wed, 31 May 2023 07:47:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234620AbjEaHrd (ORCPT ); Wed, 31 May 2023 03:47:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233199AbjEaHra (ORCPT ); Wed, 31 May 2023 03:47:30 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3118F93 for ; Wed, 31 May 2023 00:46:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685519201; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lAEIqyTQIqAgpwEz1m8TesLih/MrDXD4GJgP6XrJJHQ=; b=P51VlisMD7pWCRbQ0yjMZdUEFDH0xkj1rsaheKA3ZkOrwjW8ePAPimITJu2dOel1izfwoL xeyIKE9TzdGmRYhHjF2f3tlgIHLi45G2PAYZ+3AHiibrtc7410QvB6+KIGcdw/hYppq3iG etnTAd83yhM3SF+UVEkDC3r6R6/d9GU= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-582-vasp2XFTO86tv5XkKDwX7g-1; Wed, 31 May 2023 03:46:40 -0400 X-MC-Unique: vasp2XFTO86tv5XkKDwX7g-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-3f603fed174so33848395e9.2 for ; Wed, 31 May 2023 00:46:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685519199; x=1688111199; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lAEIqyTQIqAgpwEz1m8TesLih/MrDXD4GJgP6XrJJHQ=; b=AtEWNO8BUrgk+7cj6j5XO5QXAZ7Kq7x6yUToiO3KAFR1HMXU9dTxOaUfBoL9w1n7+O FguD+Md7eGxM173gbrf59VbmEqAQSnvEmnSiSuDYZW8LxmN17/W3H7EPgsXIIoxJq7c4 i7N7EBo3bJxIsAu4jzeqiPDZB4M2vpLSZ4yW4IV2woJBPFA5pR8V199glHFLaJU3Lwzt 2/K30M/YAstXRUFrIet0CW6qYLAQcPLicXC5xECiE7+XA0hRAmUq5fM8TUui7g4SX4ey As/mM4maXTheLC81VbdumDixx9xSL0yowpmIF3/h8KoFpH8MINEAuKm7r14WqLq/Xz5m Y04A== X-Gm-Message-State: AC+VfDxYUlshsJJedrq0PNEwoEMGcCVIpBdHCFTXg+jdbrSLeOSGnhj3 aIRxb1uQfBWGAZs3M2oOCkjqQjsq3dD8hTyLZSucOCGo4mPYnWifbIZiKuVK7TUxOXys1UMFfy9 YcAiw+b34MVeuBAUcQXx80n2g X-Received: by 2002:a05:600c:294c:b0:3f4:2374:3512 with SMTP id n12-20020a05600c294c00b003f423743512mr3473978wmd.18.1685519198915; Wed, 31 May 2023 00:46:38 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7z2nWeeDyToNoabyk0bgUbIZ5Qb1hjh9n0hxodHOR7kl1BRQ2tIjARx8taRxj6Rm72VES6uw== X-Received: by 2002:a05:600c:294c:b0:3f4:2374:3512 with SMTP id n12-20020a05600c294c00b003f423743512mr3473958wmd.18.1685519198688; Wed, 31 May 2023 00:46:38 -0700 (PDT) Received: from ?IPV6:2003:cb:c749:cb00:fc9f:d303:d4cc:9f26? (p200300cbc749cb00fc9fd303d4cc9f26.dip0.t-ipconnect.de. [2003:cb:c749:cb00:fc9f:d303:d4cc:9f26]) by smtp.gmail.com with ESMTPSA id d13-20020a5d4f8d000000b0030ae69920c9sm5748797wru.53.2023.05.31.00.46.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 May 2023 00:46:38 -0700 (PDT) Message-ID: <9493177b-c435-9adc-cdfc-e45b91f02e77@redhat.com> Date: Wed, 31 May 2023 09:46:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH -V3 4/5] swap: remove get/put_swap_device() in __swap_duplicate() Content-Language: en-US To: Huang Ying , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yosry Ahmed , Hugh Dickins , Johannes Weiner , Matthew Wilcox , Michal Hocko , Minchan Kim , Tim Chen , Yang Shi , Yu Zhao , Chris Li References: <20230529061355.125791-1-ying.huang@intel.com> <20230529061355.125791-5-ying.huang@intel.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230529061355.125791-5-ying.huang@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29.05.23 08:13, Huang Ying wrote: > __swap_duplicate() is called by > > - swap_shmem_alloc(): the folio in swap cache is locked. > > - copy_nonpresent_pte() -> swap_duplicate() and try_to_unmap_one() -> > swap_duplicate(): the page table lock is held. > > - __read_swap_cache_async() -> swapcache_prepare(): enclosed with > get/put_swap_device() in __read_swap_cache_async() already. > > So, it's safe to remove get/put_swap_device() in __swap_duplicate(). > > Signed-off-by: "Huang, Ying" > Reviewed-by: Yosry Ahmed > Cc: David Hildenbrand > Cc: Hugh Dickins > Cc: Johannes Weiner > Cc: Matthew Wilcox > Cc: Michal Hocko > Cc: Minchan Kim > Cc: Tim Chen > Cc: Yang Shi > Cc: Yu Zhao > Cc: Chris Li > --- Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb