From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755872Ab3AYALR (ORCPT ); Thu, 24 Jan 2013 19:11:17 -0500 Received: from mx1.redhat.com ([209.132.183.28]:25604 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752277Ab3AYALF (ORCPT ); Thu, 24 Jan 2013 19:11:05 -0500 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <1359062429-27295-3-git-send-email-mmarek@suse.cz> References: <1359062429-27295-3-git-send-email-mmarek@suse.cz> <1359062429-27295-1-git-send-email-mmarek@suse.cz> To: Michal Marek Cc: dhowells@redhat.com, rusty@ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/4] MODSIGN: Add -s option to sign-file Date: Fri, 25 Jan 2013 00:10:18 +0000 Message-ID: <9497.1359072618@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Michal Marek wrote: > This option allows to append an externally computed singature to the > module. This is needed in setups, where the private key is not directly > available, but a service exists that returns signatures for given files. > > Signed-off-by: Michal Marek > --- > v2: Use two-argument version of getopts to avoid global variables > Use parentheses in EXPR if (...) constructs Feel free to add: Acked-by: David Howells to your patches.