mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Rong Zhang <i@rong.moe>
Cc: "Mark Pearson" <mpearson-lenovo@squebb.ca>,
	"Derek J. Clark" <derekjohn.clark@gmail.com>,
	"Ike Panhc" <ikepanhc@gmail.com>,
	"Hans de Goede" <hansg@kernel.org>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Maxim Mikityanskiy" <maxtram95@gmail.com>,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] platform/x86: ideapad-laptop: do not poke keyboard controller
Date: Mon, 26 Oct 2026 20:06:50 -0700	[thread overview]
Message-ID: <9499ecc052d84c2c015a27e8e1f34f0a@gmail.com> (raw)
In-Reply-To: <35aef2ab2b6607a46eaa0105e8b13c7ba60e5509.camel@rong.moe>

Hi Rong,

On Sun, Oct 25, 2026 at 10:25:46AM +0800, Rong Zhang wrote:
> > +static const struct input_device_id ideapad_tpswitch_ids[] = {
> > +	{
> > +		.flags = INPUT_DEVICE_ID_MATCH_EVBIT |
> > +				INPUT_DEVICE_ID_MATCH_KEYBIT |
> > +				INPUT_DEVICE_ID_MATCH_ABSBIT,
> > +		.bustype = BUS_I8042,
> > +		.vendor = 0x0002,
>
> Missing INPUT_DEVICE_ID_MATCH_BUS and INPUT_DEVICE_ID_MATCH_VENDOR?
>
> Other than that and the module parameter's name, the patch looks good to
> me. With them fixed:
>
> Reviewed-by: Rong Zhang <i@rong.moe>
> Tested-by: Rong Zhang <i@rong.moe> # not matching other touchpads

Indeed, well spotted! I have added the missing match flags and your tags
in v4.

Thanks.

-- 
Dmitry

      reply	other threads:[~2026-10-27  3:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-22  4:50 Dmitry Torokhov
2026-10-23  9:21 ` Uwe Kleine-König
2026-10-23 16:04 ` Alice Mikityanska
2026-10-23 16:37   ` Alice Mikityanska
2026-10-23 23:05     ` Dmitry Torokhov
2026-10-24  2:15 ` Rong Zhang
2026-10-24  3:20   ` Dmitry Torokhov
2026-10-24 15:30     ` Rong Zhang
2026-10-24 23:13       ` Dmitry Torokhov
2026-10-25  1:52         ` Rong Zhang
2026-10-25  2:38           ` Dmitry Torokhov
2026-10-25  2:25 ` Rong Zhang
2026-10-27  3:06   ` Dmitry Torokhov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9499ecc052d84c2c015a27e8e1f34f0a@gmail.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=derekjohn.clark@gmail.com \
    --cc=hansg@kernel.org \
    --cc=i@rong.moe \
    --cc=ikepanhc@gmail.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxtram95@gmail.com \
    --cc=mpearson-lenovo@squebb.ca \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®