From: Guenter Roeck <linux@roeck-us.net>
To: Xing Tong Wu <xingtong_wu@163.com>
Cc: Jean Delvare <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
xingtong.wu@siemens.com, tobias.schaffner@siemens.com,
gerd.haeussler.ext@siemens.com
Subject: Re: [PATCH 3/3] hwmon: (nct6775) Fix fan speed set failure in automatic mode
Date: Thu, 16 Nov 2023 00:12:39 -0800 [thread overview]
Message-ID: <949b2ae6-d631-449a-958c-a7d97fed57f6@roeck-us.net> (raw)
In-Reply-To: <20231116022330.2696-4-xingtong_wu@163.com>
On Thu, Nov 16, 2023 at 10:23:30AM +0800, Xing Tong Wu wrote:
> From: Xing Tong Wu <xingtong.wu@siemens.com>
>
> Setting the fan speed is only valid in manual mode; it is not possible
> to set the fan's speed in automatic mode.
> Return error and show error message when attempting to set the fan
> speed in automatic mode.
>
> Signed-off-by: Xing Tong Wu <xingtong.wu@siemens.com>
> ---
> drivers/hwmon/nct6775-core.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/hwmon/nct6775-core.c b/drivers/hwmon/nct6775-core.c
> index 575db6cb96e9..3fb9896c61ce 100644
> --- a/drivers/hwmon/nct6775-core.c
> +++ b/drivers/hwmon/nct6775-core.c
> @@ -2551,6 +2551,14 @@ store_pwm(struct device *dev, struct device_attribute *attr, const char *buf,
> int err;
> u16 reg;
>
> + if (index == 0 && data->pwm_enable[nr] != manual) {
> + dev_err(dev,
> + "The pwm%d doesn't support manual fan speed control in automatic mode.\n",
> + nr + 1);
> + dev_err(dev, "Please set pwm%d_enable to manual mode.\n", nr + 1);
No kernel log messages as reponse to user input, please. This
could and likely would clog the kernel log if, for example, some automated
script tries to write into the register.
Please add a comment describing why this is blocked.
> + return -EOPNOTSUPP;
Wrong error code. I would suggest -EBUSY; that is what is used in the it87
driver.
Guenter
> + }
> +
> err = kstrtoul(buf, 10, &val);
> if (err < 0)
> return err;
> --
> 2.25.1
>
prev parent reply other threads:[~2023-11-16 8:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-16 2:23 [PATCH 0/3] *** hwmon: (nct6775) Fix pwm bugs for NCT chips *** Xing Tong Wu
2023-11-16 2:23 ` [PATCH 1/3] hwmon: (nct6775) Fix incomplete register array Xing Tong Wu
2023-11-16 9:03 ` Guenter Roeck
2023-11-17 1:35 ` Guenter Roeck
2023-11-20 3:30 ` xingtong.wu
2023-11-20 14:41 ` Guenter Roeck
2023-11-16 2:23 ` [PATCH 2/3] hwmon: (nct6775) Fix logic error for PWM enable Xing Tong Wu
2023-11-16 8:07 ` Guenter Roeck
2023-11-16 8:36 ` xingtong.wu
2023-11-16 8:48 ` Guenter Roeck
2023-11-16 8:44 ` Guenter Roeck
2023-11-16 2:23 ` [PATCH 3/3] hwmon: (nct6775) Fix fan speed set failure in automatic mode Xing Tong Wu
2023-11-16 8:12 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=949b2ae6-d631-449a-958c-a7d97fed57f6@roeck-us.net \
--to=linux@roeck-us.net \
--cc=gerd.haeussler.ext@siemens.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tobias.schaffner@siemens.com \
--cc=xingtong.wu@siemens.com \
--cc=xingtong_wu@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®