From: Qian Cai <cai@lca.pw>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "paul E. McKenney" <paulmck@kernel.org>,
Elver Marco <elver@google.com>,
Sean Christopherson <sean.j.christopherson@intel.com>,
kasan-dev <kasan-dev@googlegroups.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] kvm/svm: disable KCSAN for svm_vcpu_run()
Date: Wed, 15 Apr 2020 12:30:58 -0400 [thread overview]
Message-ID: <94BC9E64-A189-4475-9C75-240F732C078D@lca.pw> (raw)
In-Reply-To: <f02ca9b9-f0a6-dfb5-1ca0-32a12d4f56fb@redhat.com>
> On Apr 15, 2020, at 11:57 AM, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 15/04/20 17:37, Qian Cai wrote:
>> For some reasons, running a simple qemu-kvm command with KCSAN will
>> reset AMD hosts. It turns out svm_vcpu_run() could not be instrumented.
>> Disable it for now.
>>
>> # /usr/libexec/qemu-kvm -name ubuntu-18.04-server-cloudimg -cpu host
>> -smp 2 -m 2G -hda ubuntu-18.04-server-cloudimg.qcow2
>>
>> === console output ===
>> Kernel 5.6.0-next-20200408+ on an x86_64
>>
>> hp-dl385g10-05 login:
>>
>> <...host reset...>
>>
>> HPE ProLiant System BIOS A40 v1.20 (03/09/2018)
>> (C) Copyright 1982-2018 Hewlett Packard Enterprise Development LP
>> Early system initialization, please wait...
>>
>> Signed-off-by: Qian Cai <cai@lca.pw>
>> ---
>> arch/x86/kvm/svm/svm.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c
>> index 2be5bbae3a40..1fdb300e9337 100644
>> --- a/arch/x86/kvm/svm/svm.c
>> +++ b/arch/x86/kvm/svm/svm.c
>> @@ -3278,7 +3278,7 @@ static void svm_cancel_injection(struct kvm_vcpu *vcpu)
>>
>> bool __svm_vcpu_run(unsigned long vmcb_pa, unsigned long *regs);
>>
>> -static void svm_vcpu_run(struct kvm_vcpu *vcpu)
>> +static __no_kcsan void svm_vcpu_run(struct kvm_vcpu *vcpu)
>> {
>> struct vcpu_svm *svm = to_svm(vcpu);
>>
>>
>
> I suppose you tested the patch to move cli/sti into the .S file. Anyway:
Yes, tested that without any luck.
next prev parent reply other threads:[~2020-04-15 16:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 15:37 Qian Cai
2020-04-15 15:57 ` Paolo Bonzini
2020-04-15 16:30 ` Qian Cai [this message]
2020-04-17 13:21 ` Qian Cai
2020-04-17 15:17 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94BC9E64-A189-4475-9C75-240F732C078D@lca.pw \
--to=cai@lca.pw \
--cc=elver@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=pbonzini@redhat.com \
--cc=sean.j.christopherson@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®