From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f53.google.com (mail-oo1-f53.google.com [209.85.161.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E1D11FF7C2 for ; Tue, 29 Oct 2024 19:07:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730228862; cv=none; b=uHlQ4amxOTd3uXAq8GQRoTwQedpo02t6gR3m1vhs6o3kENlMG+xKjAF39uKIwaqbvyOv/+UqYXyX8QqO37+5YumDYKJQ58X6DXHrtQwXPsbdHZ5qNTh2FG+ff6ikEmWERZ06Mc47+0zez5IJKczY0et0KSErJlNrDj2U2ExPLgU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730228862; c=relaxed/simple; bh=TSO+mrrI6OeC+vCFS9oXY7vQmV6mGsUoNVRXySJ+s78=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HKwJQc7/NFloycFokZujTbwxjwmYFxwSue+3eQPSi2arwjMuDH7QfJ6N/5EOZqL8s/bnqhVI35qVhPOkd6P+NcbJProSHER1wGDXegKq7ug7t5Qwm7z9z8CUQES0nps0zE5JczyvMJ1AJH0N6DLrXlq34Z4XNNIEvCRQkEQxbi8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=oIwJNo64; arc=none smtp.client-ip=209.85.161.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="oIwJNo64" Received: by mail-oo1-f53.google.com with SMTP id 006d021491bc7-5ebc0c05e25so3344495eaf.3 for ; Tue, 29 Oct 2024 12:07:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1730228859; x=1730833659; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wsBRlZOCSoWr8F90LQG/vXheC35lbvig9xJxIETc2Hw=; b=oIwJNo64EPd05DDrg5QS8F2vrN/XHkFSzj5aOV46T27RLo0/cJg7vh/URHhyjC2aso iJkgHryt+R+zLZ9KuJQYmBRKTfHvJM/nqiruhJQNQ1v+cahGWfvrIKGYxZl1AxI/8J4g SNd58mr3eIovATajr2YpBbmdMTnUtdaqeECPwKbmCNARgPmbJeI60m/a75O1n4fZ2ym8 xc8q/JCDKYpqOeI0G5OXMH+880xCsjOXJUKX42BSVW06wT9RuXfEeop/JFMP6+/D/Bwd F1bI7shRVpnKqqHAOtt5FiMzNHSXCSyi6Ubrk1SC9XIIKLjZ22dd90Qv3HmZj+jA7Plj 4wGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730228859; x=1730833659; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wsBRlZOCSoWr8F90LQG/vXheC35lbvig9xJxIETc2Hw=; b=QDVw/58TRoj1AULBjgC/AsZ1L/3kDioFI3x+16Foowq76Qkm1OBFAH3nkdNkIaobn8 peGPWCgI7v+1giCgxlDDRPzbgerykkxb563cpK31uTJaHFRviKbx2TykH0MEJAC6956O sPPKgDuHH3pzxpzHdgsL1MTSgA6P1HWnVIvChR8Sx6RRZh2vQVZN+bKId7NA0EKN5htB I7tQ2hMpXZPbjREVSiqOZ3G1Nr9xqMSv3BNgat7yszmE3DoX9F8hFzJyFKlJ/sAUSeEt DEUcpGQB+bulFQKtNKIkNYevJuoXd9YJX9g+V9Zf6GCn5tceSqxqP6yQfWQ0Quo3/1/r Sb3g== X-Forwarded-Encrypted: i=1; AJvYcCU6k7wrtUknn+8c6z/dj/oB2fN03q7BqqZtojTmBke9FMiFQUYUSmzoSNF6vYxlzi5QjU4nwBlHf74BEg0=@vger.kernel.org X-Gm-Message-State: AOJu0YwswPpqAzLOTbR4AXttzph7+uB2t/iN6BK5DgOJUG3EycPogaNt 1LPy/gQSwxVwQi8N2EgT/i4CzbtQtcpsTHF2werJSivS+j7MWeLMEg2tGbqgKt8= X-Google-Smtp-Source: AGHT+IFHyPnT/lwmK+anQPQw7Dkx03k6xG82n3fxQcGnEgJpVoXbLy/sLSGjIfr8xSHvXkIuOgH+kA== X-Received: by 2002:a05:6820:541:b0:5eb:db1c:a860 with SMTP id 006d021491bc7-5ec23aa5cd5mr8778986eaf.8.1730228859052; Tue, 29 Oct 2024 12:07:39 -0700 (PDT) Received: from [192.168.0.142] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-5ec18738f4fsm2458396eaf.44.2024.10.29.12.07.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Oct 2024 12:07:37 -0700 (PDT) Message-ID: <94a03835-bdd1-4243-88c7-0ad85784fe36@baylibre.com> Date: Tue, 29 Oct 2024 14:07:36 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/6] Improvements and Enhancements for AD5791 DAC Driver To: ahaslam@baylibre.com, lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, nuno.sa@analog.com Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20241029073857.753782-1-ahaslam@baylibre.com> Content-Language: en-US From: David Lechner In-Reply-To: <20241029073857.753782-1-ahaslam@baylibre.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/29/24 2:38 AM, ahaslam@baylibre.com wrote: > From: Axel Haslam > > These patches aim to improve on the ad5791 driver: > - make use of chip_info / match tables, and drop device enum id. > - Add reset, clr and ldac gpios that have to be set to the correct level in case they > are not hardwired on the setup/PCB. > - simplify probe by using the devm_* functions to automatically free resources. > --- Reviewed-by: David Lechner