mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Felipe Contreras <felipe.contreras@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Felipe Contreras <felipe.contreras@gmail.com>,
	Russell King <linux@arm.linux.org.uk>,
	"Tony Lindgren <tony@atomide.com> <tony@atomide.com>,
	Hiroshi DOYU <Hiroshi.DOYU@nokia.com>,"
	<linux-omap@vger.kernel.org>
Subject: Re: [PATCH] omap3-iommu: reorganize
Date: Sun, 13 Sep 2009 23:36:50 +0300	[thread overview]
Message-ID: <94a0d4530909131336i4612b0c0jf19adaa4e6c3f166@mail.gmail.com> (raw)
In-Reply-To: <1252873141-20496-1-git-send-email-felipe.contreras@gmail.com>

On Sun, Sep 13, 2009 at 11:19 PM, Felipe Contreras
<felipe.contreras@gmail.com> wrote:
> This way it's more object oriented and easier to see what is happening.
> No functional changes.
@@ -16,7 +16,7 @@

Sorry, I forgot to address some comments from Russell from a previous
version. I'll resend.

 struct iommu_device {
        resource_size_t base;
-       resource_size_t irq;
+       int irq;
        struct iommu_platform_data pdata;
        struct resource res[2];
 };
@@ -67,7 +67,7 @@ static int __init omap3_iommu_init(void)

                res[0].start = d->base;
                res[0].end = d->base + MMU_REG_SIZE - 1;
-               res[1].start = d->irq;
+               res[1].start = res[1].end = d->irq;

                err = platform_device_add_resources(pdev, res,
                                                    ARRAY_SIZE(res));

-- 
Felipe Contreras

           reply	other threads:[~2009-09-13 20:36 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1252873141-20496-1-git-send-email-felipe.contreras@gmail.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=94a0d4530909131336i4612b0c0jf19adaa4e6c3f166@mail.gmail.com \
    --to=felipe.contreras@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®