From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 735E4FC6182 for ; Fri, 14 Sep 2018 13:23:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 10F87204EC for ; Fri, 14 Sep 2018 13:23:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UcuTCz+T" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 10F87204EC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728208AbeINShh (ORCPT ); Fri, 14 Sep 2018 14:37:37 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:33332 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727611AbeINShh (ORCPT ); Fri, 14 Sep 2018 14:37:37 -0400 Received: by mail-pg1-f196.google.com with SMTP id s7-v6so4424281pgc.0; Fri, 14 Sep 2018 06:23:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=o7n8h3dsvy/5m8MNklCTfmR6wi7Je7Iul01LWrZX5Tk=; b=UcuTCz+TiE5TnTeVA/F9HLWh0bDDm0hhRAEJTCiXK4krbkwJO2WnyHWiuUfjt326Ug LxceM54b0pT+yZdOsfIfMvWdk5wxia0wvx2/JCHf8hifZlkbbxpvyd0osgH4fdGCDsdV FokvfMfCKUetgktRSVx0+kAikMJ3pU4FTICD1GRQncpvIRryaLG3w+/du3t4zBUP/AEQ GegTZIE5aAPk4iB88NJQoT9sKZt87yzr2EmAE9CLRBalQbsa51eulUSX6PnOeTNp047S aqCQD4tBE7mYohAS68EDo5kTAK9VWiNGqQyF2cyuD6peH+bWjZfnZnbKsJdi5beDz5fX AX+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=o7n8h3dsvy/5m8MNklCTfmR6wi7Je7Iul01LWrZX5Tk=; b=E+OkFpW9T89bvWXjvZnO+vP9lwOEqfsjMTQLTq9iuPfNOniWNdenAHYQ519Zycp9TE Wii9+7gPOE7SwsftlyoWij/0J1u/xVS+VZ+yyxIbGjpY4U/fZFGZdcMDMcvYTOycv7rA dIvEdAM4kU0mogb6/kPBEsOibP8hw23KMB1MXcOOuB6Dst1uSpbE3HM23z3HIYw2txnf qnR52qUTgsZgKN4WbgPmhCNlP/csPxl85EJkEfRKvUH0tdUVSkhnGG41780jq8BpaXwJ YSlpVGZ+5YeeFvUhb4QqMJQSdnDLKuknt0496gXWQfjaTb98FAt1/7lFS1G8aaRfZ7q3 mw2g== X-Gm-Message-State: APzg51BV9s28XgAPE1+TfvoSIjqFd3toqgu8j8H6Ep8JriiLPh4QSiz0 tNTl1sEgt1Ep/7I+eUc7fz78Yk22 X-Google-Smtp-Source: ANB0VdbXLVtwFnbM+BsKQEwVy6O7ga81Sp5+JTQf/yujrdVY0W5LmeV2UWG5MmERahBryB6H2mIDeg== X-Received: by 2002:a63:b705:: with SMTP id t5-v6mr11219048pgf.366.1536931388027; Fri, 14 Sep 2018 06:23:08 -0700 (PDT) Received: from server.roeck-us.net (108-223-40-66.lightspeed.sntcca.sbcglobal.net. [108.223.40.66]) by smtp.gmail.com with ESMTPSA id h85-v6sm11258362pfk.71.2018.09.14.06.23.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Sep 2018 06:23:06 -0700 (PDT) Subject: Re: [PATCH i2c-next v6] i2c: aspeed: Handle master/slave combined irq events properly To: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= Cc: Jae Hyun Yoo , Joel Stanley , linux-aspeed@lists.ozlabs.org, Vernon Mauery , OpenBMC Maillist , Brendan Higgins , Linux Kernel Mailing List , linux-i2c@vger.kernel.org, jarkko.nikula@linux.intel.com, Linux ARM , James Feist References: <20180911233302.GA18799@roeck-us.net> <5698ca34-14c9-8d05-c4e6-5acf85ff9d14@linux.intel.com> <20180912013449.GA12612@roeck-us.net> <7fd98646-fb5a-be4d-ce37-84b74e0fa8b3@linux.intel.com> <20180912195844.GA6893@roeck-us.net> <20180912203059.GA18201@roeck-us.net> <3f86e75f-1502-eae8-0633-d087937111c8@roeck-us.net> <20180913155703.GA22605@roeck-us.net> <2c481986-7ee0-4887-5c9b-64e2cd9d8c04@kaod.org> From: Guenter Roeck Message-ID: <94a2aa4e-69ac-7042-92d9-1ada46d5fc33@roeck-us.net> Date: Fri, 14 Sep 2018 06:23:05 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/13/2018 10:38 PM, Cédric Le Goater wrote: >>>> That seems to suggest that none of the status bits auto-clears, and that >>>> the above code clearing intr_status should be removed entirely. >>>> Am I missing something ? >>> >>> You are right. I just pushed another version of the previous patch with this >>> new hunk : >>> >>> @@ -188,7 +200,6 @@ static void aspeed_i2c_bus_handle_cmd(As >>>   { >>>       bus->cmd &= ~0xFFFF; >>>       bus->cmd |= value & 0xFFFF; >>> -    bus->intr_status = 0; >>>         if (bus->cmd & I2CD_M_START_CMD) { >>>           uint8_t state = aspeed_i2c_get_state(bus) & I2CD_MACTIVE ? >>> >>> >>> The QEMU palmetto and witherspoon machines seem to behave fine. Can you give >>> it a try ? >>> >> >> Works fine for me for all affected qemu platforms. >> >> How do you want to proceed with the qemu patches ? I attached my patches >> for reference. Maybe you can add them to your tree if they are ok and submit >> the entire series together to the qemu mailing list ? > > yes. They are pushed in my aspeed-3.1 branch. I will send the series > on the list. > Excellent. Thanks a lot! Guenter