From: Jacob Keller <jacob.e.keller@intel.com>
To: Thomas Gleixner <tglx@kernel.org>, LKML <linux-kernel@vger.kernel.org>
Cc: David Woodhouse <dwmw2@infradead.org>,
Miroslav Lichvar <mlichvar@redhat.com>,
John Stultz <jstultz@google.com>, Stephen Boyd <sboyd@kernel.org>,
Anna-Maria Behnsen <anna-maria@linutronix.de>,
"Frederic Weisbecker" <frederic@kernel.org>,
<thomas.weissschuh@linutronix.de>,
"Arthur Kiyanovski" <akiyano@amazon.com>,
Rodolfo Giometti <giometti@enneenne.com>,
Vincent Donnefort <vdonnefort@google.com>,
Marc Zyngier <maz@kernel.org>,
Oliver Upton <oliver.upton@linux.dev>, <kvmarm@lists.linux.dev>,
Oliver Upton <oupton@kernel.org>,
Richard Cochran <richardcochran@gmail.com>,
<netdev@vger.kernel.org>, Takashi Iwai <tiwai@suse.com>,
Miri Korenblit <miriam.rachel.korenblit@intel.com>,
Johannes Berg <johannes.berg@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Saeed Mahameed <saeedm@nvidia.com>,
Peter Hilber <peter.hilber@oss.qualcomm.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
<virtualization@lists.linux.dev>,
<linux-wireless@vger.kernel.org>, <linux-sound@vger.kernel.org>
Subject: Re: [patch 00/24] timekeeping/ptp: Expand snapshot functionality
Date: Tue, 26 May 2026 14:56:13 -0700 [thread overview]
Message-ID: <94b85874-ee30-4efe-a6ae-f8e40a260a02@intel.com> (raw)
In-Reply-To: <20260526165826.392227559@kernel.org>
On 5/26/2026 10:13 AM, Thomas Gleixner wrote:
> Sorry for the large CC list, but changing the inner workings touches
> unfortunately a lot of places in one go.
>
> PTP wants to grow new snapshot functionality, which provides not only the
> captured CLOCK* values, but also the underlying clocksource counter value.
>
> https://lore.kernel.org/20260515164033.6403-1-akiyano@amazon.com
>
> There was quite some discussion in seemingly related threads how to capture
> these values and how to provide core infrastructure so that driver writers
> have something to work with
>
> https://lore.kernel.org/20260514225842.110706-1-hramamurthy@google.com
> https://lore.kernel.org/20260520135207.37826-1-dwmw2@infradead.org
>
> This series implements the timekeeping related mechanisms to:
>
> 1) Capture CLOCK values along with the clocksource counter value for
> non-hardware based sampling
>
> 2) Expanding the hardware cross time stamp mechanism to hand back the
> clocksource counter value, which was captured by the device, along
> with the related CLOCK values
>
> 3) Adding AUX clock support to the hardware cross timestamping core
>
Overall the series looks good to me. I made some comments while
reviewing but nothing major and I think mostly it was on interim code
that is removed by the end of the series.
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> It's based on v7.1-rc2 and also available from git:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git timekeeping-ptp-extend-v1
>
> Thanks to David for rebasing his PTP/timekeeping work on top and providing
> feedback, fixes and testing.
>
> Thanks,
>
> tglx
> ---
> arch/arm64/kvm/hyp_trace.c | 8
> arch/arm64/kvm/hypercalls.c | 6
> drivers/net/dsa/sja1105/sja1105_main.c | 8
> drivers/net/ethernet/intel/ice/ice_ptp.c | 5
> drivers/net/ethernet/intel/igc/igc.h | 1
> drivers/net/ethernet/intel/igc/igc_ptp.c | 4
> drivers/net/ethernet/mellanox/mlx5/core/lib/clock.c | 4
> drivers/net/wireless/intel/iwlwifi/mld/ptp.c | 5
> drivers/net/wireless/intel/iwlwifi/mvm/ptp.c | 7
> drivers/pps/generators/pps_gen-dummy.c | 6
> drivers/pps/generators/pps_gen_tio.c | 6
> drivers/ptp/ptp_chardev.c | 18 +
> drivers/ptp/ptp_ocp.c | 11 -
> drivers/ptp/ptp_vmclock.c | 25 --
> drivers/virtio/virtio_rtc_ptp.c | 2
> include/linux/pps_kernel.h | 8
> include/linux/ptp_clock_kernel.h | 15 -
> include/linux/timekeeping.h | 54 ++---
> kernel/time/timekeeping.c | 211 ++++++++++++--------
> sound/hda/common/controller.c | 4
> 20 files changed, 236 insertions(+), 172 deletions(-)
next prev parent reply other threads:[~2026-05-26 21:56 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 17:13 Thomas Gleixner
2026-05-26 17:13 ` [patch 01/24] timekeeping: Provide ktime_get_snapshot_id() Thomas Gleixner
2026-05-26 21:41 ` Jacob Keller
2026-05-27 15:58 ` Thomas Gleixner
2026-05-26 23:39 ` David Woodhouse
2026-05-27 6:56 ` Thomas Weißschuh
2026-05-26 17:13 ` [patch 02/24] timekeeping: Use system_time_snapshot::sys instead of ::real Thomas Gleixner
2026-05-26 23:40 ` [PATCH 2/24] " David Woodhouse
2026-05-27 6:58 ` [patch 02/24] " Thomas Weißschuh
2026-05-26 17:13 ` [patch 03/24] pps: generators: Use ktime_get_real_ts64() instead of ktime_get_snapshot() Thomas Gleixner
2026-05-26 23:42 ` [PATCH 3/24] " David Woodhouse
2026-05-27 7:00 ` [patch 03/24] " Thomas Weißschuh
2026-05-26 17:13 ` [patch 04/24] pps: Convert to ktime_get_snapshot_id() Thomas Gleixner
2026-05-26 23:42 ` [PATCH 4/24] " David Woodhouse
2026-05-27 7:02 ` [patch 04/24] " Thomas Weißschuh
2026-05-27 16:02 ` Thomas Gleixner
2026-05-26 17:13 ` [patch 05/24] KVM: arm64: Use ktime_get_snapshot_id() to retrieve CLOCK_BOOTTIME Thomas Gleixner
2026-05-26 23:42 ` [PATCH 5/24] " David Woodhouse
2026-05-27 7:02 ` [patch 05/24] " Thomas Weißschuh
2026-05-27 9:02 ` Marc Zyngier
2026-05-27 16:28 ` Vincent Donnefort
2026-05-26 17:13 ` [patch 06/24] KVM: arm64: Use ktime_get_snapshot_id() to snapshot CLOCK_REALTIME Thomas Gleixner
2026-05-26 23:43 ` [PATCH 6/24] " David Woodhouse
2026-05-27 7:03 ` [patch 06/24] " Thomas Weißschuh
2026-05-27 9:03 ` Marc Zyngier
2026-05-26 17:14 ` [patch 07/24] ptp: ptp_vmclock: Convert to ktime_get_snapshot_id() Thomas Gleixner
2026-05-26 23:43 ` [PATCH 7/24] " David Woodhouse
2026-05-27 7:10 ` [patch 07/24] " Thomas Weißschuh
2026-05-26 17:14 ` [patch 08/24] timekeeping: Remove system_time_snapshot::real/boot Thomas Gleixner
2026-05-26 21:49 ` Jacob Keller
2026-05-26 21:52 ` Jacob Keller
2026-05-26 23:44 ` [PATCH 8/24] " David Woodhouse
2026-05-27 7:17 ` [patch 08/24] " Thomas Weißschuh
2026-05-26 17:14 ` [patch 09/24] timekeeping: Add CLOCK_AUX support for ktime_get_snapshot_id() Thomas Gleixner
2026-05-26 23:44 ` [PATCH 9/24] " David Woodhouse
2026-05-27 7:18 ` [patch 09/24] " Thomas Weißschuh
2026-06-26 8:48 ` Thomas Weißschuh
2026-06-26 10:49 ` Thomas Gleixner
2026-06-26 11:03 ` Thomas Weißschuh
2026-06-26 15:17 ` Thomas Gleixner
2026-06-29 3:55 ` Thomas Weißschuh
2026-06-29 8:39 ` Thomas Gleixner
2026-07-05 12:38 ` [PATCH] timekeeping: Document monotonic raw timestamps in snapshots correctly Thomas Gleixner
2026-07-06 8:42 ` Thomas Weißschuh
2026-07-06 15:52 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
2026-06-26 10:51 ` [patch 09/24] timekeeping: Add CLOCK_AUX support for ktime_get_snapshot_id() David Woodhouse
2026-05-26 17:14 ` [patch 10/24] timekeeping: Add system_counterval_t to struct system_device_crosststamp Thomas Gleixner
2026-05-26 23:45 ` [PATCH " David Woodhouse
2026-05-26 17:14 ` [patch 11/24] timekeeping: Add CLOCK ID to system_device_crosststamp Thomas Gleixner
2026-05-26 23:46 ` [PATCH " David Woodhouse
2026-05-26 17:14 ` [patch 12/24] wifi: iwlwifi: Adopt PTP cross timestamps to core changes Thomas Gleixner
2026-05-26 23:47 ` [PATCH " David Woodhouse
2026-05-26 17:14 ` [patch 13/24] ice/ptp: Use provided clock ID for history snapshot Thomas Gleixner
2026-05-26 21:51 ` Jacob Keller
2026-05-26 23:49 ` [PATCH " David Woodhouse
2026-05-26 17:14 ` [patch 14/24] igc: " Thomas Gleixner
2026-05-26 21:51 ` Jacob Keller
2026-05-26 23:50 ` [PATCH " David Woodhouse
2026-05-26 17:14 ` [patch 15/24] net/mlx5: " Thomas Gleixner
2026-05-26 23:51 ` [PATCH " David Woodhouse
2026-05-26 17:14 ` [patch 16/24] virtio_rtc: " Thomas Gleixner
2026-05-26 23:51 ` [PATCH " David Woodhouse
2026-05-26 17:14 ` [patch 17/24] timekeeping: Remove ktime_get_snapshot() Thomas Gleixner
2026-05-26 23:52 ` [PATCH " David Woodhouse
2026-05-27 7:20 ` [patch " Thomas Weißschuh
2026-05-26 17:14 ` [patch 18/24] timekeeping: Prepare for cross timestamps on arbitrary clock IDs Thomas Gleixner
2026-05-26 23:54 ` [PATCH " David Woodhouse
2026-05-27 7:23 ` [patch " Thomas Weißschuh
2026-05-26 17:15 ` [patch 19/24] ptp: Use system_device_crosststamp::sys_systime Thomas Gleixner
2026-05-26 23:54 ` [PATCH " David Woodhouse
2026-05-26 17:15 ` [patch 20/24] wifi: iwlwifi: " Thomas Gleixner
2026-05-26 23:55 ` [PATCH " David Woodhouse
2026-05-26 17:15 ` [patch 21/24] ALSA: hda/common: " Thomas Gleixner
2026-05-26 23:55 ` [PATCH " David Woodhouse
2026-05-26 17:15 ` [patch 22/24] timekeeping: Remove system_device_crosststamp::sys_realtime Thomas Gleixner
2026-05-26 23:56 ` [PATCH " David Woodhouse
2026-05-27 7:24 ` [patch " Thomas Weißschuh
2026-05-26 17:15 ` [patch 23/24] timekeeping: Add support for AUX clock cross timestamping Thomas Gleixner
2026-05-26 23:56 ` [PATCH " David Woodhouse
2026-05-27 7:24 ` [patch " Thomas Weißschuh
2026-05-26 17:15 ` [patch 24/24] ptp: Switch to ktime_get_snapshot_id() for pre/post timestamps Thomas Gleixner
2026-05-26 23:57 ` [PATCH " David Woodhouse
2026-05-27 13:10 ` [patch " Vadim Fedorenko
2026-05-27 23:56 ` Jakub Kicinski
2026-05-28 13:55 ` Thomas Gleixner
2026-05-26 21:56 ` Jacob Keller [this message]
2026-05-27 3:55 ` [PATCH 0/24] timekeeping/ptp: Expand snapshot functionality Arthur Kiyanovski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94b85874-ee30-4efe-a6ae-f8e40a260a02@intel.com \
--to=jacob.e.keller@intel.com \
--cc=akiyano@amazon.com \
--cc=anna-maria@linutronix.de \
--cc=anthony.l.nguyen@intel.com \
--cc=dwmw2@infradead.org \
--cc=frederic@kernel.org \
--cc=giometti@enneenne.com \
--cc=johannes.berg@intel.com \
--cc=jstultz@google.com \
--cc=kvmarm@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=maz@kernel.org \
--cc=miriam.rachel.korenblit@intel.com \
--cc=mlichvar@redhat.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=oliver.upton@linux.dev \
--cc=oupton@kernel.org \
--cc=peter.hilber@oss.qualcomm.com \
--cc=richardcochran@gmail.com \
--cc=saeedm@nvidia.com \
--cc=sboyd@kernel.org \
--cc=tglx@kernel.org \
--cc=thomas.weissschuh@linutronix.de \
--cc=tiwai@suse.com \
--cc=vdonnefort@google.com \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®