From: Markus Elfring <Markus.Elfring@web.de>
To: Wen Yang <wen.yang99@zte.com.cn>,
alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org
Cc: linux-kernel@vger.kernel.org, Fabio Estevam <festevam@gmail.com>,
Jaroslav Kysela <perex@perex.cz>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Nicolin Chen <nicoleotsuka@gmail.com>,
Takashi Iwai <tiwai@suse.com>, Timur Tabi <timur@kernel.org>,
Xiubo Li <Xiubo.Lee@gmail.com>, Yi Wang <wang.yi59@zte.com.cn>
Subject: Re: [PATCH 2/3] ASoC: fsl_utils: fix a leaked reference by adding missing of_node_put
Date: Fri, 5 Apr 2019 14:30:58 +0200 [thread overview]
Message-ID: <94bbd764-9727-5e17-aab0-66738edec39f@web.de> (raw)
In-Reply-To: <1551169071-11639-2-git-send-email-wen.yang99@zte.com.cn>
> @@ -71,6 +71,7 @@ int fsl_asoc_get_dma_channel(struct device_node *ssi_np,
> iprop = of_get_property(dma_np, "cell-index", NULL);
> if (!iprop) {
> of_node_put(dma_np);
> + of_node_put(dma_channel_np);
> return -EINVAL;
> }
> *dma_id = be32_to_cpup(iprop);
How do you think about to adjust the exception handling in this function
implementation a bit more according to the Linux coding style?
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/sound/soc/fsl/fsl_utils.c?id=c705247136a523488eac806bd357c3e5d79a7acd#n16
Regards,
Markus
next prev parent reply other threads:[~2019-04-05 12:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 8:17 [PATCH 1/3] ASoC: wcd9335: " Wen Yang
2019-02-26 8:17 ` [PATCH 2/3] ASoC: fsl_utils: " Wen Yang
2019-04-05 12:30 ` Markus Elfring [this message]
2019-02-26 8:17 ` [PATCH 3/3] ASoC: eukrea-tlv320: " Wen Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94bbd764-9727-5e17-aab0-66738edec39f@web.de \
--to=markus.elfring@web.de \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=perex@perex.cz \
--cc=timur@kernel.org \
--cc=tiwai@suse.com \
--cc=wang.yi59@zte.com.cn \
--cc=wen.yang99@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome