From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B5682E3373 for ; Mon, 17 Mar 2025 09:04:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742202297; cv=none; b=GLxjXejr/j942PpsSZ+TKB/hU/Sspbd6KOuTvfXnGKwMzNYm9DXp6QvDzFi3970KOR9la2aLb+IyXlRv6uVSIpc6Rt8CxnEnRUjDxGTsmVMRSzSDcJYUPa9IGE8DFD3jDTadq/kP/KM+e/fUZnBQfet3Hu0lf+NJdSikx065b6M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742202297; c=relaxed/simple; bh=05r/hUCU63UsH3457J7hzt32bAtzfzNcG98x63Sm74I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rnJT3p0HmS1m61pWs6RPIvXvO/XnIeVzYbw7INocXdrVIqZrkqfLnTdsk6ZT+sd7uMp7g+4Tcpj1HM5AKnbJgo2C5eMrxr0QZ/C8gwl069InsZwkCmDCzQXa0yilmlULTDQU+PYeQL2y9MChJKoeJ1gm3nk4i6ulslVbhlpDqJw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=K+Th2JIS; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="K+Th2JIS" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742202295; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=29vE6oaVEg14v+0pXwuE2t45Kpr7j22qUMLQirhD7Bg=; b=K+Th2JISHV3yhhaxPGcxr4/C4ud+5xCn5z7jGFnvNwFk4+ktM1BkrZSv+jr8S2GREGWYAB 7r6E9+3ZOW6YI7quE7HOjyd3VX+V5lcrn2YXHI2SPfS+9e2KXqEJdSR9ZIYKoEvRu5+GmZ L6D2lHiZHf3sn6KyDIVMX9SKJ9+t0mw= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-374-fRc-UbkoNgOiyb5K6DuOSw-1; Mon, 17 Mar 2025 05:04:53 -0400 X-MC-Unique: fRc-UbkoNgOiyb5K6DuOSw-1 X-Mimecast-MFC-AGG-ID: fRc-UbkoNgOiyb5K6DuOSw_1742202293 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-ab76aa0e72bso337665966b.0 for ; Mon, 17 Mar 2025 02:04:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742202292; x=1742807092; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=29vE6oaVEg14v+0pXwuE2t45Kpr7j22qUMLQirhD7Bg=; b=eCvGrxH4Dwf/MHpN6dNf94UivkGHsgiDwSFBTz6PqXNlFYL5gDvQQGnWzLnzJSy6ra OJuLMfXUtZtJ2W+8NiUX9zo/700vUE9IhELKECFzIuaVb03cavrgxb/aIvITrC8co8Gm v1zNTPhfR7vp2+WoWsobDREwqCm4kzk1e1fvge0jJessHEpO7pR2gAGTJz9k57FlY6Iw 3pKsstp3DStWYsPM6TFGWxevK39fjvIh6IMUA06gdVPrQO30TwabzVWvfEysYPTveAFR hH8xYQnH8ApsPzeMl/KQAAhDiRVfeOIv2+9pBv/UT+ehKHck+oH/ZzQoEOjlhdi7cIR6 s44g== X-Forwarded-Encrypted: i=1; AJvYcCVxjvTgLA7qevDM0nKI0UmvbGjMbCXzFWvBhnAtoj0Xtfy0zquKIKP9WuVNVGjyPAa1mN5Dsq3SZv+WgFs=@vger.kernel.org X-Gm-Message-State: AOJu0YxMaszIMbVpGVefbdur1yLRBrAJE4Dz8K8SbCnm6wrHmkp5ow8K fnWZ0NqwaSUA6geJL1VqTa6WTJ0KNG/KwkagC8zbDxpKO8aJjUbbnFq94Juf1Uzc8C/7Pmp7otq qQ84p+1VtfUE8tkJhNKezstSm1boyuiCuHCzQhXUJjpmyFdGjbYsBHYDyzOk9O8BhiVxeVf1G X-Gm-Gg: ASbGncshyw6PvodkQm5pLpQd6owZQ4DOVnz5Be+D2Adc9Ko7mjbChrCOyww6LP8ppqq R/eAFRV6SwDoj48ZuW1o61GfBNiutp52Y8FO5DPp4vpkF1xDheBvXQT5QXzHwWM2+l2lNbwyWq/ heKaTquIW6A1CmSR+jO7GCpNHtmpGzhU0sPIC+NASjX4uHWENnH24uBXOoSssY8jhAYuRUPTtxn VcMJrFvrfwqeQJcmESwGzJIcacL+vYpRUD80f5bObRG4kZKG6q8V0h5eAjsjErxbKpRq+HAOKcc gGCpZrCglmfaPKW8nmM= X-Received: by 2002:a17:907:7290:b0:abf:e7c1:b3bf with SMTP id a640c23a62f3a-ac3301e352amr1336402666b.11.1742202291907; Mon, 17 Mar 2025 02:04:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG+G5BfaNF92AjsKhcSSJIGr22ciY52oU2w94T7cj7w7uUFajbxZD3Z37SlZi7kKNz9ge2okw== X-Received: by 2002:a17:907:7290:b0:abf:e7c1:b3bf with SMTP id a640c23a62f3a-ac3301e352amr1336400066b.11.1742202291505; Mon, 17 Mar 2025 02:04:51 -0700 (PDT) Received: from [10.40.98.122] ([78.108.130.194]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac3149cf219sm626215966b.88.2025.03.17.02.04.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Mar 2025 02:04:51 -0700 (PDT) Message-ID: <94bc2fef-1138-4252-9ad3-dd6e01d55290@redhat.com> Date: Mon, 17 Mar 2025 10:04:50 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/8] media: i2c: ov02e10: Implement specification t3 and t5 delays on power-up To: Bryan O'Donoghue , Mauro Carvalho Chehab , Sakari Ailus , Liam Girdwood , Mark Brown Cc: Jingjing Xiong , Hao Yao , Jim Lai , You-Sheng Yang , Alan Stern , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org References: <20250317-b4-media-comitters-next-25-03-13-ov02e10-v1-0-bd924634b889@linaro.org> <20250317-b4-media-comitters-next-25-03-13-ov02e10-v1-6-bd924634b889@linaro.org> Content-Language: en-US, nl From: Hans de Goede In-Reply-To: <20250317-b4-media-comitters-next-25-03-13-ov02e10-v1-6-bd924634b889@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, On 17-Mar-25 01:39, Bryan O'Donoghue wrote: > The ov02e10 specification says for power-on: > > t3 = the time between dvdd stable and XSHUTDOWN deassert > t5 = the time between XSHUTDOWN deassert and SCCB ready > > The power-off path in the spec shows no required delays between XSHUTDONW > and power-rail shut off so power-off is left alone. > > Signed-off-by: Bryan O'Donoghue > --- > drivers/media/i2c/ov02e10.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/ov02e10.c b/drivers/media/i2c/ov02e10.c > index 9ad70671a718ea0aaf80ad3adcc5738ee57a7ff6..40c4d3ee36e3e2a0bb8be3ff10d016e2bb9bbc9d 100644 > --- a/drivers/media/i2c/ov02e10.c > +++ b/drivers/media/i2c/ov02e10.c > @@ -579,7 +579,11 @@ static int ov02e10_power_on(struct device *dev) > goto disable_clk; > } > > - gpiod_set_value_cansleep(ov02e10->reset, 0); > + if (ov02e10->reset) { > + usleep_range(5000, 5100); > + gpiod_set_value_cansleep(ov02e10->reset, 0); > + usleep_range(8000, 8100); > + } > > return 0; > Note ATM ov02e10->reset is requested with GPIOD_OUT_LOW and it is not guaranteed that it was high before that. It really should be requested with GPIOD_OUT_HIGH so that it is guaranteed to be high before ov02e10_power_on() gets called as the code expects here. Regards, Hans