From: Logan Gunthorpe <logang@deltatee.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
Sagi Grimberg <sagi@grimberg.me>, Keith Busch <kbusch@kernel.org>,
Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
Max Gurtovoy <maxg@mellanox.com>,
Stephen Bates <sbates@raithlin.com>
Subject: Re: [RFC PATCH 3/3] nvme: Introduce nvme_execute_passthru_rq_nowait()
Date: Mon, 28 Oct 2019 10:58:56 -0600 [thread overview]
Message-ID: <94c1e177-4848-c88b-ec26-3da118fd18dc@deltatee.com> (raw)
In-Reply-To: <20191027150937.GC5843@lst.de>
On 2019-10-27 9:09 a.m., Christoph Hellwig wrote:
> On Fri, Oct 25, 2019 at 02:25:35PM -0600, Logan Gunthorpe wrote:
>> This function is similar to nvme_execute_passthru_rq() but does
>> not wait and will call a callback when the request is complete.
>>
>> The new function can also be called in interrupt context, so if there
>> are side effects, the request will be executed in a work queue to
>> avoid sleeping.
>
> Why would you ever call it from interrupt context? All the target
> submission handlers should run in process context.
Oh, I mis-understood this a bit and worded that incorrectly. The intent
is to avoid having to call nvme_passthru_end() in the completion handler
which can be in interrupt context.
>> +void nvme_execute_passthru_rq_nowait(struct request *rq, rq_end_io_fn *done)
>> +{
>> + struct nvme_command *cmd = nvme_req(rq)->cmd;
>> + struct nvme_ctrl *ctrl = nvme_req(rq)->ctrl;
>> + struct nvme_ns *ns = rq->q->queuedata;
>> + struct gendisk *disk = ns ? ns->disk : NULL;
>> + u32 effects;
>> +
>> + /*
>> + * This function may be called in interrupt context, so we cannot sleep
>> + * but nvme_passthru_[start|end]() may sleep so we need to execute
>> + * the command in a work queue.
>> + */
>> + effects = nvme_command_effects(ctrl, ns, cmd->common.opcode);
>> + if (effects) {
>> + rq->end_io = done;
>> + INIT_WORK(&nvme_req(rq)->work, nvme_execute_passthru_rq_work);
>> + queue_work(nvme_wq, &nvme_req(rq)->work);
>
> But independent of the target code - I'd much rather leave this to the
> caller. Just call nvme_command_effects in the target code, then if
> there are not side effects use blk_execute_rq_nowait directly, else
> schedule a workqueue in the target code and call
> nvme_execute_passthru_rq from it.
Ok, that seems sensible. Except it conflicts a bit with Sagi's feedback:
presumably we need to cancel the work items during nvme_stop_ctrl() and
that's going to be rather difficult to do from the caller. Are we saying
this is unnecessary? It's not clear to me if passthru_start/end is going
to be affected by nvme_stop_ctrl() which I believe is the main concern.
Logan
next prev parent reply other threads:[~2019-10-28 16:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 20:25 [RFC PATCH 0/3] Passthru Execute Request Interface Logan Gunthorpe
2019-10-25 20:25 ` [RFC PATCH 1/3] nvme: Move nvme_passthru_[start|end]() calls to common code Logan Gunthorpe
2019-10-25 20:25 ` [RFC PATCH 2/3] nvme: Create helper function to obtain command effects Logan Gunthorpe
2019-10-27 15:05 ` Christoph Hellwig
2019-10-25 20:25 ` [RFC PATCH 3/3] nvme: Introduce nvme_execute_passthru_rq_nowait() Logan Gunthorpe
2019-10-25 20:41 ` Sagi Grimberg
2019-10-25 21:12 ` Logan Gunthorpe
2019-10-25 21:40 ` Sagi Grimberg
2019-10-25 21:55 ` Logan Gunthorpe
2019-10-27 15:09 ` Christoph Hellwig
2019-10-28 16:58 ` Logan Gunthorpe [this message]
2019-10-28 21:04 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94c1e177-4848-c88b-ec26-3da118fd18dc@deltatee.com \
--to=logang@deltatee.com \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=maxg@mellanox.com \
--cc=sagi@grimberg.me \
--cc=sbates@raithlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®