From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 020F71C8611 for ; Mon, 28 Jul 2025 08:37:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.20 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753691847; cv=none; b=EbOPnmgMRPSQOM2E18raM0TE8BnH0T7QRItYVgFsBeR8OWvMeV/kTViRICQgDc61K1KZJmUSPdZRVyfIvrjSutl2fJ6dpDwScYWNjumbS4eTDheDiaSALpoQ/os8+uFMXc5Eiuu15kFoFJKgfvaeDkcQPfLW3+gNc3iokCBRKfo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753691847; c=relaxed/simple; bh=5HW/snAwIfD0ye/vlk7UVQKjebSwKda+D9Cu1oL4vnA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=MVFcfX/1GxojlJesClsE5F6kXAQpCB2t4DAkadKHFox37L3+0qFlDdLYFCmPFlTD2d+IoxiTVCPdGkMSkDrR3QY5H/0XnYN+CSI+OQBWARP00RT2JnsOC8timiFnPRnkeb7SmBWPOewS3NLU1qmVXThFK7jkmGrB37bj1nlgMy4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=W/FO4OCN; arc=none smtp.client-ip=198.175.65.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="W/FO4OCN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1753691845; x=1785227845; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=5HW/snAwIfD0ye/vlk7UVQKjebSwKda+D9Cu1oL4vnA=; b=W/FO4OCN3lqXtg8Gkk2vgrw+UTMIbgYl6YnR7kHP6mpEzJpmOQrGKZsW PfE3PSlDNefWiEf1XDWKhfLoCfU2zWXglx/bnt97nZxFuv0gHaZ15XYZM i0uUuI/MWJwligLwusms4/QJ1Xg+3F+J5FzoSNTAeg+/VxqK1/D4W5ojS ODBWew+cwlp07wnnHOksdIYvD0MKiR+DMJNN3AITjpPe0q5GJcE3zltw4 FAq09VhG8HedUmi/fc9ycP5vRbKcxUFY7YAxQWDsN5MR9nIMgWvsPIEED gAwBvEw7SiMlkYbyDl6eMVZpAOnVDe+u7TYXPSTBqc9sE9qiOAEF/xS8g g==; X-CSE-ConnectionGUID: M8pN5seTR5WH3sTW4fm9xw== X-CSE-MsgGUID: 59b7qqWqQ7Sc08bprBjvOg== X-IronPort-AV: E=McAfee;i="6800,10657,11504"; a="55632436" X-IronPort-AV: E=Sophos;i="6.16,339,1744095600"; d="scan'208";a="55632436" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jul 2025 01:37:25 -0700 X-CSE-ConnectionGUID: bck5GSs4RA++hfw3vrtZRA== X-CSE-MsgGUID: AuuhnS7uQ1O63BgrikIfLg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,339,1744095600"; d="scan'208";a="167694648" Received: from vpanait-mobl.ger.corp.intel.com (HELO localhost) ([10.245.246.225]) by fmviesa004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jul 2025 01:37:21 -0700 From: Jani Nikula To: Thomas Zimmermann , Maxime Ripard Cc: Maarten Lankhorst , David Airlie , Simona Vetter , Dmitry Baryshkov , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] drm/tests: edid: Update CTA-861 HDMI Vendor Specific Data Block In-Reply-To: <89bce051-3732-48a8-9679-11a404bbbfb3@suse.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20250625-drm-update-edid-v1-0-2d963743ab9e@kernel.org> <20250625-drm-update-edid-v1-2-2d963743ab9e@kernel.org> <046193df-bb11-4d84-98a4-c6d46d359316@suse.de> <20250716-realistic-cream-ammonite-304cca@houat> <89bce051-3732-48a8-9679-11a404bbbfb3@suse.de> Date: Mon, 28 Jul 2025 11:37:18 +0300 Message-ID: <94c88860a39219dc29075d4c8f2ec351c7ce25f6@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Wed, 16 Jul 2025, Thomas Zimmermann wrote: > Hi > > Am 16.07.25 um 17:06 schrieb Maxime Ripard: >> Hi Thomas, >> >> On Mon, Jul 14, 2025 at 01:02:33PM +0200, Thomas Zimmermann wrote: >>> Hi >>> >>> Am 25.06.25 um 17:14 schrieb Maxime Ripard: >>>> For some reason, the HDMI VSDBs in our kunit EDIDs had a length longer >>>> than expected. >>>> >>>> While this was harmless, we should get rid of it to make it somewhat >>>> predictable. >>> Dump question: should these errors be kept in another test specifically for >>> detecting this problem? >> I'm not entirely sure what you mean here, sorry. Did you mean that we >> should get some tests to prevent that kind of EDIDs from being accepted >> by the kernel? >> >> If so, I guess it would mean getting a test suite for the EDID parser >> itself, which is definitely something that should happen at some point >> but seems a little out of scope to me. > > OK. I meant that these are ill-formed EDIDs and the kernel's EDID > processing should handle them gracefully. A test could verify this. Not > a blocker for this series, of course. Going through old mails... I'll note that EDIDs in general contain so much garbage that we simply can't reject them if there are issues. They do need to be handled gracefully, of course. BR, Jani. -- Jani Nikula, Intel