From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758456AbcHYRXE (ORCPT ); Thu, 25 Aug 2016 13:23:04 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:9058 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754141AbcHYRWu (ORCPT ); Thu, 25 Aug 2016 13:22:50 -0400 X-IBM-Helo: d23dlp02.au.ibm.com X-IBM-MailFrom: hbathini@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] perf tool: add container identifier entry related changes To: Peter Zijlstra References: <147212627442.20120.6106492652250934757.stgit@hbathini.in.ibm.com> <147212628343.20120.374300104434639788.stgit@hbathini.in.ibm.com> <20160825130427.GG10138@twins.programming.kicks-ass.net> Cc: ast@fb.com, lkml , acme@kernel.org, alexander.shishkin@linux.intel.com, mingo@redhat.com, sargun@sargun.me, Aravinda Prasad , "Naveen N. Rao" , Ananth N Mavinakayanahalli , daniel@iogearbox.net From: Hari Bathini Date: Thu, 25 Aug 2016 22:52:05 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160825130427.GG10138@twins.programming.kicks-ass.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16082517-0052-0000-0000-000001BEF9DF X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16082517-0053-0000-0000-000006A497BE Message-Id: <94cf3620-58c2-be35-6771-436e95d2efbc@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-08-25_10:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1608250200 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 25 August 2016 06:34 PM, Peter Zijlstra wrote: > On Thu, Aug 25, 2016 at 05:28:03PM +0530, Hari Bathini wrote: >> diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c >> index d9b80ef..d35fbd3 100644 >> --- a/tools/perf/util/evsel.c >> +++ b/tools/perf/util/evsel.c >> @@ -929,6 +929,8 @@ void perf_evsel__config(struct perf_evsel *evsel, struct record_opts *opts, >> if (opts->sample_transaction) >> perf_evsel__set_sample_bit(evsel, TRANSACTION); >> >> + perf_evsel__set_sample_bit(evsel, CID); >> + >> if (opts->running_time) { >> evsel->attr.read_format |= >> PERF_FORMAT_TOTAL_TIME_ENABLED | > Does this mean its enabled by default? Why? By growing the default > sample to include everything under the sun we make profiling slower for > everyone. True. Will put it under a flag.. - Hari