From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3EF0B36F8E8 for ; Mon, 8 Jun 2026 06:22:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780899734; cv=none; b=H1nb6IWNgfoVml51LU2rP0+oPq/LBIS33S0ANbYHfdRlTqUnoK+gAlI+BpYzvLS3h/u9WC3WOcnG1rse6CvI+qWScrxEFF0e0aIs0WbEs1FEdPb/dLI46babXcjMjh1AYykY5UQBSxs8a07OTaKbMw6OjVXSRddzto2OWC/YUUs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780899734; c=relaxed/simple; bh=7/r2dFANwJ94J2Ax0DcUj0P+2XgUdRU3744Qs5bCj7w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Y2pibgMxp044xTql7dEiEsxURi9897qs3wT+3IoXL2yj2mGaVEdD8waD5jRHlI+F/KsKTVemEQIgjtaBtENkwJMCF691qIaDKIWu2It83GNPo9btkH0zLc0+cr4PZ/uw+wWKT9vkljrxq+JE94m60ArOr7XK6+hMpg8ohzN+wdE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=MwaxoWLj; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=LjfBu7z5; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="MwaxoWLj"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="LjfBu7z5" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6580GtSG1992379 for ; Mon, 8 Jun 2026 06:22:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= PXV5eOedzsBR8n4Agn6k2oBXAflNJaFrBDP9DJ8wYZw=; b=MwaxoWLjWh7vD/xi lp2//XPaTUk6bMV9NOSUN/+EgCrGOz2567LCpku5a8bBI02BhQjatj/VrWdaFd+s X7pF+9y0utPOlbMA1Oa6HuvFI5iO95+BAyMy82od3+jbn9b2ZWJ2qdg7MTu5Pv1q fpyfSmLd/eDQCcs6CmlLxf+Jl79zJdtVobwnLTdXuIAT1K24sDh1ajpeVFIjVXLa 2cKXkhE59Tfa22XpJqpK/IlPWvaFPagx3vqfnZgYzaLWK5YspApSDC8EbKb7NuLO t85IP6cvqD4Ac3D7CZiHdU/Z1vjzxWVCjX/nFRY0L9PyWu05lu1ohVs7JksJhnuv A23SVQ== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4em9k3pmm2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 08 Jun 2026 06:22:12 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-8423f6247c6so4622446b3a.3 for ; Sun, 07 Jun 2026 23:22:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780899731; x=1781504531; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=PXV5eOedzsBR8n4Agn6k2oBXAflNJaFrBDP9DJ8wYZw=; b=LjfBu7z5NWvMErhsqbFLRrYSrYF2RufH/pLGzufcUtZgQyLS8I1YdOj2Gk1Rpq6gFj N98tyVH4PwwQeMKy8tW3q8oX11mkbghQHNVkUhlJrIIrj93lOpcDgia2MNn6eeV4aqLT fScF7geRe3tYo86Kpbfv6xLw4qlC7dtTKEiOUZlgEX9F9Ws36I8CF+5d5nQnU+ETIf5U vMVRgV0ap1tomiWT+u4azBHsLwWd6rehfNgDP7mrhEm8SdO7z53Y/Ankjkty0wPwGPxX E0TE+wCYehIu3WBDvrzY7UCjialDNH9btk9zt9qaEMkMhAPmksehdmCeuxTYoy3pqZAl XE1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780899731; x=1781504531; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PXV5eOedzsBR8n4Agn6k2oBXAflNJaFrBDP9DJ8wYZw=; b=Ful3r16wKNPyjV8LFibKA7vdZA4Mlst4ywmIX2yBlLjZrSkeRATsERKRmx9WKPpOdA 1mae4Ii/073C/drOiwljj3dslYJ03ARIyvosZEH1IL+kx5wR0fa63eXgUh1MI96qiR2C /xEJZisIifgkZbd5NGTj/XJeu9Rm7kCKN+zHd5XLUn5ifrjcWdAxHxPBcRU8hB3a/XEb no3j7XuEu/C86lWr6JRsk5gx+vlNvWurO8evONAzxXhYKlIXkOaeSP2yKSzaIiu1t5HK S3zSrzmoZNCt0XolHIpFlifp59o4hddWbZsbKsabgeTp96FCaX56cXnLE3LJvtOVptQN szSQ== X-Forwarded-Encrypted: i=1; AFNElJ/DxP64NGtOZTxB4iFaERy+CzMSD4eWSBtV0DAgGUiSjesJUToobZQLzYJ2MGVzBm8pl1shglgoCPb+roA=@vger.kernel.org X-Gm-Message-State: AOJu0YwsWK9VeGGjUgaQaS7NuJGQO6T92xlwgH+/HwyCcihS/h7l3X8j yv+fEGdDWroTGxxsC4Y5EuxWJ3nxZc7ubkCvVXaSSG00EF1d5Qi3zJWD8L0YCjHWDBTp9cJ+24/ 1ZJLfDx1ru89TiDNaaIdNSN+TSMGZ2ssY3tbXo8YbXNZD3X9oc71UWjEf/6AMddDbA4U= X-Gm-Gg: Acq92OE0tqlub1XL3fDwxGF3zi7+fANZRl+TKT/eIQqnexaqrpCATQ1yWZA/WP4eVjI HqCqVWeSz6OcimAA+8lu/7mL/XMipbvM+H143Gwqr6pQ9nkxrht6KBd2xvwSJayGbLpNG3NvXii +QAUGEmSVAK4gGpxNIL2dLoO3fW6tmeFEb7syywdyl5PS2m8VyYfZKLQA3CD7cXTAdKkPAzb26h 02iraWyG0vk7/dWWHxbgiu618oub4NS841Hq58AcL0EHPDmD5GaFXLKROVPlnhcH4pT0XSJ223j 0zIzxKzTZFTItL4/JtXKOgikxthguqHaTcgvllHZFbu3KQM8T9hqaxbYbLkgmQVr0otH7hhFNRm 6G5bLs9GQZsyqIJ3gFtLyTJkBMPpKdhrwd27ZBAuhiw0o1+mwh5z9oVl+rhlC6ISy X-Received: by 2002:a05:6a00:a383:b0:842:7992:bdd6 with SMTP id d2e1a72fcca58-842b0f09549mr14744922b3a.36.1780899731135; Sun, 07 Jun 2026 23:22:11 -0700 (PDT) X-Received: by 2002:a05:6a00:a383:b0:842:7992:bdd6 with SMTP id d2e1a72fcca58-842b0f09549mr14744895b3a.36.1780899730701; Sun, 07 Jun 2026 23:22:10 -0700 (PDT) Received: from [10.206.105.200] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-842828e1e5bsm16605322b3a.46.2026.06.07.23.22.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 07 Jun 2026 23:22:10 -0700 (PDT) Message-ID: <94d5ffeb-05fc-5bc5-89e9-9381f85c314d@oss.qualcomm.com> Date: Mon, 8 Jun 2026 11:52:05 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] media: qcom: venus: add callback parameter names Content-Language: en-US To: Hungyu Lin , vikash.garodia@oss.qualcomm.com, bod@kernel.org, mchehab@kernel.org Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260604001859.33353-1-dennylin0707@gmail.com> From: Vishnu Reddy In-Reply-To: <20260604001859.33353-1-dennylin0707@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA4MDA1NiBTYWx0ZWRfXynuuwomOYtFg WmxHXpy/t5/sAgncnbG0OrYn8ThmBxrfq+KLcaf6HfMk2tZV2GvflUg+fUcBohGvFOBMLR8rWa7 Ku9JIcGlKQY2vSYtdneUjrB+Rjb9WrUbaswysQ5tsmaeB3DFBTQjb+AYpFIH2pz5AxRIIn0eK0u cNsycU8bSQjHiX9XLu4/THnarq10SYlMfmVo+98DIqeIfmWI7HINhnrgKkFaSOjy3etXQsasPfk t2Wpyn+tABMVL8RV8CtdBX8LgHQ5w7+iyOLqIPBH/3APH/1mgmMmPlUoPtlPAwgIRZsxeUPEdrh M/dw2e/+uh5A3rEFu/645PCjlGb9+jRFXBC1FUzTxnamFNEAxQIrR6iomjdYTkUvqKAi+aZ8ETQ gPtDJ28V6arkNDAgZyzYaZXsbxV5roEdmzNe9wYnMf/AJu9x50oywuowiGWUwVodClu1S/hJAtv YjxSReSD1fasbeiLqeg== X-Proofpoint-ORIG-GUID: kOwMPAH17FIblq9JVlsBKjd2s-OjqfXv X-Proofpoint-GUID: kOwMPAH17FIblq9JVlsBKjd2s-OjqfXv X-Authority-Analysis: v=2.4 cv=TIB1jVla c=1 sm=1 tr=0 ts=6a265f94 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=D_lHRmgbTm7AOjN1lH0A:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-08_01,2026-06-05_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 phishscore=0 clxscore=1015 adultscore=0 priorityscore=1501 bulkscore=0 malwarescore=0 suspectscore=0 spamscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606080056 On 6/4/2026 5:48 AM, Hungyu Lin wrote: > Naming the callback parameters improves readability and resolves > checkpatch warnings about unnamed function pointer arguments. > > No functional change intended. > > Signed-off-by: Hungyu Lin > --- > drivers/media/platform/qcom/venus/hfi_msgs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/qcom/venus/hfi_msgs.c b/drivers/media/platform/qcom/venus/hfi_msgs.c > index 47b99d5b5af7..5c2025c5acc7 100644 > --- a/drivers/media/platform/qcom/venus/hfi_msgs.c > +++ b/drivers/media/platform/qcom/venus/hfi_msgs.c > @@ -690,7 +690,7 @@ struct hfi_done_handler { > u32 pkt; > u32 pkt_sz; > u32 pkt_sz2; > - void (*done)(struct venus_core *, struct venus_inst *, void *); > + void (*done)(struct venus_core *core, struct venus_inst *inst, void *packet); > bool is_sys_pkt; > }; > Reviewed-by: Vishnu Reddy