From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIM_INVALID, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 099DFECDFB8 for ; Tue, 24 Jul 2018 01:52:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AED5020852 for ; Tue, 24 Jul 2018 01:52:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="hMuw3J8A" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AED5020852 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388382AbeGXC43 (ORCPT ); Mon, 23 Jul 2018 22:56:29 -0400 Received: from merlin.infradead.org ([205.233.59.134]:49878 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388194AbeGXC43 (ORCPT ); Mon, 23 Jul 2018 22:56:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=NvoN985tWhIwUfmLOK//7CJ9m1/iqp1m/GwgveuHWpE=; b=hMuw3J8APjwtpYQ/XgJTokqhOM LcFkVSz9yYQUCJWNoPhmEe3xlBz/20WrJiZUDNuwJoouE4+j7px41dpOPDrKNZip9cZ3arrq+3CvV 8Mh8dZTdPlUJQ/1NgpMW35VyM0YBnjuCOUwqLc1SjLWAI3+kBj+LHqK7JRX9CjSiEJ4mv7BjxmdIJ 2GCr3CR46skzJTBsVBAQgS2Bi94z14S8nM/Ag8N0Q9gM5crSkBEbA2wLAtxlCUHjo4D0oGLQvDX8y tQr6nGJ6JGSTLVAE283ZCVk1T/T0VRJOGOO+5DjNJM7zFJI8inf5UnCCCCL/+d6Vu7WVeSkyGmUCT Az7R7UVA==; Received: from static-50-53-52-16.bvtn.or.frontiernet.net ([50.53.52.16] helo=midway.dunlab) by merlin.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1fhmV2-0003nz-K0; Tue, 24 Jul 2018 01:52:28 +0000 Subject: Re: m68k allmodconfig build errors To: Andreas Schwab Cc: LKML , Geert Uytterhoeven , linux-m68k@lists.linux-m68k.org References: <28ebe45d-3dbd-2a82-f537-b0725f7a2bcf@infradead.org> <878t66idai.fsf@igel.home> From: Randy Dunlap Message-ID: <94dc0357-10d4-c3dc-ef2a-9643f08d2a09@infradead.org> Date: Mon, 23 Jul 2018 18:52:27 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <878t66idai.fsf@igel.home> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/20/2018 12:20 AM, Andreas Schwab wrote: > On Jul 19 2018, Randy Dunlap wrote: > >> block/partitions/ldm.o: In function `ldm_partition': >> ldm.c:(.text+0x1900): undefined reference to `strcmp' >> ldm.c:(.text+0x1964): undefined reference to `strcmp' >> drivers/rtc/rtc-proc.o: In function `is_rtc_hctosys': >> rtc-proc.c:(.text+0x290): undefined reference to `strcmp' >> drivers/watchdog/watchdog_pretimeout.o: In function `watchdog_register_governor': >> (.text+0x142): undefined reference to `strcmp' > > GCC has optimized strncmp to strcmp, but at a stage where macros are no > longer available. I think the right fix is to use strcmp directly, > since strncmp doesn't make sense here. Hi Andreas, I don't see that all of these string compare fields are null-terminated. How does one convert strncmp() users to strcmp()? thanks, -- ~Randy