From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932423AbdDRQzj (ORCPT ); Tue, 18 Apr 2017 12:55:39 -0400 Received: from mout.web.de ([212.227.15.14]:53097 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751753AbdDRQzh (ORCPT ); Tue, 18 Apr 2017 12:55:37 -0400 Subject: [PATCH 5/6] ACPI-battery: Replace 16 seq_printf() calls by seq_puts() From: SF Markus Elfring To: linux-acpi@vger.kernel.org, Borislav Petkov , Chun-Yi Lee , Colin Ian King , Dan Williams , Len Brown , Linda Knippers , "Rafael J. Wysocki" , Tony Luck , Vishal Verma , Zhang Rui Cc: LKML , kernel-janitors@vger.kernel.org References: <077115e4-8ec3-9c6d-0374-8ffc5e0f85c0@users.sourceforge.net> Message-ID: <94dc09f1-dcd5-13c4-9b5d-a6b53cf8da94@users.sourceforge.net> Date: Tue, 18 Apr 2017 18:55:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: <077115e4-8ec3-9c6d-0374-8ffc5e0f85c0@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:kxSkE5SrnGhe2bsLX7ChGth9dufhi7XNhffJMqORmyHjdd2KS88 1V9gKlndw/V8AEPtn71isxdb7amDRqC4xCBiJRKRRs2jeGZM030zV/VNB0g05+iAjFcFEwz Hd4psMPrfhruOlzaQSYDUmWN9QFMEpmA8ZwUx68SBn5DFAqcuNoCbUF4M68FZdxcTTATTPZ eVtu0u3qxhNFtuxfR4J1Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:M7KHXHVRU1o=:JA12RNph8FLnHn4SnBgnXH RyGsOATCUymylbTIpaLzVwp6xq2VRtMwtGVOh9Gf336ufW9iqedKPQM7LigCo0NQ4FFzloZt3 tLI43zBwRG17xPvT8wV5QkKhu9py9+2W4yLkV9GLy95W1Qq9hZ3gMP6ie9Nru4BfHW0lurc5f pspYALEYlVtOEOIGS7wl0BxI2NeDDMPIz8lZ7vrS13St1+gWc8DTIug8nJhaIuZmFm4HDLuSy +ma0TtmiJA3rhzvt5faqeC2YFGBtPvfi6cR6SvYW3qbWjSD+jDAug1mpAOB0NwCzVyrmVp+wr /6mH4uhGTnHC+10mzYLG8uj9j73sCUnXvq0FT9MtEAjyBncnNIIA8Or7TfRL6CiOzdIsPRIIp V7BaYLeWwQaKzchddp/kAl7XHPXfKWkPpuBD31r50Sm2FajtKJUTjb0YWAPzmOuFd6wGrNvnW oMLv+3pSm/++B5KGrg88St89BV5Q2UMjpXZwMqJwhEIonZVArJV1lBTRvvPxsLtUk6A8u0EV3 YvtxDqxL3BfAzmaJXy0rn3PpbhhzzZYZgSVjHiIBDVhPaOU/wJWl1tsF2nC1t2lbpRg1Xqw2T /LOXDHwptArH6670HUupHEAT7TU9jNF9u5cfBco1NAhzOAf42S0Uhzy8/QDaagMFvWsfVoSdp 0oH55fmIQyW6w69gokb4pMSP6AQEo6IJjQ7zvjbtf0oad4z4AIb/d5MyaM05Jjnmml0BkoHd5 p1Y6G+fJXl/cz1hCnAEKiZRJWDBicasWRQ2deeTZJumEldrnAY4vp619xro31pQZz/X5hB98j EOeXgxW Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Tue, 18 Apr 2017 18:04:22 +0200 Strings which did not contain data format specifications should be put into a sequence. Thus use the corresponding function "seq_puts". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/acpi/battery.c | 34 +++++++++++++++++----------------- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c index 4ef1e4624b2b..d217e1c18b42 100644 --- a/drivers/acpi/battery.c +++ b/drivers/acpi/battery.c @@ -825,14 +825,14 @@ static int acpi_battery_print_info(struct seq_file *seq, int result) if (!acpi_battery_present(battery)) goto end; if (battery->design_capacity == ACPI_BATTERY_VALUE_UNKNOWN) - seq_printf(seq, "design capacity: unknown\n"); + seq_puts(seq, "design capacity: unknown\n"); else seq_printf(seq, "design capacity: %d %sh\n", battery->design_capacity, acpi_battery_units(battery)); if (battery->full_charge_capacity == ACPI_BATTERY_VALUE_UNKNOWN) - seq_printf(seq, "last full capacity: unknown\n"); + seq_puts(seq, "last full capacity: unknown\n"); else seq_printf(seq, "last full capacity: %d %sh\n", battery->full_charge_capacity, @@ -842,7 +842,7 @@ static int acpi_battery_print_info(struct seq_file *seq, int result) (!battery->technology)?"non-":""); if (battery->design_voltage == ACPI_BATTERY_VALUE_UNKNOWN) - seq_printf(seq, "design voltage: unknown\n"); + seq_puts(seq, "design voltage: unknown\n"); else seq_printf(seq, "design voltage: %d mV\n", battery->design_voltage); @@ -865,7 +865,7 @@ static int acpi_battery_print_info(struct seq_file *seq, int result) seq_printf(seq, "OEM info: %s\n", battery->oem_info); end: if (result) - seq_printf(seq, "ERROR: Unable to read battery info\n"); + seq_puts(seq, "ERROR: Unable to read battery info\n"); return result; } @@ -884,34 +884,34 @@ static int acpi_battery_print_state(struct seq_file *seq, int result) seq_printf(seq, "capacity state: %s\n", (battery->state & 0x04) ? "critical" : "ok"); if ((battery->state & 0x01) && (battery->state & 0x02)) - seq_printf(seq, - "charging state: charging/discharging\n"); + seq_puts(seq, + "charging state: charging/discharging\n"); else if (battery->state & 0x01) - seq_printf(seq, "charging state: discharging\n"); + seq_puts(seq, "charging state: discharging\n"); else if (battery->state & 0x02) - seq_printf(seq, "charging state: charging\n"); + seq_puts(seq, "charging state: charging\n"); else - seq_printf(seq, "charging state: charged\n"); + seq_puts(seq, "charging state: charged\n"); if (battery->rate_now == ACPI_BATTERY_VALUE_UNKNOWN) - seq_printf(seq, "present rate: unknown\n"); + seq_puts(seq, "present rate: unknown\n"); else seq_printf(seq, "present rate: %d %s\n", battery->rate_now, acpi_battery_units(battery)); if (battery->capacity_now == ACPI_BATTERY_VALUE_UNKNOWN) - seq_printf(seq, "remaining capacity: unknown\n"); + seq_puts(seq, "remaining capacity: unknown\n"); else seq_printf(seq, "remaining capacity: %d %sh\n", battery->capacity_now, acpi_battery_units(battery)); if (battery->voltage_now == ACPI_BATTERY_VALUE_UNKNOWN) - seq_printf(seq, "present voltage: unknown\n"); + seq_puts(seq, "present voltage: unknown\n"); else seq_printf(seq, "present voltage: %d mV\n", battery->voltage_now); end: if (result) - seq_printf(seq, "ERROR: Unable to read battery state\n"); + seq_puts(seq, "ERROR: Unable to read battery state\n"); return result; } @@ -924,18 +924,18 @@ static int acpi_battery_print_alarm(struct seq_file *seq, int result) goto end; if (!acpi_battery_present(battery)) { - seq_printf(seq, "present: no\n"); + seq_puts(seq, "present: no\n"); goto end; } - seq_printf(seq, "alarm: "); + seq_puts(seq, "alarm: "); if (!battery->alarm) - seq_printf(seq, "unsupported\n"); + seq_puts(seq, "unsupported\n"); else seq_printf(seq, "%u %sh\n", battery->alarm, acpi_battery_units(battery)); end: if (result) - seq_printf(seq, "ERROR: Unable to read battery alarm\n"); + seq_puts(seq, "ERROR: Unable to read battery alarm\n"); return result; } -- 2.12.2