From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752212AbcIAHFk (ORCPT ); Thu, 1 Sep 2016 03:05:40 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:41909 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750881AbcIAHFh (ORCPT ); Thu, 1 Sep 2016 03:05:37 -0400 X-AuditID: cbfec7f4-f79cb6d000001359-c6-57c7d30c52e0 Subject: Re: [PATCH RFC] ARM: dts: samsung: add rga-lvds panel in itop elite To: ayaka , devicetree References: <1472511002-9019-1-git-send-email-ayaka@soulik.info> <790048d1-6533-2e43-5343-13782382bf84@soulik.info> Cc: Mark Rutland , linux-samsung-soc@vger.kernel.org, linux@armlinux.org.uk, krzk@kernel.org, linux-kernel@vger.kernel.org, kyungmin.park@samsung.com, kgene@kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, thierry.reding@gmail.com From: Andrzej Hajda Message-id: <94dc2e0d-2521-a636-ee3d-90168f30fe28@samsung.com> Date: Thu, 01 Sep 2016 09:04:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-version: 1.0 In-reply-to: <790048d1-6533-2e43-5343-13782382bf84@soulik.info> Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpnkeLIzCtJLcpLzFFi42I5/e/4ZV2ey8fDDVbMErZ4dfcXo8X8I+dY La58fc9m0f/4NbPF+fMb2C3ONr1ht9j0+BqrxeVdc9gsZpzfx2RxaOpeRoul1y8yWfzcNY/F gcdjzbw1jB6Xr11k9tg56y67x6ZVnWwe97uPM3lsXlLv0bdlFaNH893prB6fN8kFcEZx2aSk 5mSWpRbp2yVwZay/uJi1YIJKxdWeA4wNjKcluxg5OCQETCSefM3vYuQEMsUkLtxbz9bFyMUh JLCUUeJ6/w4WCOc5o8SexwtYQKqEBXwkpp2bCWaLCLhJ3LvbxwhRtIpR4svDO0wgDrPAEiaJ xoW/WEGq2AQ0Jf5uvskGYvMK2Ek837EJrJtFQFXi7OEmMFtUIELi1qqPjBA1ghI/Jt8Di3MK 2EssfrWEHeRUZgF1iSlTckHCzALyEpvXvGWewCgwC0nHLISqWUiqFjAyr2IUTS1NLihOSs81 1CtOzC0uzUvXS87P3cQIiZ4vOxgXH7M6xCjAwajEw+vw5li4EGtiWXFl7iFGCQ5mJRHeorPH w4V4UxIrq1KL8uOLSnNSiw8xSnOwKInzzt31PkRIID2xJDU7NbUgtQgmy8TBKdXAmGGTl/L9 sEd1/95suzdiedv1BR93b9ZdnG3pVXqpXmRzudvfu73PX9zt12KalDY/WcstRXut6rQuW1lO iazrgXH8i08eOl12e4J1cdHzc7ZsDp8847pP9JdbfpWzfve/MdboV8c3UcWPdv+7CmV6+jo1 GZ3mF737l3XtZm+t+8eN+ySEHzAosRRnJBpqMRcVJwIAhmEqbpoCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/31/2016 07:55 PM, ayaka wrote: > > On 08/31/2016 08:30 PM, Andrzej Hajda wrote: >> Hi, >> >> >> On 08/30/2016 12:50 AM, Randy Li wrote: >>> It is actually a lvds panel connected through a rga-lvds bridge. >>> But I really have no idea about what does a port mean in fimd node. >>> >>> Also how should I configure this panel size? I think the i2c found >>> on the panel schematic, but it more likely to be used a touch screen >>> touth. Also the touch screen is not supported in currently driver. >>> >>> Signed-off-by: Randy Li >>> --- >>> arch/arm/boot/dts/exynos4412-itop-elite.dts | 35 ++++++++++++++++++++++++++--- >>> 1 file changed, 32 insertions(+), 3 deletions(-) >>> >>> diff --git a/arch/arm/boot/dts/exynos4412-itop-elite.dts b/arch/arm/boot/dts/exynos4412-itop-elite.dts >>> index e1cda54..2d67385 100644 >>> --- a/arch/arm/boot/dts/exynos4412-itop-elite.dts >>> +++ b/arch/arm/boot/dts/exynos4412-itop-elite.dts >>> @@ -139,6 +139,20 @@ >>> assigned-clocks = <&clock CLK_MOUT_CAM0>; >>> assigned-clock-parents = <&clock CLK_XUSBXTI>; >>> }; >>> + >>> + vcc_sys_lcd: sys-lcd { >>> + compatible = "regulator-fixed"; >>> + regulator-name = "vcc_5v"; >>> + regulator-min-microvolt = <5000000>; >>> + regulator-max-microvolt = <5000000>; >>> + gpio = <&gpl0 4 GPIO_ACTIVE_HIGH>; >>> + }; >>> + >>> + panel: panel { >>> + ddc-i2c-bus = <&i2c_3>; >>> + power-supply = <&vcc_sys_lcd>; >>> + enable-gpios = <&gpl0 2 GPIO_ACTIVE_HIGH>; >>> + }; >> Panel has no compatible string, which driver will handle this node? > The problem is that, it is panel not supported by kernel. For simple panel you can take a look at [1][2]. Ie. if the panel needs only power supply and enable gpio, you just need to add few lines to [2]. [1]: Documentation/devicetree/bindings/display/panel/simple-panel.txt [2]: drivers/gpu/drm/panel/panel-simple.c > Is it possible > to support without adding a new driver for it ? I know there is a > simple-dpi for MIPI, but what is for parallel video or lvds? simple-dpi is just parallel output. LVDS is not supported by Exynos4412 but boards usually have RGB/LVDS bridge for such panels, I have no access to itop board schematics, but I suppose it has such bridge. LVDS bridges often do not need Linux driver, so from developer point of view LVDS panels with such bridge are handled the same way as RGB panels. Example fimd bindings for RGB panels are in [3]. [3]: arch/arm/boot/dts/exynos4210-universal_c210.dts >> Regards >> Andrzej > The other problem is that I don't how to configure the display-times, > the datasheet for CLAA070WP03XG only talk about total time, active time > and blank time for both Horizontal an Vertical time. Does it mean the > front-porch and sync-len for horizontal and vertical are zero ? You can look at vendor's code. Or just experiment with different values. The equation is: total=active+back_porch+blank+front_porch. So if htotal=864, hactive=800, hblank=64, then hporches are 0. In case of vtotal=1288, vactive=1200, vblank=8 you have left 80 for porches, you can try to split them equally for front and back for starters. Regards Andrzej > > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + port@3 { > + reg = <3>; > + rga_lvds: endpoint { > + remote-endpoint = <&panel>; > + }; > + }; > + }; > + > + panel: panel@0 { > + compatible = "panel-simple"; > + > + power-supply = <&vcc_sys_lcd>; > + enable-gpios = <&gpl0 2 GPIO_ACTIVE_HIGH>; > + display-timings { > + timing-0 { > + clock-frequency = <66770000>; > + hactive = <800>; > + vactive = <1280>; > + hfront-porch = <0>; > + hback-porch = <64>; > + hsync-len = <0>; > + vfront-porch = <0>; > + vback-porch = <8>; > + vsync-len = <0>; > + }; > + }; > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > >