From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60070C04A6A for ; Tue, 15 Aug 2023 16:00:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238376AbjHOQA3 (ORCPT ); Tue, 15 Aug 2023 12:00:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238442AbjHOQAC (ORCPT ); Tue, 15 Aug 2023 12:00:02 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA09410F; Tue, 15 Aug 2023 09:00:00 -0700 (PDT) Received: from [192.168.88.20] (91-154-35-171.elisa-laajakaista.fi [91.154.35.171]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 135BE2CF; Tue, 15 Aug 2023 17:58:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1692115126; bh=Dnd/cluCU2tJlyL5IE/vj5RGc9tRSKrNvv0CBVqiJT0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=sJa/4ZlsiHqxJZpaZB6CPNhkoXDTp6lqWqtDiwPfsuiaa3jCmK8d1CQ9+N7NbmAK/ /teo3klkb0iW/bWdPbO19fp6zCAYAMLJMFeDkjNp7Eq9mxq7NAhJ4qoE6yiI1XGuU8 U4HPksBN5yMS9NtNXSn2wKwEkFbrgqUySHtdsHos= Message-ID: <94dd2237-2a4a-fb45-ceb1-f224fafd4e36@ideasonboard.com> Date: Tue, 15 Aug 2023 18:59:55 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] i2c: Make I2C_ATR invisible Content-Language: en-US To: Geert Uytterhoeven , Wolfram Sang , Sakari Ailus , Andy Shevchenko , Luca Ceresoli Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org References: <588d302477cb7e6b30b52ee6448807324c57b88a.1692113321.git.geert+renesas@glider.be> From: Tomi Valkeinen In-Reply-To: <588d302477cb7e6b30b52ee6448807324c57b88a.1692113321.git.geert+renesas@glider.be> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/08/2023 18:29, Geert Uytterhoeven wrote: > I2C Address Translator (ATR) support is not a stand-alone driver, but a > library. All of its users select I2C_ATR. Hence there is no need for > the user to enable this symbol manually, except when compile-testing. > > Fixes: a076a860acae77bb ("media: i2c: add I2C Address Translator (ATR) support") > Signed-off-by: Geert Uytterhoeven > --- > Do we care yet about out-of-tree drivers that need this functionality? > --- > drivers/i2c/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig > index c6d1a345ea6d8aee..9388823bb0bb960c 100644 > --- a/drivers/i2c/Kconfig > +++ b/drivers/i2c/Kconfig > @@ -72,7 +72,7 @@ config I2C_MUX > source "drivers/i2c/muxes/Kconfig" > > config I2C_ATR > - tristate "I2C Address Translator (ATR) support" > + tristate "I2C Address Translator (ATR) support" if COMPILE_TEST > help > Enable support for I2C Address Translator (ATR) chips. > Isn't this normally done with just "tristate", without the text? Is there a need to make configs manually selectable when compile-test is enabled? Tomi