From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8CA55C8FE for ; Tue, 21 Jan 2025 05:58:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737439110; cv=none; b=NX4pMTGEJNtrHCLmqtbNXPvX+ZXkOxPtzd8+VQV8QhaPX87lkzRZRBp/KDJ3SnXzk4FsTDyWKAve3AHBFfAMD8ykRmXleR9Q0IwiNH0Wxd+mCn6WcV88lZjIUUAf1VerXJ24uMe5FIbbRYiGzPNjl2wdqNKjaFEMPovb/roGPlU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737439110; c=relaxed/simple; bh=4QMgwJzbwkAo7m9jT54B+fBzrD1jdkUA8BagCuW5Ld0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=F+itVnad9hgniTRb073mR+5hZ2jQpWFa3eWU236Ky8EyznCIpChwnOg4KUtIEYdQIKZlqzB68+TGzw+/u0M8Buj/1PMnrtzPAZHv2FqFAImpS8tHdYOzZ7/t13tl0Wl/a+7Hz3XVxdlDoVyR+DweCcJAmaETvtlfzclINZHH3is= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dIHxhus6; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dIHxhus6" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-21654fdd5daso87561615ad.1 for ; Mon, 20 Jan 2025 21:58:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737439108; x=1738043908; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=gf7BTqhynulFlNvhIKJUIKF0QGOZDxgKInp8xKSEew0=; b=dIHxhus6huYm+ZUu6nSlsT+eFRo8cn2hdxJnKzx0xa+MkdKtG9bJPXHTHqZABabHGb fH548YsozgIJTfPRn5GVJJrhQP3s6wKoVSDjTWu+co+rmGqZoOLBF1b2mIHXAbJpN12y hSSR/CJe+zovWTsrYK5Cbgy0MW3euHOKSqufz6AqHrvvO6+DpEm01WTQl428hHI1vOfa NhjwsgNZjpzvlgEWd18ZmxqTwi2v0Kl5y5/5aBTuECD/MZygZo+ECNcucFFMLDnCgBBt EBHsQMpve4VTB+g+GEhs8E7wOH2qvIin2jcwgTvTX0XvDDI0yqEw9JUJ5hiH1etr+uJO B2Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737439108; x=1738043908; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gf7BTqhynulFlNvhIKJUIKF0QGOZDxgKInp8xKSEew0=; b=LHgKk7VBenHP6jrqv7opoBGOjLWv1gyhe0rRWE2WZXLvH10deuQ/bayGIC850C6ArD SwTs1clsHz2SJEYZqmmvWFswAyjsTxxOOkkSoCtRL9+cC0QwGWQAOoTjPrMlPPqvHx4v nAHCwtVhfPiUj52dbXCz7x0pgq/PJNwky5GzZfZamRElckl1XfW9fITe2BBH+gm4STRT 9CPxbZB+6FoCJgcChmfMh1Gea2VS1Eh0Uec0r4gEDg/UuMkph2Ptv56o5tOsJy043v3j MRsYzfnutM15CpZbUSLsaPbZNQ0r3ljtGz/+OhUYUWFIp9sQCnliAD1Gw++0EYLyyKMl lXqQ== X-Forwarded-Encrypted: i=1; AJvYcCWHUDJMEhA80fYIdWRdLYmC/LPCzvd7Y3+ae60euY89BlIM+rp/qPOFWl0C3d3wRYuslpsWUrte8wlcUgA=@vger.kernel.org X-Gm-Message-State: AOJu0YxqIzCk4CQk8fXbpM7AqiwB6Tkh7Rs1aTA3gk7y97h4B5faLLjU gV/1DT+9SDJ0bcMTV5WfkRfragCY7chsliVy7yidDWZGsXrgqJVq X-Gm-Gg: ASbGnctb6fduWEFES2HoVtyCyAJV9PudV/smcP5tfZx7OHBag/1lwJ5KE3E72PXOdK1 0/d3JOa5hwr6hXLUMUOrfXfKZUBuqDaf14VwitojGItPRIGNpHIZ+yXs7GVlxu3QfmFlNS92fiw WOTbA1csQwiApZAAUuTizKZXXGboOyXwIRh16eJSIQH22UsIo95VThzCNaefjCwo+XleOT8IBa/ hShIAQ3FLOIYdKHDyKVbusnbCwd24ORM38B8f55xsLaJErwwIK2bIzDAZvdSKfINOw/YjXllpbO zDq1pA0rkHADdC/USaXF/XbTvPA9zg4FWHQBNu1igU4= X-Google-Smtp-Source: AGHT+IEmD+PLXN9nGshymvI8pZzDavtDT8AQK4+DovovAQNvIewFqB/kXP7iVm8P87Ljs7TkRBUH/g== X-Received: by 2002:a17:902:ea03:b0:215:b33b:e26d with SMTP id d9443c01a7336-21c3550c5d3mr262719185ad.21.1737439107609; Mon, 20 Jan 2025 21:58:27 -0800 (PST) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21c2ceba740sm69919465ad.79.2025.01.20.21.58.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jan 2025 21:58:26 -0800 (PST) Sender: Guenter Roeck Message-ID: <94e15b07-bc0c-4c14-8dc7-d488491b42c9@roeck-us.net> Date: Mon, 20 Jan 2025 21:58:24 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Buiild error in i915/xe To: Linus Torvalds , Andy Shevchenko Cc: David Laight , Jani Nikula , David Laight , Arnd Bergmann , "linux-kernel@vger.kernel.org" , Jens Axboe , Matthew Wilcox , Christoph Hellwig , Andrew Morton , Dan Carpenter , "Jason A . Donenfeld" , "pedro.falcato@gmail.com" , Mateusz Guzik , "linux-mm@kvack.org" , Lorenzo Stoakes , intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, David Airlie , Simona Vetter , Rodrigo Vivi References: <29ef57a1-e4dd-4d5d-8726-f1f79c698b66@roeck-us.net> <20250118221123.5bb65e64@pumpkin> <20250119090935.7c690f85@pumpkin> <87ed0xrcb8.fsf@intel.com> <20250120111551.435176c4@pumpkin> <878qr5ras2.fsf@intel.com> <0a65de6c-74d5-4d3e-be75-0aa9ecc82da1@roeck-us.net> <20250120184143.47615b21@pumpkin> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/20/25 11:14, Linus Torvalds wrote: > On Mon, 20 Jan 2025 at 10:55, Andy Shevchenko > wrote: >> >> Excuse me if I am missing something, but clamp() has a warning inside it, correct? >> Why do we need an additional warning on top of that? > > Note: the warning in clamp() only finds compile-time obvious wrong uses. > > It's really meant to notice the trivial case where you clam with > constants and just got the order wrong, so you do something silly like > > res = clamp(in, 15, 1); > > but it does also end up catching slightly more complex things where > the compiler can figure out the range of the clamping. > > The build problem then comes from the compiler doing various *other* > code movem,ent and optimization too, and - like in this case - finds > an error path where the clamping is done "wrong". > > I think the real issue in the i915 driver is that it does that > WARN_ON(), but then it just happily continues anyway. > > So if the i915 driver instead did > > if (WARN_ON(..)) return invalid value; > > none of this would ever have happened. > I'll take a stab and send a patch combining your and David's suggestions. Guenter