From: Markus Elfring <Markus.Elfring@web.de>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Gilles Muller <Gilles.Muller@lip6.fr>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <michal.lkml@markovi.net>,
Nicolas Palix <nicolas.palix@imag.fr>,
Wen Yang <wen.yang99@zte.com.cn>,
Coccinelle <cocci@systeme.lip6.fr>,
LKML <linux-kernel@vger.kernel.org>,
Yi Wang <wang.yi59@zte.com.cn>
Subject: Re: [1/3] Coccinelle: pci_free_consistent: Use formatted strings directly in SmPL rules
Date: Wed, 15 May 2019 07:27:48 +0200 [thread overview]
Message-ID: <94e36a1e-0550-2782-aefc-4ac0b858c843@web.de> (raw)
In-Reply-To: <alpine.DEB.2.21.1905142148460.2612@hadrien>
> NACK. If the code is going to change, I would rather it come closer to
> staying within 80 characters.
Do you really prefer then to deviate from the Linux coding style
at such source code places?
Would you like to split affected string literals over multiple lines?
Regards,
Markus
next prev parent reply other threads:[~2019-05-15 5:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 16:44 [PATCH 0/3] Coccinelle: pci_free_consistent: Adjustments for a SmPL script Markus Elfring
2019-05-14 16:48 ` [PATCH 1/3] Coccinelle: pci_free_consistent: Use formatted strings directly in SmPL rules Markus Elfring
2019-05-14 19:50 ` Julia Lawall
2019-05-15 5:27 ` Markus Elfring [this message]
2019-05-15 6:10 ` [1/3] " Julia Lawall
2019-05-14 16:50 ` [PATCH 2/3] Coccinelle: pci_free_consistent: Reduce a bit of duplicate SmPL code Markus Elfring
2019-05-14 19:47 ` Julia Lawall
2019-05-15 5:35 ` [2/3] " Markus Elfring
2019-05-15 6:11 ` Julia Lawall
2019-05-15 6:11 ` Julia Lawall
2019-05-15 7:02 ` Markus Elfring
[not found] ` <alpine.DEB.2.21.1905150908550.2591@hadrien>
2019-05-15 7:33 ` Coccinelle: Handling of SmPL disjunctions Markus Elfring
[not found] ` <alpine.DEB.2.20.1905151120370.3231@hadrien>
2019-05-15 9:55 ` Markus Elfring
2019-07-09 9:52 ` Markus Elfring
2019-05-14 16:50 ` [PATCH 2/3] Coccinelle: pci_free_consistent: Reduce a bit of duplicate SmPL code Markus Elfring
2019-05-14 16:52 ` [PATCH 3/3] Coccinelle: pci_free_consistent: Extend when constraints for two SmPL ellipses Markus Elfring
2019-05-14 19:50 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94e36a1e-0550-2782-aefc-4ac0b858c843@web.de \
--to=markus.elfring@web.de \
--cc=Gilles.Muller@lip6.fr \
--cc=cocci@systeme.lip6.fr \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
--cc=wang.yi59@zte.com.cn \
--cc=wen.yang99@zte.com.cn \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®