From: Sandipan Das <sandipan.das@amd.com>
To: Jiri Olsa <olsajiri@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
x86@kernel.org, peterz@infradead.org, bp@alien8.de,
acme@kernel.org, namhyung@kernel.org, tglx@linutronix.de,
mingo@redhat.com, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, dave.hansen@linux.intel.com,
like.xu.linux@gmail.com, eranian@google.com,
ananth.narayan@amd.com, ravi.bangoria@amd.com,
santosh.shukla@amd.com
Subject: Re: [PATCH 2/4] tools headers x86: Sync msr-index.h with kernel sources
Date: Fri, 12 Aug 2022 14:33:46 +0530 [thread overview]
Message-ID: <94f483f5-c541-2a1e-87f6-a4105c30a045@amd.com> (raw)
In-Reply-To: <YvYQQr5VenglbpWM@krava>
Hi Jiri,
On 8/12/2022 2:03 PM, Jiri Olsa wrote:
> On Thu, Aug 11, 2022 at 06:16:47PM +0530, Sandipan Das wrote:
>> Sync msr-index.h with the kernel sources by adding the new AMD Last Branch
>> Record Extension Version 2 (LbrExtV2) MSRs.
>>
>> Signed-off-by: Sandipan Das <sandipan.das@amd.com>
>> ---
>> tools/arch/x86/include/asm/msr-index.h | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/tools/arch/x86/include/asm/msr-index.h b/tools/arch/x86/include/asm/msr-index.h
>> index cc615be27a54..7f9eaf497947 100644
>> --- a/tools/arch/x86/include/asm/msr-index.h
>> +++ b/tools/arch/x86/include/asm/msr-index.h
>> @@ -574,6 +574,9 @@
>> #define MSR_AMD64_PERF_CNTR_GLOBAL_CTL 0xc0000301
>> #define MSR_AMD64_PERF_CNTR_GLOBAL_STATUS_CLR 0xc0000302
>>
>> +/* AMD Last Branch Record MSRs */
>> +#define MSR_AMD64_LBR_SELECT 0xc000010e
>
> curious do we actualy use this in tools somewhere?
>
> jirka
>
Commit 9dde6cadb92b ("tools arch x86: Sync the msr-index.h copy with the kernel sources")
from Arnaldo says that adding these new MSR definitions in the tools headers allows the
beautification scripts to pick up new entries which can be used for filtering MSR access
traces.
E.g. one can trace the hardware LBR branch filter bits getting written to the LBR_SELECT
MSR while recording branches.
$ perf record -j any,u true
$ perf record -j any_call,u true
$ sudo perf trace -e msr:write_msr/max-stack=32/ --filter="msr == AMD64_LBR_SELECT"
[...]
224568.130 perf/9093 msr:write_msr(msr: AMD64_LBR_SELECT, val: 1)
do_trace_write_msr ([kernel.kallsyms])
do_trace_write_msr ([kernel.kallsyms])
native_write_msr ([kernel.kallsyms])
amd_pmu_lbr_enable_all ([kernel.kallsyms])
amd_pmu_v2_enable_all ([kernel.kallsyms])
x86_pmu_enable ([kernel.kallsyms])
ctx_resched ([kernel.kallsyms])
perf_event_exec ([kernel.kallsyms])
begin_new_exec ([kernel.kallsyms])
load_elf_binary ([kernel.kallsyms])
bprm_execve ([kernel.kallsyms])
do_execveat_common.isra.0 ([kernel.kallsyms])
__x64_sys_execve ([kernel.kallsyms])
do_syscall_64 ([kernel.kallsyms])
entry_SYSCALL_64 ([kernel.kallsyms])
execve (/usr/lib/x86_64-linux-gnu/libc.so.6)
[...]
302748.439 perf/9126 msr:write_msr(msr: AMD64_LBR_SELECT, val: 229)
do_trace_write_msr ([kernel.kallsyms])
do_trace_write_msr ([kernel.kallsyms])
native_write_msr ([kernel.kallsyms])
amd_pmu_lbr_enable_all ([kernel.kallsyms])
amd_pmu_v2_enable_all ([kernel.kallsyms])
x86_pmu_enable ([kernel.kallsyms])
ctx_resched ([kernel.kallsyms])
perf_event_exec ([kernel.kallsyms])
begin_new_exec ([kernel.kallsyms])
load_elf_binary ([kernel.kallsyms])
bprm_execve ([kernel.kallsyms])
do_execveat_common.isra.0 ([kernel.kallsyms])
__x64_sys_execve ([kernel.kallsyms])
do_syscall_64 ([kernel.kallsyms])
entry_SYSCALL_64 ([kernel.kallsyms])
execve (/usr/lib/x86_64-linux-gnu/libc.so.6)
[...]
I can add this example to the commit message in the next revision.
- Sandipan
next prev parent reply other threads:[~2022-08-12 9:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-11 12:46 [PATCH 0/4] tools perf: Add branch speculation info Sandipan Das
2022-08-11 12:46 ` [PATCH 1/4] tools headers uapi: Sync perf_event.h with kernel sources Sandipan Das
2022-08-11 12:46 ` [PATCH 2/4] tools headers x86: Sync msr-index.h " Sandipan Das
2022-08-12 8:33 ` Jiri Olsa
2022-08-12 9:03 ` Sandipan Das [this message]
2022-08-12 13:33 ` Arnaldo Carvalho de Melo
2022-08-12 19:39 ` Arnaldo Carvalho de Melo
2022-08-16 5:10 ` Sandipan Das
2022-08-11 12:46 ` [PATCH 3/4] perf script: Show branch speculation info Sandipan Das
2022-08-11 12:46 ` [PATCH 4/4] perf session: Show branch speculation info in raw dump Sandipan Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94f483f5-c541-2a1e-87f6-a4105c30a045@amd.com \
--to=sandipan.das@amd.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=ananth.narayan@amd.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=eranian@google.com \
--cc=like.xu.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=olsajiri@gmail.com \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
--cc=santosh.shukla@amd.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®