mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: "J.D. Schroeder" <Linux.HWI@garmin.com>,
	<linux-kernel@vger.kernel.org>, <lgirdwood@gmail.com>,
	<broonie@kernel.org>, <perex@perex.cz>, <tiwai@suse.com>,
	<jsarha@ti.com>, <alsa-devel@alsa-project.org>
Cc: Jim Lodes <jim.lodes@garmin.com>,
	"J.D. Schroeder" <jay.schroeder@garmin.com>
Subject: Re: [PATCH] ASoC: davinci-mcasp: Fix overwriting of ahclkx
Date: Fri, 29 Apr 2016 16:19:31 +0300	[thread overview]
Message-ID: <94fc59a7-7f27-bc97-328e-33f1e7c1cb65@ti.com> (raw)
In-Reply-To: <1461600490-19504-1-git-send-email-Linux.HWI@garmin.com>

On 04/25/2016 07:08 PM, J.D. Schroeder wrote:
> From: Jim Lodes <jim.lodes@garmin.com>
> 
> The mcasp davinci_mcasp_set_dai_fmt function was overriding ahclkx
> input/output status that had already been set by the
> davinci_mcasp_set_sysclk function. This commit removes clearing
> of the ahclkx input/output status from davinci_mcasp_set_dai_fmt.

Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>

> 
> Signed-off-by: Jim Lodes <jim.lodes@garmin.com>
> Signed-off-by: J.D. Schroeder <jay.schroeder@garmin.com>
> ---
>  sound/soc/davinci/davinci-mcasp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c
> index e132498..a1197ad 100644
> --- a/sound/soc/davinci/davinci-mcasp.c
> +++ b/sound/soc/davinci/davinci-mcasp.c
> @@ -489,7 +489,7 @@ static int davinci_mcasp_set_dai_fmt(struct snd_soc_dai *cpu_dai,
>  		mcasp_clr_bits(mcasp, DAVINCI_MCASP_RXFMCTL_REG, AFSRE);
>  
>  		mcasp_clr_bits(mcasp, DAVINCI_MCASP_PDIR_REG,
> -			       ACLKX | AHCLKX | AFSX | ACLKR | AHCLKR | AFSR);
> +			       ACLKX | AFSX | ACLKR | AHCLKR | AFSR);
>  		mcasp->bclk_master = 0;
>  		break;
>  	default:
> 


-- 
Péter

      reply	other threads:[~2016-04-29 13:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-25 16:08 J.D. Schroeder
2016-04-29 13:19 ` Peter Ujfalusi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=94fc59a7-7f27-bc97-328e-33f1e7c1cb65@ti.com \
    --to=peter.ujfalusi@ti.com \
    --cc=Linux.HWI@garmin.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=jay.schroeder@garmin.com \
    --cc=jim.lodes@garmin.com \
    --cc=jsarha@ti.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®