From: Neil Armstrong <neil.armstrong@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>,
Liu Ying <victor.liu@nxp.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Robert Foss <rfoss@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/3] Revert "driver core: Export device_is_dependent() to modules"
Date: Tue, 28 Nov 2023 09:24:16 +0100 [thread overview]
Message-ID: <95016bb1-64de-4963-9a5e-7201923a5ae2@linaro.org> (raw)
In-Reply-To: <20231128-revert-panel-fix-v1-1-69bb05048dae@linaro.org>
On 28/11/2023 00:10, Linus Walleij wrote:
> This reverts commit 1d5e8f4bf06da86b71cc9169110d1a0e1e7af337.
>
> Greg says: "why exactly is this needed? Nothing outside of
> the driver core should be needing this function, it shouldn't
> be public at all (I missed that before.)
>
> So please, revert it for now, let's figure out why DRM thinks
> this is needed for it's devices, and yet no other bus/subsystem
> does."
>
> Link: https://lore.kernel.org/dri-devel/2023112739-willing-sighing-6bdd@gregkh/
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> drivers/base/core.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/base/core.c b/drivers/base/core.c
> index bfd2bf0364b7..67ba592afc77 100644
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -328,7 +328,6 @@ int device_is_dependent(struct device *dev, void *target)
> }
> return ret;
> }
> -EXPORT_SYMBOL_GPL(device_is_dependent);
>
> static void device_link_init_status(struct device_link *link,
> struct device *consumer,
>
Acked-by: Neil Armstrong <neil.armstrong@linaro.org>
next prev parent reply other threads:[~2023-11-28 8:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 23:10 [PATCH 0/3] Revert panel fixes and original buggy patch Linus Walleij
2023-11-27 23:10 ` [PATCH 1/3] Revert "driver core: Export device_is_dependent() to modules" Linus Walleij
2023-11-28 8:24 ` Neil Armstrong [this message]
2023-11-27 23:10 ` [PATCH 2/3] Revert "drm/bridge: panel: Check device dependency before managing device link" Linus Walleij
2023-11-28 8:24 ` Neil Armstrong
2023-11-27 23:10 ` [PATCH 3/3] Revert "drm/bridge: panel: Add a device link between drm device and panel device" Linus Walleij
2023-11-28 8:24 ` Neil Armstrong
2023-11-27 23:25 ` [PATCH 0/3] Revert panel fixes and original buggy patch Laurent Pinchart
2023-11-27 23:36 ` Linus Walleij
2023-11-27 23:52 ` Laurent Pinchart
2023-11-28 8:28 ` Greg Kroah-Hartman
2023-11-28 8:30 ` Neil Armstrong
2023-11-28 9:34 ` Linus Walleij
2023-11-28 10:04 ` neil.armstrong
2023-11-28 10:12 ` (subset) " Neil Armstrong
2023-11-28 10:13 ` Neil Armstrong
2023-11-28 10:16 ` Linus Walleij
2023-11-28 12:27 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95016bb1-64de-4963-9a5e-7201923a5ae2@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=rafael@kernel.org \
--cc=rfoss@kernel.org \
--cc=tzimmermann@suse.de \
--cc=victor.liu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®