From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f53.google.com (mail-ot1-f53.google.com [209.85.210.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B2D93783BE for ; Sat, 31 Jan 2026 21:19:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769894398; cv=none; b=pXvSud7RG2+/3SfZjeQ0uxA3TLt06+AE+OUmFXOF4J74C936x/T0TaPtESZ03Ry5XWThpi3veUi030woaXa7LtgrliirY/IZTq2n1FlPqo0RSR/BK+SaclXK0T0j5hPWiby/s7p6/yiutE2c40LtKxaJDtZOmYm4RzxJKtRoWz8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769894398; c=relaxed/simple; bh=poj6PE5KMZ/ErBJ2AjpBgqaRlabIT4vEYCpL9olBjqE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RKiPOAi49juxnAy9LOGrhEDD6pa/wAyY3dOK4il/8dc/4sd/qjHOjWdzwwx2H2XX4uyEIleAxfhHSQnANOYA6/8Eoe2gtDyaHNmZz/VIVKMb6xkAYmy00pKhWJa1ldKivLSB5UAC8U3r7e1uYsrn2EBh4qC+Z9YuSPqVabhZxJg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=APXX6qzo; arc=none smtp.client-ip=209.85.210.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="APXX6qzo" Received: by mail-ot1-f53.google.com with SMTP id 46e09a7af769-7d122733808so1347738a34.2 for ; Sat, 31 Jan 2026 13:19:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1769894396; x=1770499196; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zv8qyk+XnBBQd5VL0I95A+dxGWu5ApGoL74XEX3UOy8=; b=APXX6qzovNmviYTxtn/VtlpSMMfUSV6UjWxzclGMT7XYtX2Kgrk+V24H7180M0M1yf JOYdkhHsbD3Qs1bmpHNSf91yWouklfWNPAZCqa1nu4OJ3eKLjW5d88d5k5T/w+l7RZhv R2ka8DS+iFjhH5n0wbvYb03BK+TMAb6WI1FtB084n6SrwUIUY4lWdd+sR+SRljvTNHNA tlzxF9PZehrhNcKRtfE/U7IjZSqax9/HHcAjVaebr0cMRVzPTTsOa3Oe2YZXWXsVccZD LQQOLGxuHjTkHDsokVMk1L/uiSL70Szb3Ww5KOLzePnJ87RxJA2jdpxpCIYQ07lzwsDH uYsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769894396; x=1770499196; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zv8qyk+XnBBQd5VL0I95A+dxGWu5ApGoL74XEX3UOy8=; b=JVAJgII/xbgLXmCRqLN5PpPegSfzlA4aHSooRAIcnS/FpUCGxmWy4XEsucO5tEUtzP dgzQx1PAggpKvXhFMCVXjLb8qez2cX0juIr1eojpDulebur+0FgaUA4NjR84dZljZLnc lERpnHYpifNTWXE82CPsw5ggkaBdIX+OgbsfwbqNxMq8Z+8a443ryTfZIFXoF35fLfmV 7gQsu4NFdHMWnhPRIrRzS48nlXtbBs/7b6+Nprlle+eNEK2GFkcZt2c625+RJZE/UzPi TEdEcRxVqzEUlXErEX5IsqG4eMrQVmJqflhoqu1CIvK0vaRzPtFWNdszyWOKzils5mtD xEzQ== X-Forwarded-Encrypted: i=1; AJvYcCUqEpPw8F8BPXC3CZOrbAifhoEyCxSjpwp5LBNL/HiFHmBdHTpTwdqGOxSdJ7bMd+cNBwxdWL5FEIF9V9o=@vger.kernel.org X-Gm-Message-State: AOJu0YwD0Amh1smFfAYdmuWRpHvwiWHsA+pXq0daRXyFdaoctvPvFbaJ 7SA1soBVRmXI1EhNWcR+1Eb+ix5ydyfCFQg/Kd8lcNxaW1DlBygeEjROBZo7j5UH3+k= X-Gm-Gg: AZuq6aKO/YuarfodD7lZVB9Z6tsT4uR9gwJs3ugRa8zH+knlztfL6OqSer3sLfjqdNk nZoG4oZWfAhfKkN6cVsmM5qnIbV6mk88wm4XdBUsIO/uxDjVY4arId4C6W7jqZS5Fc0jxpceIbB ZG/kBi+OEMGrLFBxhW6kA/KeQLhGN7e0t+/dXbzXV5MHn53a7JlRW/+KNeLTHF8hBYbNIPX5ItW sWX7brqekeeGzxw+pgh1FhaKONTy/11yHskaif5X+7YPkBWd5OjZT3GdH7TMKgsK/fLkxER6J0b vU8XCWa2q68SfgFciI7wdIactL/EiPdpywiHFyyOLQJ1lH8gTNF9MNnfoHgFVikTEZrhWvix8Y5 l41dsR3GOZHNTvWTnBxNeEc5GVu8IrMhUdZdp3lmMYItJqmAWqEONT8IFekDLKFdMfOoiWyQkYh Tg2hfEQ050maHYo9VJVtwU0w1rw3lI65UHlyQALizXjQxsyf0tVkvWywD7DkLz X-Received: by 2002:a05:6830:4984:b0:7d1:a028:4464 with SMTP id 46e09a7af769-7d1a534bf38mr3733443a34.36.1769894396196; Sat, 31 Jan 2026 13:19:56 -0800 (PST) Received: from ?IPV6:2600:8803:e7e4:500:c7ef:51f2:4f7a:6cd7? ([2600:8803:e7e4:500:c7ef:51f2:4f7a:6cd7]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7d18c6b9c8dsm8456703a34.13.2026.01.31.13.19.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 31 Jan 2026 13:19:55 -0800 (PST) Message-ID: <9504cab4-8881-4f38-bacf-a7a4f52c3f1b@baylibre.com> Date: Sat, 31 Jan 2026 15:19:55 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/6] iio: amplifiers: ad8366: consume enable gpio To: rodrigo.alencar@analog.com, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org Cc: Michael Hennerich , Lars-Peter Clausen , Jonathan Cameron , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley References: <20260126-iio-ad8366-update-v2-0-c9a4d31aeb01@analog.com> <20260126-iio-ad8366-update-v2-5-c9a4d31aeb01@analog.com> Content-Language: en-US From: David Lechner In-Reply-To: <20260126-iio-ad8366-update-v2-5-c9a4d31aeb01@analog.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/26/26 7:51 AM, Rodrigo Alencar via B4 Relay wrote: > From: Rodrigo Alencar > > Some parts may consume enable GPIO to enable serial mode > (HMC1119's and HMC792A P/S pin) or powerup the device > (e.g. ADA4961's PWUP pin). > > Co-developed-by: Michael Hennerich > Signed-off-by: Michael Hennerich > Signed-off-by: Rodrigo Alencar > --- > drivers/iio/amplifiers/ad8366.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/iio/amplifiers/ad8366.c b/drivers/iio/amplifiers/ad8366.c > index 134188db2e15..9ad6a628376c 100644 > --- a/drivers/iio/amplifiers/ad8366.c > +++ b/drivers/iio/amplifiers/ad8366.c > @@ -41,6 +41,7 @@ struct ad8366_state { > struct spi_device *spi; > struct mutex lock; /* protect sensor state */ > struct gpio_desc *reset_gpio; > + struct gpio_desc *enable_gpio; This isn't needed since it is never used outside of the probe function. It can be a local variable. > unsigned char ch[2]; > const struct ad8366_info *info; > /* > @@ -230,6 +231,11 @@ static int ad8366_probe(struct spi_device *spi) > return dev_err_probe(dev, PTR_ERR(st->reset_gpio), > "Failed to get reset GPIO\n"); > > + st->enable_gpio = devm_gpiod_get_optional(dev, "enable", GPIOD_OUT_HIGH); > + if (IS_ERR(st->enable_gpio)) > + return dev_err_probe(dev, PTR_ERR(st->enable_gpio), > + "Failed to get enable GPIO\n"); > + > indio_dev->name = spi_get_device_id(spi)->name; > indio_dev->info = &ad8366_info; > indio_dev->modes = INDIO_DIRECT_MODE; >