Re: [PATCH v3 2/2] arm64: renesas: add initial support for MYIR Remi Pi

[Julien Massot <julien.massot@collabora.com>]

Hi Geert, Krzysztof,

> On Fri, 31 Jan 2025 at 10:58, Julien Massot <julien.massot@collabora.com> wrote:
> > Add basic support for the MYIR Remi Pi (based on r9a07g044l2):
> >  - UART
> >  - i2c
> >  - emmc
> >  - USB host
> >  - HDMI output
> >  - Ethernet
> > 
> > Signed-off-by: Julien Massot <julien.massot@collabora.com>
> 
> Thanks for the update!
> 
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/renesas/r9a07g044l2-remi-pi.dts
> > @@ -0,0 +1,351 @@
> 
> > +/ {
> > +       model = "MYIR Tech Limited Remi Pi MYB-YG2LX-REMI";
> > +       compatible = "myir,remi-pi", "renesas,r9a07g044l2", "renesas,r9a07g044";
> > +
> > +       aliases {
> > +               ethernet0 = &eth0;
> > +               ethernet1 = &eth1;
> > +
> > +               i2c0 = &i2c0;
> > +               i2c1 = &i2c1;
> > +               i2c2 = &i2c2;
> > +               i2c3 = &i2c3;
> > +
> > +               mmc0 = &sdhi0;
> > +
> > +               serial0 = &scif0;
> > +               serial3 = &scif3;
> 
> Wasn't the plan to drop scif3, so it can be used by an RTOS running
> on the Cortex-A33 core?
Sorry, indeed I forgot scif3 removal. I don't see a reason to borrow the
Cortex-A33 scif.

> 
> > +               serial4 = &scif4;
> > +       };
> > +
> > +       chosen {
> > +               stdout-path = "serial0:115200n8";
> > +       };
> > +
> > +       memory@48000000 {
> > +               device_type = "memory";
> > +               /* first 128MB is reserved for secure area. */
> > +               reg = <0x0 0x48000000 0x0 0x38000000>;
> > +       };
> > +
> > +       reg_5p0v: regulator-5p0v {
> 
> > +       reg_3p3v: regulator-3p3v {
> 
> > +       reg_1p8v: regulator-1p8v {
> 
> > +       reg_1p1v: regulator-vdd-core {
> 
> > +       hdmi-out {
> 
> More sorting work to do...
> 
> Ok, I will keep in mind for the next time.
> 
> 
> > +};
> 
> > +       sdhi0_pins: sd0 {
> > +               sd0_data {
> > +                       pins = "SD0_DATA0", "SD0_DATA1", "SD0_DATA2", "SD0_DATA3",
> > +                              "SD0_DATA4", "SD0_DATA5", "SD0_DATA6", "SD0_DATA7";
> > +                       power-source = <1800>;
> > +               };
> > +
> > +               sd0_ctrl {
> 
> Here, too. Plus the underscores reported by Krzysztof.
Ok, no underscore in node names, even for the pins definition.

> 
> > +                       pins = "SD0_CLK", "SD0_CMD";
> > +                       power-source = <1800>;
> > +               };
> > +
> > +               sd0_rst {
> > +                       pins = "SD0_RST#";
> > +                       power-source = <1800>;
> > +               };
> > +       };
> 
> I fixed the style issues locally, so if you can confirm or deny the removal
> of scif3, I can fix that while applying.
Confirmed, we should not enable scif3.


Thanks
-- 
Julien