From: "Leeder, Neil" <nleeder@codeaurora.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Will Deacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Mark Langsdorf <mlangsdo@redhat.com>,
Mark Salter <msalter@redhat.com>, Jon Masters <jcm@redhat.com>,
Timur Tabi <timur@codeaurora.org>,
Mark Brown <broonie@kernel.org>,
nleeder@codeaurora.org
Subject: Re: [PATCH] perf: qcom_l2: fix column exclusion check
Date: Tue, 25 Jul 2017 15:43:54 -0400 [thread overview]
Message-ID: <95095f56-7b08-4ed9-f7e5-5d5768a75cc5@codeaurora.org> (raw)
In-Reply-To: <20170725170105.GF12749@leverpostej>
On 7/25/2017 1:01 PM, Mark Rutland wrote:
> On Mon, Jul 24, 2017 at 05:17:02PM -0400, Neil Leeder wrote:
>> The check for column exclusion did not verify that the event being
>> checked was an L2 event, and not a software event.
>> Software events should not be checked for column exclusion.
>> This resulted in a group with both software and L2 events sometimes
>> incorrectly rejecting the L2 event for column exclusion and
>> not counting it.
>>
>> Add a check for PMU type before applying column exclusion logic.
>>
>> Signed-off-by: Neil Leeder <nleeder@codeaurora.org>
>
> This looks correct, so:
>
> Acked-by: Mark Rutland <mark.rutland@arm.com>
>
> Should this have:
>
> Fixes: 21bdbb7102edeaeb ("perf: add qcom l2 cache perf events driver")
>
> ... ?
>
Thanks. I'll re-post with the Fixes tag.
Neil
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2017-07-25 19:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-24 21:17 Neil Leeder
2017-07-25 17:01 ` Mark Rutland
2017-07-25 19:43 ` Leeder, Neil [this message]
2017-07-26 8:27 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95095f56-7b08-4ed9-f7e5-5d5768a75cc5@codeaurora.org \
--to=nleeder@codeaurora.org \
--cc=broonie@kernel.org \
--cc=jcm@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mlangsdo@redhat.com \
--cc=msalter@redhat.com \
--cc=timur@codeaurora.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®