From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FA9726FA5E for ; Tue, 18 Feb 2025 17:22:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739899345; cv=none; b=JwbU5UcK6VsLvMBOWoGnG9S+QQlPL/uKcqS8PkMJj/AXmrFhFB252a9GNZ6eaVkLDU5gL09eFLHR7/ZRleK1zoWjIdI1DdXrrTXOIwnfMNvO6ZLN+J5rx3XEZ16wuB5gHeParrzEvXyB+IOaz1f0SAAYgP/penMRX1P8quMlzo8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739899345; c=relaxed/simple; bh=zNXWygFF5WwyY2RSj5lK41tUAkBXNcGkho6GIAFp9MA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Y9ptY7Pjz9Xc//diGsRChFAsvPmHcqhXscRlyBtLQDQGcR2tssvxzwoN3VvYxwrTY5ZyjBgkatADJz8hgQELP0BkDLbdLFCQpFIZTJ7m211bq4aVdwuwb8g8quoDCm6JOvDMAja8p7Au0DVoHDSo7g461ObyfI7OWWoZ9E7XOzk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=g0Gy5Udw; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="g0Gy5Udw" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739899342; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=HOkfCPqk5UIId4b15nkOwnQ9Epjg3ttPPXcm9pqlEiM=; b=g0Gy5UdwRT7wB0Vp6d0ceXjQsgeVTq30jWdFQEO5XOAHXHBhsRe8UjQKbuffUGihKyhs+J BxezJo5vmXTiFNr4LxzpC0/qTv2rpx2/sb/Uxo2LPtvMFEngYSv79pmQJcrr+VgCxcb3hB UDhK0/n/pvz9Y6HqTUZWZj6twy+oqvY= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-164-LxbMZhj3NIGZoDqmc5jRZQ-1; Tue, 18 Feb 2025 12:22:19 -0500 X-MC-Unique: LxbMZhj3NIGZoDqmc5jRZQ-1 X-Mimecast-MFC-AGG-ID: LxbMZhj3NIGZoDqmc5jRZQ_1739899335 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-38f2f438fb6so4834474f8f.1 for ; Tue, 18 Feb 2025 09:22:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739899335; x=1740504135; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=HOkfCPqk5UIId4b15nkOwnQ9Epjg3ttPPXcm9pqlEiM=; b=tDADZb7i1R4awzJvPl/rqq/uWnRarwkhKDu+KXXncKLA+BweId2H4x6scGr9z3lh4D tv9rFRbMrpcVSYojARzPWoxSZRFyvHwO3RWuFZZMhjljdaxcF0AlO1QZ0XRHwfXw+enh 4+NXsMQCsLD40WC317+DKqIR3tSxnsalKL0sESrw2HKqACCrqUpOpaNJJtNSdBmRb0G1 Dzhc+cznbfqsDCOC8PacVIDwIF+V1H1+rGHvxpNiTa8DaxGpVl3mpUn+XcTB3QnhgtbI uw/ym+smHu7uYcidN+O+YLud+liL7krBl6r4nE8cToHZL01/6Ov0YWTnux0MMYq5V9rs bXJw== X-Forwarded-Encrypted: i=1; AJvYcCWCb26r0PPMTBoOKQE1+r2mBW44E6WJIw6CP02uMz3zLm2gFEGrAipP/3zsGP2993KdfxYvveoVH/mEi4k=@vger.kernel.org X-Gm-Message-State: AOJu0YyXOmJ5sjMD/kYDnsBoMck7TnGCUgkX3wE2akF5FqGgwEDnvNDQ ZBkO1qDdMwFp3imf00mZ2sYl0MQDlphu8228QpmYj3FzXLw3cP7fkwZWfELtL9FFcBAWiMJd9cg Z05ik5ERBKffjqDz2Afk/S96/hdIf1QxFJQoKh66zWTr2PvORymZ1Ya2NZkh0tA== X-Gm-Gg: ASbGncum+XtJ+DwNNUaWS6eRMb0GHIhd/WQAVM93DjIB9yXYHd3qWAEoVtK0DaaO9ut wNAMBBP/2c/Ex/67rS/PaikT4+b/kZsX/iwoMZb9u7ZxxsrLKqUTLbKs90Kgw4SdgO+iqI4kiX9 NtMuBU9SMCEsZ6GID456/6WC4CDSTZ9z6gmkw6ztNv6GEbbiIOJ+57MUcAXkSLQsnieXDsZ8gue tqIdnFPPm/1AQdkXK0IqTbh3IWqtYmvje179HfXtBV6vCNAFO76A/v0PRBXnEQysc6MDSlp4G73 wae5RVctPaZbE5ztq1SRpOvVoHcRrrdlbsXzjsskS3mbtN7MWF+T5YB/ZGtDGDeF3wS01i8/uDU h7UijffJdX6ETe99uBZcKdxTkYOi9clur X-Received: by 2002:a5d:47c3:0:b0:38f:3c6c:28ff with SMTP id ffacd0b85a97d-38f3c6c2ce0mr11538844f8f.23.1739899335434; Tue, 18 Feb 2025 09:22:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IHjr0BuWvCU++Cx+Qo0SfQPUhHk8GBDbj83u/CGlwnXpvr46jVjrhMK5u2EO8raNUzQVPvHJg== X-Received: by 2002:a5d:47c3:0:b0:38f:3c6c:28ff with SMTP id ffacd0b85a97d-38f3c6c2ce0mr11538820f8f.23.1739899335092; Tue, 18 Feb 2025 09:22:15 -0800 (PST) Received: from ?IPV6:2003:cb:c70d:fb00:d3ed:5f44:1b2d:12af? (p200300cbc70dfb00d3ed5f441b2d12af.dip0.t-ipconnect.de. [2003:cb:c70d:fb00:d3ed:5f44:1b2d:12af]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38f258b439dsm15395861f8f.8.2025.02.18.09.22.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Feb 2025 09:22:13 -0800 (PST) Message-ID: <950cae5a-bff0-49e6-8fe4-a2447c63d8bc@redhat.com> Date: Tue, 18 Feb 2025 18:22:12 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V3] mm/hugetlb: wait for hugetlb folios to be freed To: Ge Yang , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, 21cnbao@gmail.com, baolin.wang@linux.alibaba.com, muchun.song@linux.dev, osalvador@suse.de, liuzixing@hygon.cn References: <1739878828-9960-1-git-send-email-yangge1116@126.com> <17ad5bf5-545c-4418-8d08-459ce6ef54cb@126.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <17ad5bf5-545c-4418-8d08-459ce6ef54cb@126.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 18.02.25 13:19, Ge Yang wrote: > > > 在 2025/2/18 19:45, David Hildenbrand 写道: >> On 18.02.25 12:40, yangge1116@126.com wrote: >>> From: Ge Yang >>> >>> Since the introduction of commit c77c0a8ac4c52 ("mm/hugetlb: defer >>> freeing >>> of huge pages if in non-task context"), which supports deferring the >>> freeing of hugetlb pages, the allocation of contiguous memory through >>> cma_alloc() may fail probabilistically. >>> >>> In the CMA allocation process, if it is found that the CMA area is >>> occupied >>> by in-use hugetlb folios, these in-use hugetlb folios need to be migrated >>> to another location. When there are no available hugetlb folios in the >>> free hugetlb pool during the migration of in-use hugetlb folios, new >>> folios >>> are allocated from the buddy system. A temporary state is set on the >>> newly >>> allocated folio. Upon completion of the hugetlb folio migration, the >>> temporary state is transferred from the new folios to the old folios. >>> Normally, when the old folios with the temporary state are freed, it is >>> directly released back to the buddy system. However, due to the deferred >>> freeing of hugetlb pages, the PageBuddy() check fails, ultimately leading >>> to the failure of cma_alloc(). >>> >>> Here is a simplified call trace illustrating the process: >>> cma_alloc() >>>      ->__alloc_contig_migrate_range() // Migrate in-use hugetlb folios >>>          ->unmap_and_move_huge_page() >>>              ->folio_putback_hugetlb() // Free old folios >>>      ->test_pages_isolated() >>>          ->__test_page_isolated_in_pageblock() >>>               ->PageBuddy(page) // Check if the page is in buddy >>> >>> To resolve this issue, we have implemented a function named >>> wait_for_freed_hugetlb_folios(). This function ensures that the hugetlb >>> folios are properly released back to the buddy system after their >>> migration >>> is completed. By invoking wait_for_freed_hugetlb_folios() before calling >>> PageBuddy(), we ensure that PageBuddy() will succeed. >>> >>> Fixes: c77c0a8ac4c52 ("mm/hugetlb: defer freeing of huge pages if in >>> non-task context") >>> Signed-off-by: Ge Yang >>> Cc: >> >> >> >> Acked-by: David Hildenbrand >>> +void wait_for_freed_hugetlb_folios(void) >>> +{ >>> +    flush_work(&free_hpage_work); >> >> BTW, I was wondering if we could optimize out some calls here by sensing >> if there is actually work. >> > for_each_hstate(h) { > if (hugetlb_vmemmap_optimizable(h)) { > flush_work(&free_hpage_work); > break;> } > } > Is this adjustment okay? I think that's better, except that it would still trigger in scenarios where hugetlb is completely unused if CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP is around. Can't we check hpage_freelist? if (llist_empty(&hpage_freelist)) return; flush_work(&free_hpage_work); It should be able to deal with races (we don't care if something is getting added concurrently, only if there is something right now). -- Cheers, David / dhildenb