From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.216.100 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793043253; b=IQ5GMMU6yX2jDq0vFDxLdiIf4vUSnWKa3dKLm39tev6kbJ7xs+nrL3pE/XRE36aGwoaP 8p+U4sI+ecLLDbAx9VcplGNBTD+rAR/3q/+ORf6bGQ6sFNu4GLSu7C5n0Z1ls2JfG8Grd uXLiJnpMOSqZiCiVpwYDl3Q3B1fBcklUdJFZpJ22nqLnqqfnR4qlPK81zuW+FqOG6hf6K lfNVUL65rqHlrkzg/w9LPoWWhLoAWOXb2GsiDfY1l9PqbMja82LASAtAsn+rRw4RpAElx FpuPT3Y8P4QMgQvucHszm6QZbEsQfbw9FpaU2xuAJ9iGAmg2iBDrYcBwYpfQ8FYrSMA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793043253; h=DMARC-Filter:Received:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:Received:X-Relaying-Domain: X-CFilter-Loop:Received:DKIM-Signature:X-Forwarded-Encrypted: X-Received:X-Received:Received:Message-ID:Date:MIME-Version: User-Agent:Subject:To:Cc:References:Content-Language:From:Autocrypt: In-Reply-To:Content-Type:Content-Transfer-Encoding: X-DetectorID-Processed; bh=HNU6ecoLDoNs5OZ6InUC4q5cc3Ja1sUxcVSSWoUZyrI=; b=Lmk0oPCnTYh6MIdyW5KSzE3lpI4LoAl4YytmLUl8Ti2DVNVLMxBbl9DesYAFa37U1rR8 MRdVAmfnIOI2lvOVte9YXvjBspS9Rlro51mPhwVFNndNYoLPx1RsTq8QcsdDmvcpiyNGw l2u6FEOs0cI489WwJiN5gVhF66D6h5epNDANounmDV9BKam1NeWaBbNrf5wmZolbdGblM WMWOc7TS52VkWNxbGMz4iZbEWCfQOQBJB8firp02WeA8depqzFxb3ofL2iSeLQtx/Ab15 UAYOQmyiFJ4Igxlu8dTcZhay62lUsmDONOagTnnk8ig+5d4dKLbwmN2grf7kEVJ+YSg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass header.d=broadcom.com header.i=@broadcom.com header.a=rsa-sha256 header.s=google header.b="Ir/uk0Gx"; arc=none smtp.remote-ip=209.85.216.100 Received: from mail-pj1-f100.google.com (mail-pj1-f100.google.com [209.85.216.100]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4BAE606A31A for ; Mon, 26 Oct 2026 19:34:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org D4BAE606A31A Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=broadcom.com header.i=@broadcom.com header.a=rsa-sha256 header.s=google header.b=Ir/uk0Gx Received: by mail-pj1-f100.google.com with SMTP id 98e67ed59e1d1-3aded3c6103so1063353a91.0 for ; Mon, 26 Oct 2026 12:34:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793043252; x=1793648052; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=HNU6ecoLDoNs5OZ6InUC4q5cc3Ja1sUxcVSSWoUZyrI=; b=Qcn+dTzUntKG58kTTdUecEJlSf6AlMB6+qqBBNB737J4L+8h8gKI8eRhiVzwfsILEW EfJ+1WLH9u675NOBiF+Qdyok2PXDtbHofhIEY7nF3VsGKWQ7t7d64p8AZcy1T1fJm5RN RwakW63t1/CB516IzRowlnJoVrpQDW14A9Dt6uTjqwJMEEB9dnNfzyiO8mCYidm/ziQO Is0WY0Mi+rz+6n7HiAqcuhkdyn+6AbjcE6SjJg/wESNM+5+b8eLvxFZNU/9D0F+HPiw2 cjX1jAAogUmvl2svPuaOgw8AjrVo7tVM+qahqJ4cx8CQoXOOQi0gc4t5eRLyfDyKdEfk R9bA== X-Forwarded-Encrypted: i=1; AKwUvBwRz0pnYMsQZHW9u9zFMaMsFjl1NW7gOK6jr71/IEA5Eb9LE0ixX1wUyir6468ZL34i4aZJ4M3WFSrHdvk=@vger.kernel.org X-Gm-Message-State: AFq9FYLTf1rwqu0L2hoFAzzAC6mgi7/iqlHefuORCwdwq9ejzG45LGSr NyvFp8YzbscDmUbu7oQRXxRLDIbRJokBeD5Kkxat8r1xgdlxbiQSFlwDKcphvm5rH0I3mIBVovk 9+xgtZb9ioinGnVp9PAwYaocqhUuH9AqYqO4oXQIfGAfM8Vn85ve8wXweBQuS8adgjceQCt38a7 EU3Rfpq8VvRM3cXWXyEU1swb+nU55pj3PBkeQYJWpPoDXoP6ueJLyLow+OlHviLA9zYQEIxcen1 YO8UJVQPib8L2Csvj28hCwKJQo= X-Gm-Gg: AYBFou2FmD5GF8ZRAk/3xnf0EHPDYKyieuSJJQX0pO5rTNE3cyTgikLZTk9RzFMGeAF DKcl7ZkF5pF9Np0dXnOjzQy1saqZpTHSdEqnp2PsmzXOf9K5JIwRG7WOFIPf+Dp8ofDmFnWSbXA su/+x8gWZWxH88IL9PvublSIB7IV7L23L1+3z2sf4GvHhujj432GDFwhnSjTC26VXOaVWZiS+49 jsrlWB+gHYCvBY1LOcxjmwS7C4C4jynifx2kaTsyoxainLgr+tHkOar+VZXokxXs9cOD8yvd58q dyTTGbDrcYI0tlO3gnbsGxtabTPJZYVRNEnbZ1TgrpIjfPP1pHae8KTmEH/b2c9Uy2bIHmqK2j4 K63gbSMa16Q6jncdH0NgvwNkevid+GzfGzkAoJvYzf1ZtjSTSquCK7naLMs1ACG8cFvsdE49vb3 jsDI7XUpCj47HntAFVPo2/eb9HXZ+YxbhUgY4OIG2+ X-Received: by 2002:a17:90b:1cc4:b0:3a8:195f:186 with SMTP id 98e67ed59e1d1-3adeb0f893fmr6055256a91.42.1793043251834; Mon, 26 Oct 2026 12:34:11 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-28.dlp.protect.broadcom.com. [144.49.247.28]) by smtp-relay.gmail.com with ESMTPS id 98e67ed59e1d1-3ae407e24c4sm341171a91.5.2026.10.26.12.34.11 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Oct 2026 12:34:11 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-dl1-f71.google.com with SMTP id a92af1059eb24-1665200f4c2so3958095c88.0 for ; Mon, 26 Oct 2026 12:34:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1793043250; x=1793648050; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=HNU6ecoLDoNs5OZ6InUC4q5cc3Ja1sUxcVSSWoUZyrI=; b=Ir/uk0GxG8T37f9eSr3mD9ZRkJi/bE5Xp/SwIx3VHTKSSz6A/CjDSnesUnGhaVVveX vUKGAQ6eZjQPOV5Gw/UES00H5i8tKY5uwrPIlGkKRspJPQB4MOWONneWTiqXWLD3jq94 IH/28UEmmM+Er0AEXyo5G2WqLihBJ5RPPB8ZI= X-Forwarded-Encrypted: i=1; AKwUvByKCRaAm2JCLBlzDmlGYX+i57xHBVI7Volcn6fpBpZzvYn86OS6hIWCFgfUkQnKuVdjQ1IrOQqAdWY3iXY=@vger.kernel.org X-Received: by 2002:a05:7022:2229:b0:144:fb87:5b91 with SMTP id a92af1059eb24-1993f202040mr16582447c88.44.1793043249780; Mon, 26 Oct 2026 12:34:09 -0700 (PDT) X-Received: by 2002:a05:7022:2229:b0:144:fb87:5b91 with SMTP id a92af1059eb24-1993f202040mr16582364c88.44.1793043248777; Mon, 26 Oct 2026 12:34:08 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-19894d59f90sm25726491c88.3.2026.10.26.12.34.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Oct 2026 12:34:07 -0700 (PDT) Message-ID: <9510382b-c726-41a9-8997-5779d991395e@broadcom.com> Date: Mon, 26 Oct 2026 12:34:05 -0700 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v2 2/2] net: dsa: b53: restore the NSP IMP port 2 Gbps mode To: Andrew Lunn Cc: Jonas Gorski , netdev@vger.kernel.org, Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Broadcom internal kernel review list , Arnd Bergmann , open list References: <20261022211104.2091128-1-florian.fainelli@broadcom.com> <20261022211104.2091128-3-florian.fainelli@broadcom.com> <47511aa5-3032-4bd1-bf8d-bcb1a2280367@broadcom.com> Content-Language: en-US, fr-FR From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 10/26/26 12:11, Andrew Lunn wrote: > On Mon, Oct 26, 2026 at 11:34:36AM -0700, Florian Fainelli wrote: >> On 10/26/26 11:31, Jonas Gorski wrote: >>> Hi, >>> >>> On Thu, Oct 22, 2026 at 11:11 PM Florian Fainelli >>> wrote: >>>> >>>> The Northstar Plus IMP port uses the switch's proprietary 2 Gbps mode for >>>> its internal link to the AMAC. Its fixed-link description reports 1 Gbps, >>>> so applying that speed clears PORT_OVERRIDE_SPEED_2000M and leaves the two >>>> ends of the internal link configured at different speeds. >>> >>> Sounds like the devicetrees are wrong. Shouldn't that fixed-link >>> description be updated to be 2 Gbps then? ;p >> >> That's a fair ask, however that would require introducing 2Gbits/sec all >> over the place, and it's not like we really have a good way to report that >> even through emulated PHY registers. This would not be a bug fix however, >> which this patch set is targeting. > > Hi Florian > > As far as i know phylink fixed-link does not care what the speed is, > and it does not try to emulate it in the PHY. So it probably just > works. Assuming the DSA driver is using phylink. Can we agree this is outside of the scope of what is being fixed here? Without updates to Device Tree binding, swphy, phylink and the drivers that do depend upon supporting SPEED_2000, that speed is going to be rejected or not acted on at various layers in the stack. -- Florian