From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
To: Corentin Labbe <clabbe.montjoie@gmail.com>, <robh+dt@kernel.org>,
<mark.rutland@arm.com>, <maxime.ripard@free-electrons.com>,
<wens@csie.org>, <linux@armlinux.org.uk>,
<catalin.marinas@arm.com>, <will.deacon@arm.com>,
<alexandre.torgue@st.com>,
Alexandre TORGUE <alexandre.torgue@st.com>
Cc: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<netdev@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 01/20] net: stmmac: export stmmac_set_mac_addr/stmmac_get_mac_addr
Date: Mon, 3 Apr 2017 14:39:03 +0200 [thread overview]
Message-ID: <9514c077-1738-ea49-ca18-fbc46bac6144@st.com> (raw)
In-Reply-To: <20170403091444.29876-2-clabbe.montjoie@gmail.com>
Hello Alex
do you can check if this has to be done for ST platforms?
I do not remember that it was necessary when build as module so
I cannot expect this should be only for dwmac-sun8i.
Regards
peppe
On 4/3/2017 11:14 AM, Corentin Labbe wrote:
> Thoses symbol will be needed for the dwmac-sun8i ethernet driver.
> For letting it to be build as module, they need to be exported.
>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> ---
> drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c b/drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c
> index 38f9430..67af0bd 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c
> @@ -248,6 +248,7 @@ void stmmac_set_mac_addr(void __iomem *ioaddr, u8 addr[6],
> data = (addr[3] << 24) | (addr[2] << 16) | (addr[1] << 8) | addr[0];
> writel(data, ioaddr + low);
> }
> +EXPORT_SYMBOL_GPL(stmmac_set_mac_addr);
>
> /* Enable disable MAC RX/TX */
> void stmmac_set_mac(void __iomem *ioaddr, bool enable)
> @@ -279,4 +280,4 @@ void stmmac_get_mac_addr(void __iomem *ioaddr, unsigned char *addr,
> addr[4] = hi_addr & 0xff;
> addr[5] = (hi_addr >> 8) & 0xff;
> }
> -
> +EXPORT_SYMBOL_GPL(stmmac_get_mac_addr);
next prev parent reply other threads:[~2017-04-03 12:39 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-03 9:14 [PATCH v3 00/20] net-next: stmmac: add dwmac-sun8i ethernet driver Corentin Labbe
2017-04-03 9:14 ` [PATCH v3 01/20] net: stmmac: export stmmac_set_mac_addr/stmmac_get_mac_addr Corentin Labbe
2017-04-03 12:39 ` Giuseppe CAVALLARO [this message]
2017-04-12 7:42 ` Corentin Labbe
2017-04-03 9:14 ` [PATCH v3 02/20] net: stmmac: add optional setup function Corentin Labbe
2017-04-03 12:32 ` Giuseppe CAVALLARO
2017-04-07 12:51 ` Corentin Labbe
2017-04-03 9:14 ` [PATCH v3 03/20] dt-bindings: net: Add DT bindings documentation for Allwinner dwmac-sun8i Corentin Labbe
2017-04-03 11:19 ` Maxime Ripard
2017-04-03 9:14 ` [PATCH v3 04/20] ARM: sun8i: dt: Add DT bindings documentation for Allwinner syscon Corentin Labbe
2017-04-03 11:19 ` Maxime Ripard
2017-04-07 12:50 ` Corentin Labbe
2017-04-03 9:14 ` [PATCH v3 05/20] net: stmmac: Add dwmac-sun8i Corentin Labbe
2017-04-03 9:14 ` [PATCH v3 06/20] ARM: dts: sunxi-h3-h5: Add dt node for the syscon control module Corentin Labbe
2017-04-03 9:14 ` [PATCH v3 07/20] ARM: dts: sunxi-h3-h5: add dwmac-sun8i ethernet driver Corentin Labbe
2017-04-03 9:14 ` [PATCH v3 08/20] ARM: dts: sun8i: Enable dwmac-sun8i on the Banana Pi M2+ Corentin Labbe
2017-04-03 9:14 ` [PATCH v3 09/20] ARM: dts: sun8i: Enable dwmac-sun8i on the Orange PI PC Corentin Labbe
2017-04-03 9:14 ` [PATCH v3 10/20] ARM: dts: sun8i: Enable dwmac-sun8i on the Orange Pi 2 Corentin Labbe
2017-04-03 9:14 ` [PATCH v3 11/20] ARM: dts: sun8i: Enable dwmac-sun8i on the Orange PI One Corentin Labbe
2017-04-03 9:14 ` [PATCH v3 12/20] ARM: dts: sun8i: Enable dwmac-sun8i on the Orange Pi plus Corentin Labbe
2017-04-03 11:37 ` Maxime Ripard
2017-04-03 9:14 ` [PATCH v3 13/20] ARM: dts: sun8i: orangepi-pc-plus: Set EMAC activity LEDs to active high Corentin Labbe
2017-04-03 9:14 ` [PATCH v3 14/20] ARM64: dts: sun50i-a64: Add dt node for the syscon control module Corentin Labbe
2017-04-03 9:14 ` [PATCH v3 15/20] ARM64: dts: sun50i-a64: add dwmac-sun8i Ethernet driver Corentin Labbe
2017-04-03 9:14 ` [PATCH v3 16/20] ARM: dts: sun50i-a64: enable dwmac-sun8i on pine64 Corentin Labbe
2017-04-03 11:38 ` Maxime Ripard
2017-04-07 12:48 ` Corentin Labbe
2017-04-03 9:14 ` [PATCH v3 17/20] ARM: dts: sun50i-a64: enable dwmac-sun8i on pine64 plus Corentin Labbe
2017-04-03 9:14 ` [PATCH v3 18/20] ARM: dts: sun50i-a64: enable dwmac-sun8i on the BananaPi M64 Corentin Labbe
2017-04-03 9:14 ` [PATCH v3 19/20] ARM: sunxi: Enable dwmac-sun8i driver on sunxi_defconfig Corentin Labbe
2017-04-03 9:14 ` [PATCH v3 20/20] ARM: sunxi: Enable dwmac-sun8i driver on multi_v7_defconfig Corentin Labbe
2017-04-03 11:39 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9514c077-1738-ea49-ca18-fbc46bac6144@st.com \
--to=peppe.cavallaro@st.com \
--cc=alexandre.torgue@st.com \
--cc=catalin.marinas@arm.com \
--cc=clabbe.montjoie@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®