From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>,
Marcelo Tosatti <mtosatti@redhat.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
mingo@redhat.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [patch 3/3] x86: kvm guest side support for KVM_HC_RT_PRIO hypercall
Date: Sat, 23 Sep 2017 12:56:12 +0200 [thread overview]
Message-ID: <951aaa3f-b20d-6f67-9454-f193f4445fc7@redhat.com> (raw)
In-Reply-To: <20170922125556.cyzybj6c7jqypbmo@hirez.programming.kicks-ass.net>
On 22/09/2017 14:55, Peter Zijlstra wrote:
> You just explained it yourself. If the thread that needs to complete
> what you're waiting on has lower priority, it will _never_ get to run if
> you're busy waiting on it.
>
> This is _trivial_.
>
> And even for !RT it can be quite costly, because you can end up having
> to burn your entire slot of CPU time before you run the other task.
>
> Userspace spinning is _bad_, do not do this.
This is not userspace spinning, it is guest spinning---which has
effectively the same effect but you cannot quite avoid.
But I agree that the solution is properly prioritizing threads that can
interrupt the VCPU, and using PI mutexes.
I'm not a priori opposed to paravirt scheduling primitives, but I am not
at all sure that it's required.
Paolo
> (the one exception where it works is where you have a single thread per
> cpu, because then there's effectively no scheduling).
next prev parent reply other threads:[~2017-09-23 10:56 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 11:38 [patch 0/3] KVM KVM_HC_RT_PRIO hypercall support Marcelo Tosatti
2017-09-21 11:38 ` [patch 1/3] KVM: x86: add per-vcpu option to set guest vcpu -RT priority Marcelo Tosatti
2017-09-21 11:38 ` [patch 2/3] KVM: x86: KVM_HC_RT_PRIO hypercall (host-side) Marcelo Tosatti
2017-09-21 13:32 ` Konrad Rzeszutek Wilk
2017-09-21 13:49 ` Paolo Bonzini
2017-09-22 1:08 ` Marcelo Tosatti
2017-09-22 7:23 ` Paolo Bonzini
2017-09-22 12:24 ` Marcelo Tosatti
2017-09-21 11:38 ` [patch 3/3] x86: kvm guest side support for KVM_HC_RT_PRIO hypercall Marcelo Tosatti
2017-09-21 13:36 ` Konrad Rzeszutek Wilk
2017-09-21 14:06 ` Peter Zijlstra
2017-09-22 1:10 ` Marcelo Tosatti
2017-09-22 10:00 ` Peter Zijlstra
2017-09-22 10:56 ` Peter Zijlstra
2017-09-22 12:33 ` Marcelo Tosatti
2017-09-22 12:55 ` Peter Zijlstra
2017-09-23 10:56 ` Paolo Bonzini [this message]
2017-09-23 13:41 ` Peter Zijlstra
2017-09-24 13:05 ` Paolo Bonzini
2017-09-25 2:57 ` Marcelo Tosatti
2017-09-25 9:13 ` Peter Zijlstra
2017-09-25 15:12 ` Paolo Bonzini
2017-09-26 22:49 ` [patch 3/3] x86: kvm guest side support for KVM_HC_RT_PRIO hypercall\ Marcelo Tosatti
2017-09-27 9:37 ` Paolo Bonzini
2017-09-28 0:44 ` Marcelo Tosatti
2017-09-28 7:22 ` Paolo Bonzini
2017-09-28 21:35 ` Marcelo Tosatti
2017-09-28 21:41 ` Marcelo Tosatti
2017-09-29 8:18 ` Paolo Bonzini
2017-09-29 16:40 ` Marcelo Tosatti
2017-09-29 17:05 ` Paolo Bonzini
2017-09-29 20:17 ` Marcelo Tosatti
2017-10-02 12:30 ` Paolo Bonzini
2017-10-02 12:48 ` Peter Zijlstra
2017-09-26 23:22 ` [patch 3/3] x86: kvm guest side support for KVM_HC_RT_PRIO hypercall Marcelo Tosatti
2017-09-25 16:20 ` Konrad Rzeszutek Wilk
2017-09-22 12:16 ` Marcelo Tosatti
2017-09-22 12:31 ` Peter Zijlstra
2017-09-22 12:36 ` Marcelo Tosatti
2017-09-22 12:59 ` Peter Zijlstra
2017-09-25 1:52 ` Marcelo Tosatti
2017-09-25 8:35 ` Peter Zijlstra
2017-09-22 12:40 ` [patch 3/3] x86: kvm guest side support for KVM_HC_RT_PRIO hypercall\ Marcelo Tosatti
2017-09-22 13:01 ` Peter Zijlstra
2017-09-25 2:22 ` Marcelo Tosatti
2017-09-25 8:58 ` Peter Zijlstra
2017-09-25 10:41 ` Thomas Gleixner
2017-09-25 18:28 ` Jan Kiszka
2017-09-21 17:45 ` [patch 0/3] KVM KVM_HC_RT_PRIO hypercall support Jan Kiszka
2017-09-22 1:19 ` Marcelo Tosatti
2017-09-22 6:23 ` Jan Kiszka
2017-09-26 23:59 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=951aaa3f-b20d-6f67-9454-f193f4445fc7@redhat.com \
--to=pbonzini@redhat.com \
--cc=konrad.wilk@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mtosatti@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®