From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S940312AbdEZLdV (ORCPT ); Fri, 26 May 2017 07:33:21 -0400 Received: from foss.arm.com ([217.140.101.70]:59520 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760232AbdEZLb5 (ORCPT ); Fri, 26 May 2017 07:31:57 -0400 Subject: Re: [PATCH V2] ARM: dts: rockchip:add sd card support for firefly reload board To: Eddie Cai , heiko@sntech.de, robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk Cc: linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org References: <1495782439-27142-1-git-send-email-eddie.cai.linux@gmail.com> From: Robin Murphy Message-ID: <951b3bad-eae7-f870-2bc1-8e230bfa4904@arm.com> Date: Fri, 26 May 2017 12:31:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <1495782439-27142-1-git-send-email-eddie.cai.linux@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/05/17 08:07, Eddie Cai wrote: > firefly reload board not support sd card yet. so support it. I'm confused... According to pictures and the schematic the microSD socket and vcc_sd supply are on the baseboard, not the core module, and these nodes already exist in rk3288-firefly-reload.dts :/ Robin. > Signed-off-by: Eddie Cai > Reviewed-by: Shawn Lin > --- > arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi | 31 +++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > > diff --git a/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi b/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi > index 413b61f..2f41209 100644 > --- a/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi > +++ b/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi > @@ -57,6 +57,17 @@ > clock-output-names = "ext_gmac"; > }; > > + vcc_sd: sdmmc-regulator { > + compatible = "regulator-fixed"; > + gpio = <&gpio7 RK_PB3 GPIO_ACTIVE_LOW>; > + pinctrl-names = "default"; > + pinctrl-0 = <&sdmmc_pwr>; > + regulator-name = "vcc_sd"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + startup-delay-us = <100000>; > + vin-supply = <&vcc_io>; > + }; > > vcc_flash: flash-regulator { > compatible = "regulator-fixed"; > @@ -281,6 +292,26 @@ > rockchip,pins = <4 8 RK_FUNC_GPIO &pcfg_output_high>; > }; > }; > + > + sdmmc { > + sdmmc_pwr: sdmmc-pwr { > + rockchip,pins = <7 11 RK_FUNC_GPIO &pcfg_pull_none>; > + }; > + }; > +}; > + > +&sdmmc { > + bus-width = <4>; > + cap-mmc-highspeed; > + cap-sd-highspeed; > + card-detect-delay = <200>; > + disable-wp; > + num-slots = <1>; > + pinctrl-names = "default"; > + pinctrl-0 = <&sdmmc_clk>, <&sdmmc_cmd>, <&sdmmc_cd>, <&sdmmc_bus4>; > + vmmc-supply = <&vcc_sd>; > + vqmmc-supply = <&vccio_sd>; > + status = "okay"; > }; > > &tsadc { >