From: Anna Maniscalco <anna.maniscalco2000@gmail.com>
To: Rob Clark <robin.clark@oss.qualcomm.com>,
dri-devel@lists.freedesktop.org
Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org,
Alexander Koskovich <akoskovich@pm.me>,
Dmitry Baryshkov <lumag@kernel.org>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Jessica Zhang <jesszhan0024@gmail.com>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 4/4] drm/msm: Inhibit IFPC for state snapshot
Date: Tue, 3 Nov 2026 14:27:37 +0100 [thread overview]
Message-ID: <951eab35-75d5-49b2-8f82-984aa4864c71@gmail.com> (raw)
In-Reply-To: <20261102190010.720443-5-robin.clark@oss.qualcomm.com>
On 11/2/26 8:00 PM, Rob Clark wrote:
> We need the GPU to stay awake for this.
>
> Tested-by: Alexander Koskovich <akoskovich@pm.me> # Milos (Nothing Phone 3a)
> Signed-off-by: Rob Clark <robin.clark@oss.qualcomm.com>
> ---
> drivers/gpu/drm/msm/msm_debugfs.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/msm/msm_debugfs.c b/drivers/gpu/drm/msm/msm_debugfs.c
> index aa59b28a3392..29209c23fcfa 100644
> --- a/drivers/gpu/drm/msm/msm_debugfs.c
> +++ b/drivers/gpu/drm/msm/msm_debugfs.c
> @@ -81,6 +81,8 @@ static int msm_gpu_open(struct inode *inode, struct file *file)
> return -ENOMEM;
>
> scoped_guard (pm_runtime_active, &gpu->pdev->dev) {
> + guard(ifpc_disable)(gpu);
> +
> scoped_cond_guard (mutex_intr, return -EINTR, &gpu->lock) {
> msm_gpu_hw_init(gpu);
> show_priv->state = gpu->funcs->gpu_state_get(gpu);
Reviewed-by: Anna Maniscalco <anna.maniscalco2000@gmail.com>
Best regards,
--
Anna Maniscalco <anna.maniscalco2000@gmail.com>
prev parent reply other threads:[~2026-11-03 13:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 19:00 [PATCH v2 0/4] drm/msm: Decouple IFPC disable and sysprof Rob Clark
2026-11-02 19:00 ` [PATCH v2 1/4] drm/msm: Rework IFPC disable Rob Clark
2026-11-03 11:24 ` Konrad Dybcio
2026-11-03 13:26 ` Anna Maniscalco
2026-11-02 19:00 ` [PATCH v2 2/4] drm/msm: Add cleanup help for disabling IFPC Rob Clark
2026-11-03 11:24 ` Konrad Dybcio
2026-11-03 13:27 ` Anna Maniscalco
2026-11-02 19:00 ` [PATCH v2 3/4] drm/msm/debugfs: Use cleanup.h for gpu state dump Rob Clark
2026-11-03 11:28 ` Konrad Dybcio
2026-11-03 13:58 ` Rob Clark
2026-11-03 14:24 ` Anna Maniscalco
2026-11-03 14:58 ` Rob Clark
2026-11-03 13:27 ` Anna Maniscalco
2026-11-02 19:00 ` [PATCH v2 4/4] drm/msm: Inhibit IFPC for state snapshot Rob Clark
2026-11-03 11:28 ` Konrad Dybcio
2026-11-03 13:27 ` Anna Maniscalco [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=951eab35-75d5-49b2-8f82-984aa4864c71@gmail.com \
--to=anna.maniscalco2000@gmail.com \
--cc=abhinav.kumar@linux.dev \
--cc=airlied@gmail.com \
--cc=akoskovich@pm.me \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jesszhan0024@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=robin.clark@oss.qualcomm.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®