From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C16883451B5 for ; Thu, 6 Nov 2025 15:11:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762441916; cv=none; b=CV3iQTB3/7fVDjx3LV3zHty34B/LRCmKLcK4cZHvUxpF1DD9+dETq6hTr36OGaEdqlNlpoK0Los9r6msODgt63WUr04N8B1AqF8P8qjyy+C2d7A6tDUWZ9tY0vyWf8E/kubZx6YnMUXdd88UVmM6jJq0MKcP6Szh84dPivE7eEM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762441916; c=relaxed/simple; bh=hAieD+WWGuTSffxpUcA1q/dR4SZs7rb61R1Dr5YIuDQ=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=KICmNTQB2sxDpIxuf7VjXNq+slQtGe1gSFF4BkJi6MMorTk05/DXXjNMaEPjDpTSyVOkX6DN/FI5xSwvjAEckoEkIXpV/Dj9KnOCybgZiyL746mi6fVPu+lqeyQCbsnrRq3Ig5bDIFNqBHbhCLEo4qWDglZE4ooyjC2R3XuYPyA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=PXkxbyWh; arc=none smtp.client-ip=209.85.208.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PXkxbyWh" Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-640bd9039fbso1832790a12.2 for ; Thu, 06 Nov 2025 07:11:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1762441913; x=1763046713; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=pr4I1+TpJGoh524IlcwOT6D1N8KANUmHgdXy9dFIgyI=; b=PXkxbyWheDzGXpFSxHx0NLUXMmrf6DnoSBG3msqPfLV0Y7dF1eIBp+j2Q26n/HMwJQ Uf0j1ykIZoWKj0D1UopoNF/K7E5SttimR3Tjo7yS9ktRQXf7WjZeN69QV4JGDIwAPNYV 4Pv1a+1kB8UMzG0FdCaOixci51/DVW3dNFZEW4QZoExa1ZDrnSVUC88G08QqUfjvTOvp NvUC+CMf/2PY4gcYwr8Xesqk7d07ge3aSx6L6bL5wRvVsdKw13AwNSTJ0uT3pKmEl+A4 vVUCJcyKidJeCpadMCwsRQO2As55hGmWh5CcG6XsplgBd+OrZVyCvkdJ9j2PjyhG+14n ehkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762441913; x=1763046713; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pr4I1+TpJGoh524IlcwOT6D1N8KANUmHgdXy9dFIgyI=; b=ty/C/61NYnvCxNlFJ08oAOxu9Dabw5DXwL/eKd9HC326MeTuh24T6nDj/+Jm5t1j/X PUjFoxpfKTf8RSvXzc0gsoy2j70UZQASSzjrUJ5np9wY/mZmX8aCM6t4pgGhDqWI+23A p2oeC//SQadX9I+LvbH9asKepX/GJyAo1w9VOs+w0wGjghEI6T8gcefbT3cZvYC8GHPW VdTckDsT2xlB/kmTRs39UdEr4inslY1WTmiOy9kTKa7EcxITzW/6Jv1ACQz+uRZA/QZv g6S1LjyWAOHxpuNl5I8levtzkyIQF6mqBHiVe0g7Qzo1VjTcqPQM74bSkDwh+RLaoSMt OprQ== X-Forwarded-Encrypted: i=1; AJvYcCWh4MDnCTfMbRn9NnFjiKG6uZ5mAEoRmJQCMEa4fbqI//4/jtQwtf6dmS821QHjH0IpvECk5Q9oC8Sggu4=@vger.kernel.org X-Gm-Message-State: AOJu0Yy9RY5HkEIlJ+whnJW3FHh9aK7pRNgwK/4YpkMspoRk6nnrMyPv YdyYFZzrs+IZGaOmWlUqs8m7XklqyFRlgCPEm4aGQohG2IgX5Mh4EA66kr5XASD0z0A= X-Gm-Gg: ASbGncv7xz51eYhkPEJ0zgBi73Dx2WlEXSbdcehoc7toCS4YAQ3mrlSSaG6JDPBZ8dz rU/RKeRBUHYcxhNMNuBA7hQZgXDhqUVjv1QRTlcxmoWQf8J+Pri2gonvCz+vu6ZueJAPB7IinPw wg7BYu4y2RjGILbk+AV+IISex1e+mwBPqJ0nm2PcFm55D3aCFcPky2ha02opcozt6pSn4lhm3K5 /hJrwc5IhlAfXLpamLaNgsSVggzcpXkIGdp3eUbRMBZiKPDG6ur6CcIn11QM5TIU4PuW5y9oQmU LoxhZMzWOM85HZBqNvHRcQdM/747NAMRFB4gTsVWF4nP8M23Fq8m7bKxOkMQNzoklMn9kK/o2Pq m9jXcA8Fu3r3Z2Rhj+pV56ktlJENxdeXK+DgXIuav+0e5jSP1oJ7aIctYe5MaqOjttf7NtmNzmp Ax9AhL2LoFgXIZ X-Google-Smtp-Source: AGHT+IHwC37XRyFfnN+/f5wSqrpQAP6dIioKEyvZ5pTh5YK+WFVy/VWvB0JDs0KxKTLiDxdgzCtNxQ== X-Received: by 2002:a05:6402:1d50:b0:640:c807:6af8 with SMTP id 4fb4d7f45d1cf-64105a582f8mr7170150a12.30.1762441912914; Thu, 06 Nov 2025 07:11:52 -0800 (PST) Received: from localhost ([87.213.113.147]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6411f8578ecsm2022840a12.19.2025.11.06.07.11.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Nov 2025 07:11:52 -0800 (PST) Date: Thu, 6 Nov 2025 18:11:50 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Bobby Eshleman , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Kuniyuki Iwashima , Willem de Bruijn , Neal Cardwell , David Ahern , Arnd Bergmann , Jonathan Corbet , Andrew Lunn , Shuah Khan , Mina Almasry Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, Stanislav Fomichev , Bobby Eshleman Subject: Re: [PATCH net-next v6 3/6] net: devmem: prepare for autorelease rx token management Message-ID: <95223e0d-e0a4-4bff-b3a8-babe7a8a093c@suswa.mountain> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251104-scratch-bobbyeshleman-devmem-tcp-token-upstream-v6-3-ea98cf4d40b3@meta.com> Hi Bobby, kernel test robot noticed the following build warnings: url: https://github.com/intel-lab-lkp/linux/commits/Bobby-Eshleman/net-devmem-rename-tx_vec-to-vec-in-dmabuf-binding/20251105-092703 base: 255d75ef029f33f75fcf5015052b7302486f7ad2 patch link: https://lore.kernel.org/r/20251104-scratch-bobbyeshleman-devmem-tcp-token-upstream-v6-3-ea98cf4d40b3%40meta.com patch subject: [PATCH net-next v6 3/6] net: devmem: prepare for autorelease rx token management config: openrisc-randconfig-r073-20251105 (https://download.01.org/0day-ci/archive/20251106/202511060119.MAzcsLoN-lkp@intel.com/config) compiler: or1k-linux-gcc (GCC) 10.5.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202511060119.MAzcsLoN-lkp@intel.com/ New smatch warnings: net/core/sock.c:1107 sock_devmem_dontneed_manual_release() error: uninitialized symbol 'ret'. vim +/ret +1107 net/core/sock.c 45aa39492cf4dd Bobby Eshleman 2025-11-04 1086 static noinline_for_stack int 45aa39492cf4dd Bobby Eshleman 2025-11-04 1087 sock_devmem_dontneed_manual_release(struct sock *sk, struct dmabuf_token *tokens, 45aa39492cf4dd Bobby Eshleman 2025-11-04 1088 unsigned int num_tokens) 45aa39492cf4dd Bobby Eshleman 2025-11-04 1089 { 45aa39492cf4dd Bobby Eshleman 2025-11-04 1090 struct net_iov *niov; 45aa39492cf4dd Bobby Eshleman 2025-11-04 1091 unsigned int i, j; 45aa39492cf4dd Bobby Eshleman 2025-11-04 1092 netmem_ref netmem; 45aa39492cf4dd Bobby Eshleman 2025-11-04 1093 unsigned int token; 45aa39492cf4dd Bobby Eshleman 2025-11-04 1094 int num_frags = 0; 45aa39492cf4dd Bobby Eshleman 2025-11-04 1095 int ret; ret needs to be = 0; 45aa39492cf4dd Bobby Eshleman 2025-11-04 1096 45aa39492cf4dd Bobby Eshleman 2025-11-04 1097 if (!sk->sk_devmem_info.binding) 45aa39492cf4dd Bobby Eshleman 2025-11-04 1098 return -EINVAL; 45aa39492cf4dd Bobby Eshleman 2025-11-04 1099 45aa39492cf4dd Bobby Eshleman 2025-11-04 1100 for (i = 0; i < num_tokens; i++) { 45aa39492cf4dd Bobby Eshleman 2025-11-04 1101 for (j = 0; j < tokens[i].token_count; j++) { 45aa39492cf4dd Bobby Eshleman 2025-11-04 1102 token = tokens[i].token_start + j; 45aa39492cf4dd Bobby Eshleman 2025-11-04 1103 if (token >= sk->sk_devmem_info.binding->dmabuf->size / PAGE_SIZE) 45aa39492cf4dd Bobby Eshleman 2025-11-04 1104 break; 45aa39492cf4dd Bobby Eshleman 2025-11-04 1105 45aa39492cf4dd Bobby Eshleman 2025-11-04 1106 if (++num_frags > MAX_DONTNEED_FRAGS) 45aa39492cf4dd Bobby Eshleman 2025-11-04 @1107 return ret; Uninitialized. It's always a good idea to test code with CONFIG_INIT_STACK_ALL_PATTERN. 45aa39492cf4dd Bobby Eshleman 2025-11-04 1108 45aa39492cf4dd Bobby Eshleman 2025-11-04 1109 niov = sk->sk_devmem_info.binding->vec[token]; 45aa39492cf4dd Bobby Eshleman 2025-11-04 1110 if (atomic_dec_and_test(&niov->uref)) { 45aa39492cf4dd Bobby Eshleman 2025-11-04 1111 netmem = net_iov_to_netmem(niov); 45aa39492cf4dd Bobby Eshleman 2025-11-04 1112 WARN_ON_ONCE(!napi_pp_put_page(netmem)); 45aa39492cf4dd Bobby Eshleman 2025-11-04 1113 } 45aa39492cf4dd Bobby Eshleman 2025-11-04 1114 ret++; Uninitialized. 45aa39492cf4dd Bobby Eshleman 2025-11-04 1115 } 45aa39492cf4dd Bobby Eshleman 2025-11-04 1116 } 45aa39492cf4dd Bobby Eshleman 2025-11-04 1117 45aa39492cf4dd Bobby Eshleman 2025-11-04 1118 atomic_sub(ret, &sk->sk_devmem_info.outstanding_urefs); 45aa39492cf4dd Bobby Eshleman 2025-11-04 1119 45aa39492cf4dd Bobby Eshleman 2025-11-04 1120 return ret; 45aa39492cf4dd Bobby Eshleman 2025-11-04 1121 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki