From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751365AbdKURsY (ORCPT ); Tue, 21 Nov 2017 12:48:24 -0500 Received: from mail-qt0-f193.google.com ([209.85.216.193]:38083 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751238AbdKURsW (ORCPT ); Tue, 21 Nov 2017 12:48:22 -0500 X-Google-Smtp-Source: AGs4zMZoe0NUV+u56lod+07wzb8b0ZVszN2B/dOoJbWeNrAN0QOhBydNIQLBNjifaYxYhUW6P68A3w== Subject: Re: [PATCH] net: phy: harmonize phy_id{,_mask} data type To: Richard Leitner , andrew@lunn.ch Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, richard.leitner@skidata.com References: <20171121095256.25507-1-dev@g0hl1n.net> From: Florian Fainelli Message-ID: <9525d5e5-a26e-79b8-dfc3-8f7d73250fd6@gmail.com> Date: Tue, 21 Nov 2017 09:48:17 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20171121095256.25507-1-dev@g0hl1n.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/21/2017 01:52 AM, Richard Leitner wrote: > From: Richard Leitner > > Previously phy_id was u32 and phy_id_mask was unsigned int. As the > phy_id_mask defines the important bits of the phy_id (and is therefore > the same size) these two variables should be the same data type. > > Signed-off-by: Richard Leitner Reviewed-by: Florian Fainelli Thanks! > --- > This patch is extracted from the "net: ethernet: fec: fix refclk enable for SMSC LAN8710/20" > patch series. This was done because this series will be reworked and > rebased on not yet merged feature later on. For more details see: > https://patchwork.ozlabs.org/cover/839468/ > --- > include/linux/phy.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/phy.h b/include/linux/phy.h > index dc82a07cb4fd..e00fd9ce3bce 100644 > --- a/include/linux/phy.h > +++ b/include/linux/phy.h > @@ -509,7 +509,7 @@ struct phy_driver { > struct mdio_driver_common mdiodrv; > u32 phy_id; > char *name; > - unsigned int phy_id_mask; > + u32 phy_id_mask; > u32 features; > u32 flags; > const void *driver_data; > -- Florian