From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f51.google.com (mail-oa1-f51.google.com [209.85.160.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3ADF9301719 for ; Fri, 12 Jun 2026 23:50:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781308209; cv=none; b=SasY5n5jPmMy7F49lpq1rZGTPz5u62w614e7M/leWQ0vuPxpTKNwxupPYOuFp/8tV3/9FIgR7ULMuj9fpPe6JEZN+BCY2skodHcS5X6c7gJRFV157FJQrrTtbvCqxkMtRZrv/1u1X/aUxPCshJ4aTvm/DowFnpSw/d3OYBYF0rk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781308209; c=relaxed/simple; bh=iUC5KuD8DUpRBxmH8q9YtdnfI/bOwVeYLr89NTEjfAw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gIi5YzOsgOYQ8KKnqS86DLcwgL49ElbSu0dvt4AIAXcEBWH/4AQ5wGSvxqBOQJPPKwgWIu5yiQPdcbdKlGl/5ZBnTUdu790Tm735lqITiGPQ0WJGuPgjbtZeu09SbOJjIF+O7phZHgKTB5v6tsrlzERuM/h7xJGUOcXxw8adH9o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=HPMsgtHd; arc=none smtp.client-ip=209.85.160.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="HPMsgtHd" Received: by mail-oa1-f51.google.com with SMTP id 586e51a60fabf-440dcd6406aso1155789fac.1 for ; Fri, 12 Jun 2026 16:50:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1781308205; x=1781913005; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=bYdl9jUW3MXBuDee60djhsxFixkF1o3CC0t5JyKpACQ=; b=HPMsgtHdOOREknh2zMO0uePPRofXpf7ClA9Cw3w3F75oGGdmCIvCtrfgJ8S7fTuiud ILEiZErYb7lf4LppQ6ChJVcZ8hFUUH/9s5t8E/ASYpAbJ/7W1RMa3iza9t75xn0JNpmN mNVuMeri4RlJfOzYice87OfFgOMZMvrRBFG4/LTm96q9PYJtZFsn/WoL1WIVb+LGQnxx fky4oTI3MCFlF84qHMaftmYZW+UsI9tBPqvgMIaqB9fXTA/2rrGrnXIF2J2I5mjqfNcr GWziwqdxze8cyT2gqj60xpWx+jQRwktie/UutVzzMq4ol9dQ8awd7uJqxm3uBWDoNbp9 tbwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781308205; x=1781913005; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bYdl9jUW3MXBuDee60djhsxFixkF1o3CC0t5JyKpACQ=; b=MjzojPJYhlHl41XIRNCkgipoJ61QrWgZIynVdKji8anlsAYwMWOS1DmgUCM04yeyKn j3Sq/gvjwKEW1OeZJQeil5ePHL2jU+yGAaFCfgNiqElmJQzsJy5LWtT5yj9TU2fVWksL Pl9Es+3SVshOuKkJBVax2v2MU23LWc8dHoi8rT3Yic+hgjCVzzU208/db3O6aUnxjzzU v+0pRmQ83Lx+jllq36IxnKsm/sodsCm7IGG0BM+PXb4EXwtJeHPEdqRFB3/Nt9o+6Lq7 lyJvLhXSdK+WF59MFlsCyhjU9kX3tHbaAvRyI8FcZoL7bkJWBgAsATRdbALSHqmS+7jw /Xgg== X-Forwarded-Encrypted: i=1; AFNElJ+/KpMoIPhVImL6pb1faw2em7rmpv9fXPzqPnwgMa+XeSky5Uxfvg0pqlz1NEEkTuB4Z+P9KQEIT/jDtrA=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2kpdG8xb2iksb1mt9jsnauzw6FnRSdZVCzfUnqQqd9hp03nGq sAPgxUjce1ZCMxKXsxRu+Ov8fCgKNR3G6jZxgFIqPcKdqJRmF58Zadbjv0WO9DChWCk= X-Gm-Gg: Acq92OEImgQmwnBP20a6AuwpQKHnHJP7FzQqH1dDmsRaIKS7M0DDGW2hU8vNpGOmmyr 5OWzOz3V5+N++dJipa2VXUhpWFwzzBnjz7BBgORznR/HUihNOMKg7WvQDmDF1tn9gfusO0g1tyE g1pIYvv5gP4BDyciT57i9CCkteHVXi1RB95bVwwLhW64uQy04lbmKj1s6/S//o/7mVlXCNNM3p8 gepuAQ+KO/vA87tDfoCK6lR8Eqi8UaVGYcdcOEUg+5Aa4jw5efykggY6EvCgvv4N76zIjr8DJQ3 uGY1BIcZdhaooBv6wNhN5fOd+UPyJf5dY1XOV4vMXk5Ei+P6HDHa27F8hf3OeQvOLBIBDWlMxq6 PsN26/ytaCn7GlVeT8dtNEQ7Sgld0HQFl1jNieQp6h1dejlq0hl0YbX8PPBmxVtMKjXZ5BrqXwY aQWb0b4VinkMRxLHBl6KotetbvFjP9l/3FkWHIwRCmRZZbJ8z5Lt441Xx7owHesxwJnh+EM8axf g== X-Received: by 2002:a05:6820:198a:b0:69e:97bf:4756 with SMTP id 006d021491bc7-69eec7b8f0dmr1138577eaf.7.1781308204992; Fri, 12 Jun 2026 16:50:04 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:cb9a:87cc:1314:fef5? ([2600:8803:e7e4:500:cb9a:87cc:1314:fef5]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-69ed8575597sm2680424eaf.12.2026.06.12.16.50.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Jun 2026 16:50:03 -0700 (PDT) Message-ID: <95291df3-c34b-40a4-ba73-813ccd4b9ef8@baylibre.com> Date: Fri, 12 Jun 2026 18:50:01 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/5] iio: adc: Add TI ADS126X ADC family support To: Kurt Borja , Jonathan Cameron , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Bartosz Golaszewski Cc: =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org References: <20260612-ads126x-v1-0-894c788d03ed@gmail.com> Content-Language: en-US From: David Lechner In-Reply-To: <20260612-ads126x-v1-0-894c788d03ed@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/12/26 5:46 PM, Kurt Borja wrote: > Hi all, > > This series introduces support for TI ADS1262 and ADS1263 ADCs [1]. > These devices are very similar (if not the same), except ADS1263 > includes a secondary auxiliary ADC. > > The main ADC has quite a few features supported the main driver > (ti-ads1262), including: > > - Power management > - IIO direct and buffer modes > - Channel hot-reloading > - Internal or external oscillator > - Internal or external voltage reference > - Filter configuration > - Sensor bias configuration > - IDAC configuration > - Level-shift voltage configuration > - Manual calibration support > - GPIO controller capabilities > > I plan to add these features to the main driver soon: > > - SPI offload support (38400 SPS turns out to be too high for some > systems) > - User triggered, automatic calibration (Datasheet 9.4.9) > > Additionally, full support for the (less capable) auxiliary ADC is > introduced by the auxiliary ti-ads1263-adc2 driver included in this > series. > > The auxiliary ADC operates almost completely independent of the main > ADC. The only consideration that has to be taken for interoperability is > when reading conversion data in direct mode (Datasheet 9.4.7.1), which > happens only in buffer mode, when multiple channels are enabled. > > When reading data in direct mode, all SPI activity is forbidden between > the data-ready signal and the data retrieval. To achieve this a second > mutex called xfer_lock was introduced to block SPI activity on the > device. > > This is one of the biggest drivers I've developed, so I hope the code > and the comments are self-explainatory. If not, please let me know so I > can clarify them. > > As always, thanks for your reviews and help. Submitting upstream is > always a great learning experience :) > > [1] https://www.ti.com/lit/ds/symlink/ads1263.pdf > > Signed-off-by: Kurt Borja > --- > Kurt Borja (5): > dt-bindings: iio: adc: Add TI ADS126x ADC family > iio: adc: Add ti-ads1262 driver > iio: adc: ti-ads1262: Add GPIO controller support > iio: adc: ti-ads1262: Add calibration support > iio: adc: Add ti-ads1263-adc2 driver > > .../devicetree/bindings/iio/adc/ti,ads1262.yaml | 308 +++ > .../bindings/iio/adc/ti,ads1263-adc2.yaml | 49 + > MAINTAINERS | 10 + > drivers/iio/adc/Kconfig | 26 + > drivers/iio/adc/Makefile | 2 + > drivers/iio/adc/ti-ads1262.c | 2180 ++++++++++++++++++++ > drivers/iio/adc/ti-ads1262.h | 39 + > drivers/iio/adc/ti-ads1263-adc2.c | 470 +++++ > 8 files changed, 3084 insertions(+) > --- > base-commit: ae696dfa47c30016cd429b9db5e70b259b8f509e > change-id: 20251129-ads126x-fb6107505cae > Hi Kurt, I'm currently working on the TI ADS112C14 family of chips which are functionally very similar (although have a bit of a different register map). I have some different ideas for the devicetree bindings that I think will make it a bit more flexible. Given how similar the chips are, I think we will want to align on how we do these (and there was one more similar, and thankfully much simpler, TI ADC driver submitted this week too!). So rather that looking at your stuff too closely yet, I will send what I have next week and we can compare notes then.