From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Xu Wang <vulab@iscas.ac.cn>, "axboe@kernel.dk" <axboe@kernel.dk>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] blk-zoned: Remove needless request_queue NULL pointer checks
Date: Fri, 10 Sep 2021 09:33:32 +0000 [thread overview]
Message-ID: <952d7945-e876-f86e-b4a4-2190c876b64b@nvidia.com> (raw)
In-Reply-To: <20210910064412.80446-1-vulab@iscas.ac.cn>
On 9/9/21 11:44 PM, Xu Wang wrote:
> External email: Use caution opening links or attachments
>
>
> The request_queue pointer returned from bdev_get_queue() shall
> never be NULL, so the NULL checks are unnecessary, just remove them.
>
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
> Changes since v2:
> - Make the q variable assignment together with declaration.
> ---
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
next prev parent reply other threads:[~2021-09-10 9:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 6:44 Xu Wang
2021-09-10 9:33 ` Chaitanya Kulkarni [this message]
2021-09-10 9:45 ` kernel test robot
2021-09-10 11:45 ` kernel test robot
2021-09-10 14:04 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=952d7945-e876-f86e-b4a4-2190c876b64b@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®