From: Joachim Vandersmissen <git@jvdsn.com>
To: Christoph Hellwig <hch@infradead.org>,
Eric Biggers <ebiggers@kernel.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
linux-crypto@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, dm-devel@lists.linux.dev
Subject: Re: [PATCH] crypto: testmgr - block Crypto API xxhash64 in FIPS mode
Date: Thu, 5 Mar 2026 01:19:34 -0600 [thread overview]
Message-ID: <952df8bf-0393-48a3-a844-e3acf13fd770@jvdsn.com> (raw)
In-Reply-To: <aagvBY-XMfPIqkDO@infradead.org>
Thanks for the discussion below, it sounds like I need to ensure
dm-integrity can use lib/crypto (at least for xxhash64) before blocking
it in the crypto API.
On 3/4/26 7:09 AM, Christoph Hellwig wrote:
> On Tue, Mar 03, 2026 at 11:31:02AM -0800, Eric Biggers wrote:
>>> It sounds like xxhash should be removed the crypto API entirely.
>>> There's no user of it, it's not crypto, and doing xxhash through
>>> the userspace crypto API socket is so stupid that I doubt anyone
>>> attempted it.
>> dm-integrity, which uses crypto_shash and accepts arbitrary hash
>> algorithm strings from userspace, might be relying on "xxhash64" being
>> supported in crypto_shash. The integritysetup man page specifically
>> mentions xxhash64:
> Oh, ok. So at least for now we need it, although it would be nice to
> convert dm-integrity to lib/crypto/ and limit it to the advertised
> algorithms (including xxhash).
>
>
next prev parent reply other threads:[~2026-03-05 7:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 6:05 Joachim Vandersmissen
2026-03-03 15:09 ` Christoph Hellwig
2026-03-03 19:31 ` Eric Biggers
2026-03-04 9:55 ` Milan Broz
2026-03-04 13:09 ` Christoph Hellwig
2026-03-05 7:19 ` Joachim Vandersmissen [this message]
2026-03-14 5:11 ` Herbert Xu
2026-03-15 0:43 ` Joachim Vandersmissen
2026-03-15 4:32 ` Herbert Xu
2026-09-09 14:36 ` Thomas Huth
2026-09-10 3:24 ` Joachim Vandersmissen
2026-09-10 8:57 ` Thomas Huth
2026-09-10 14:14 ` Eric Biggers
2026-09-11 2:53 ` Joachim Vandersmissen
2026-10-02 11:06 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=952df8bf-0393-48a3-a844-e3acf13fd770@jvdsn.com \
--to=git@jvdsn.com \
--cc=alexandre.torgue@foss.st.com \
--cc=davem@davemloft.net \
--cc=dm-devel@lists.linux.dev \
--cc=ebiggers@kernel.org \
--cc=hch@infradead.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®