From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta1.migadu.com (out-173.mta1.migadu.com [95.215.58.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8B033E16A8 for ; Thu, 10 Sep 2026 09:43:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789033419; cv=none; b=XeQegUBKywJg3dh4fAEpqJZdLUTe9K6FaeXqhCJgVV1T+ZxtFeIZV0naMtViJvSTRq9PQZOTcNyHiXW5Ps1R0xZuPgBQdT30E4OdUN4yrSiOBP1cmjMR685WOlD9IdjnCE+NCBD/ZIOWnlttBcheWbpg3ku+qxS4NZrJeRsbBkk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789033419; c=relaxed/simple; bh=KnS4FREeAKzpHL8fFTZa5rjNeAMn6U9PigOahw3tm9s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eL4mMIo+vwVgfwkLBCEtMe3OAuL3HUMkKiYKzZ387mdTpPbOFvGHhqLoi38X6GZ457qdc6E+f2NEzVrmNWNoGaXU7lTpojrRcAwjyKMOQy2TRM/1cJBorYscnPTLA/rl6Hu7BuH+GgB2DbuiAXZ7czK+ujTkRFf2ls4lrHVMuMw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=SI6PwCXk; arc=none smtp.client-ip=95.215.58.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="SI6PwCXk" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=KnS4FREeAKzpHL8fFTZa5rjNeAMn6U9PigOahw3tm9s=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1789033407; v=1; x=1789638207; b=SI6PwCXkC1akEW66K7nj/nSDItlzqc/zNXEBhaycSP6a5qG1RSmqteUxDI4BzptTdAj310Zl gLU7iseREFdm69afWBD432Qv1s4FxbZWMzIN+OwYUw7pGiYXAoWyl1W5rTRx47K7kwGoTNLcM6b eS28VOij3fD9lBCqdHtM8Wmc= X-Envelope-To: linux-kernel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id f283204ef0f696d7; Thu, 10 Sep 2026 09:43:27 +0000 X-Mizu-Trace-ID: f283204ef0f696d7 X-Migadu-Flow: FLOW_OUT Message-ID: <95330c25-d5ed-4e5d-8f62-528df543f8f3@linux.dev> Date: Thu, 10 Sep 2026 17:43:19 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH nf] net/sched: act_ct: set net pointer before publishing flowtable To: Qingfang Deng Cc: netfilter-devel@vger.kernel.org, Jamal Hadi Salim , Jiri Pirko , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Oz Shlomo , Vlad Buslov , Pablo Neira Ayuso , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260909075606.1508155-1-qingfang.deng@linux.dev> <94103430-c2e8-491d-880c-c4690c5e3f98@linux.dev> From: Xuanqiang Luo In-Reply-To: <94103430-c2e8-491d-880c-c4690c5e3f98@linux.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/10/26 5:03 PM, Qingfang Deng wrote: > Hi, > > On 2026/9/10 14:09, Xuanqiang Luo wrote: >>> nf_flow_table_init() adds the flowtable to the global flowtables list. >>> However, tcf_ct_flow_table_get() sets the table's network namespace >>> only >>> after that call, leaving a window where the published table has a NULL >>> namespace pointer. >> >> The window does exist, but can any existing code path actually read >> flowtable->net during this window? Could you also describe that path >> in the commit message? > > There's none. The patch is a preparation for: > https://lore.kernel.org/netfilter-devel/20260909081705.1512600-1-qingfang.deng@linux.dev/ > > Thanks for clarifying. Reviewed-by: Xuanqiang Luo Thanks, Xuanqiang