From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08B40C4332F for ; Fri, 2 Dec 2022 18:39:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233357AbiLBSjz (ORCPT ); Fri, 2 Dec 2022 13:39:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46008 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233877AbiLBSjD (ORCPT ); Fri, 2 Dec 2022 13:39:03 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C531EED69A for ; Fri, 2 Dec 2022 10:37:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670006249; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZRCCAO836Dkk36/ISmrsSydPeXHNO72rUKzm2SjpIeo=; b=ct6cx4aHmh55hmcuAhojeFZzUGOjrw/Y5i97dnMtrqnFgSLeRiGn3cweYnVtND/Hw9fWnp XDAFmBAhI596zrGHR2gnBmKoVeiuQgMpdpLe/MdgAj51R/jClJsRSb3FJTRCHKOfvL+FWx 4VqQNqlciXRbLreY5VyKiYga8aDlLjM= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-407-SrThCbDRPsWW-sUYDr6_Vw-1; Fri, 02 Dec 2022 13:37:27 -0500 X-MC-Unique: SrThCbDRPsWW-sUYDr6_Vw-1 Received: by mail-wm1-f72.google.com with SMTP id bi19-20020a05600c3d9300b003cf9d6c4016so4501053wmb.8 for ; Fri, 02 Dec 2022 10:37:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZRCCAO836Dkk36/ISmrsSydPeXHNO72rUKzm2SjpIeo=; b=VfoT2TjRebICLun8Szm6b1eNoGk5FZTWk6lRiIcer41iC3l+PxsWG8ZYufCmojmt0R g7pu0Le8FhOxe2/ihz1y9EaWx1EWOn+soMflgWi+YOCRUU2S3t0wnJcNGrE6tBlqCrlS 5Om4A50OMs9/Q6qvcn4cH8YFhmAnS3VbfHmvyozI60MpcOcpgaIf4C4PLJOP+cxSi9fI fdX/mI5v2UiWherT5/DZh2a00dc5zevaspV/NOWRAhjdAcOumqPbwUGvgfaO8wCFA3ch 3Ud3STcCL3eLwwpuWfV3ejR+uP+T3yw/tpzWQXkBIrdBw4rKKjWDmLf+XIItdgAzboLo diLw== X-Gm-Message-State: ANoB5pkuPV3suEo8MiViwv8olKfXIERe1zZ7z6QxXb98ZkkWS8LbzuA4 FW44fxJBO6aU0zrJ6g7B38inC7Va7JxoLAK1dNkXA1YJcPtWSW6/jFagXuQ+hA83jnjEH/IMvCc ZNL/l5Buv+YtsazHdAgAqR7Yl X-Received: by 2002:a5d:65c9:0:b0:241:bd29:6a73 with SMTP id e9-20020a5d65c9000000b00241bd296a73mr43031888wrw.499.1670006246603; Fri, 02 Dec 2022 10:37:26 -0800 (PST) X-Google-Smtp-Source: AA0mqf5bDxlHPeOMTNDdfeXqolK1EsQa6JCzP6RbCTWC2p3Ob+s87IOgv7n0zbGEsBosGljKzxlI0A== X-Received: by 2002:a5d:65c9:0:b0:241:bd29:6a73 with SMTP id e9-20020a5d65c9000000b00241bd296a73mr43031885wrw.499.1670006246340; Fri, 02 Dec 2022 10:37:26 -0800 (PST) Received: from ?IPV6:2001:b07:6468:f312:9af8:e5f5:7516:fa89? ([2001:b07:6468:f312:9af8:e5f5:7516:fa89]) by smtp.googlemail.com with ESMTPSA id z2-20020a5d4402000000b00226dba960b4sm7559791wrq.3.2022.12.02.10.37.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Dec 2022 10:37:25 -0800 (PST) Message-ID: <95374a64-47fc-ae25-d54e-8200671acacc@redhat.com> Date: Fri, 2 Dec 2022 19:37:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 00/14] KVM: x86: Remove unnecessary exported symbols Content-Language: en-US To: Like Xu , Sean Christopherson Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221114095606.39785-1-likexu@tencent.com> From: Paolo Bonzini In-Reply-To: <20221114095606.39785-1-likexu@tencent.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/14/22 10:55, Like Xu wrote: > Inspired by the Sean's minor fix [1], more unnecessary (from a GPL > developer's perspective) exported symbols could be cleaned up > (automation to find out true positives is possible). This move helps reduce > the attack surface of KVM modules and guides more developers to practice > the principle of low coupling in the KVM context. > > [1] https://lore.kernel.org/kvm/20221110010354.1342128-1-seanjc@google.com/ I'll squash everything in a single patch and limit the change to just removing EXPORT_SYMBOL_GPL(). Paolo > Like Xu (13): > KVM: x86: Remove unnecessary export of kvm_inject_pending_timer_irqs() > KVM: x86: Remove unnecessary export of kvm_get_apic_base() > KVM: x86: Remove unnecessary export of kvm_set_apic_base() > KVM: x86: Remove unnecessary export of kvm_inject_page_fault() > KVM: x86: Remove unnecessary export of kvm_inject_nmi() > KVM: x86: Remove unnecessary export of kvm_require_cpl() > KVM: x86: Remove unnecessary export of kvm_emulate_as_nop() > KVM: x86: Remove unnecessary export of kvm_scale_tsc() > KVM: x86: Remove unnecessary export of kvm_vcpu_is_reset_bsp() > KVM: x86: Remove unnecessary export of kvm_hv_assist_page_enabled() > KVM: x86: Remove unnecessary export of kvm_can_use_hv_timer() > KVM: x86: Remove unnecessary export of kvm_lapic_hv_timer_in_use() > KVM: x86: Remove unnecessary export of kvm_apic_update_apicv() > > Sean Christopherson (1): > KVM: x86: Remove unnecessary export of kvm_cpu_has_pending_timer() > > arch/x86/kvm/hyperv.c | 1 - > arch/x86/kvm/irq.c | 2 -- > arch/x86/kvm/lapic.c | 3 --- > arch/x86/kvm/x86.c | 18 +++++------------- > arch/x86/kvm/x86.h | 2 ++ > 5 files changed, 7 insertions(+), 19 deletions(-) >