From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2468EEB570 for ; Fri, 8 Sep 2023 20:45:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232971AbjIHUpz (ORCPT ); Fri, 8 Sep 2023 16:45:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53364 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229755AbjIHUpy (ORCPT ); Fri, 8 Sep 2023 16:45:54 -0400 Received: from mx0.riseup.net (mx0.riseup.net [198.252.153.6]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B84F8E for ; Fri, 8 Sep 2023 13:45:49 -0700 (PDT) Received: from fews01-sea.riseup.net (fews01-sea-pn.riseup.net [10.0.1.109]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx0.riseup.net (Postfix) with ESMTPS id 4Rj7Rc3Ch0z9t74; Fri, 8 Sep 2023 20:45:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1694205948; bh=h1TWJdGJ9ASx08PyZZIFjCeXM50aEyi5tVxjQAo3lGI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ELCqhZrkXLfDwUcMLzlzeWlU0aaN2zvpp9Ac7LBWk7STYDWMmAcByZ5PqQ4v7RSA8 im1/5hLJdn5iVfN6xcVO73KQUN7vHIVD6lzuSOYGbbuoMopoX+n6u1kSB3dI20RfIA 5LGH9OOUSsRvz8761ndiNd4U2Jwm9IJTN2yd19DU= X-Riseup-User-ID: 76C808A5AD22C7481D8113EBDB2523E94D0004C5ADD5B03B1E1896DD3A06C1C7 Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews01-sea.riseup.net (Postfix) with ESMTPSA id 4Rj7RX4zYMzJnCB; Fri, 8 Sep 2023 20:45:44 +0000 (UTC) Message-ID: <95380f26-a772-3723-5715-e5c4f2d6d1cc@riseup.net> Date: Fri, 8 Sep 2023 17:45:46 -0300 MIME-Version: 1.0 Subject: Re: [PATCH] drm/debugfs: Add inline to drm_debugfs_dev_init() to suppres -Wunused-function Content-Language: en-US To: Arthur Grillo , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: tales.aparecida@gmail.com, andrealmeid@riseup.net, Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Andi Shyti , kernel test robot References: <20230901-debugfs-fix-unused-function-warning-v1-1-161dd0902975@riseup.net> From: Maira Canal In-Reply-To: <20230901-debugfs-fix-unused-function-warning-v1-1-161dd0902975@riseup.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arthur, On 9/1/23 15:05, Arthur Grillo wrote: > When CONFIG_DEBUG_FS is not set -Wunused-function warnings appear, > make the static function inline to suppress that. > > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202309012114.T8Vlfaf8-lkp@intel.com/ > Closes: https://lore.kernel.org/oe-kbuild-all/202309012131.FeakBzEj-lkp@intel.com/ > Signed-off-by: Arthur Grillo Applied to drm-misc/drm-misc-next! Thanks! - Maíra > --- > include/drm/drm_drv.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h > index 9850fe73b739..e2640dc64e08 100644 > --- a/include/drm/drm_drv.h > +++ b/include/drm/drm_drv.h > @@ -584,7 +584,7 @@ static inline bool drm_firmware_drivers_only(void) > #if defined(CONFIG_DEBUG_FS) > void drm_debugfs_dev_init(struct drm_device *dev, struct dentry *root); > #else > -static void drm_debugfs_dev_init(struct drm_device *dev, struct dentry *root) > +static inline void drm_debugfs_dev_init(struct drm_device *dev, struct dentry *root) > { > } > #endif > > --- > base-commit: 8e455145d8f163aefa6b9cc29478e0a9f82276e6 > change-id: 20230901-debugfs-fix-unused-function-warning-9ebbecbd6a5a > > Best regards,