From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Kees Cook <keescook@chromium.org>, David Howells <dhowells@redhat.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
Eric Biggers <ebiggers@kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>,
Salvatore Bonaccorso <carnil@debian.org>,
keyrings@vger.kernel.org, Adam Langley <agl@google.com>,
Lee Jones <lee.jones@linaro.org>,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH v2] sign-file: Convert API usage to support OpenSSL v3
Date: Thu, 19 May 2022 11:21:32 -0400 [thread overview]
Message-ID: <953c45678dc4b59e9e5de0e5c228e2e8a8ac558a.camel@HansenPartnership.com> (raw)
In-Reply-To: <20220518215129.264872-1-keescook@chromium.org>
On Wed, 2022-05-18 at 14:51 -0700, Kees Cook wrote:
> OpenSSL's ENGINE API is deprecated in OpenSSL v3.0, along with some
> other functions. Remove the ENGINE use and a macro work-around for
> ERR_get_error_line().
What answer was there to Eric Biggers' concern about token support in
sign-file?
https://lore.kernel.org/lkml/YVyKc51r2tfMmQuO@gmail.com/
If you're not doing ephemeral keys (as quite a few kernel builder's
aren't) you really need a token to protect the signing key.
The other point was that openssl3 hasn't converted most of its own
engine code to the provider API, so the deprecation is a bit premature
because it will be a while before provider based token libraries
appear. If the goal is simply to not see the warnings, the compile
flag you need is
-DOPENSSL_API_COMPAT=0x10100000L
James
prev parent reply other threads:[~2022-05-19 15:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 21:51 Kees Cook
2022-05-18 21:58 ` Kees Cook
2022-05-18 22:59 ` Shuah Khan
2022-05-19 6:45 ` Salvatore Bonaccorso
2022-05-19 15:21 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=953c45678dc4b59e9e5de0e5c228e2e8a8ac558a.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=agl@google.com \
--cc=carnil@debian.org \
--cc=dhowells@redhat.com \
--cc=dwmw2@infradead.org \
--cc=ebiggers@kernel.org \
--cc=keescook@chromium.org \
--cc=keyrings@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®