From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752123AbeADGJD (ORCPT + 1 other); Thu, 4 Jan 2018 01:09:03 -0500 Received: from fllnx209.ext.ti.com ([198.47.19.16]:48077 "EHLO fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751398AbeADGJB (ORCPT ); Thu, 4 Jan 2018 01:09:01 -0500 Subject: Re: [PATCH v2 1/2] PCI: dra7xx: Fix legacy INTD IRQ handling To: Vignesh R , Lorenzo Pieralisi References: <20171229114131.22296-1-vigneshr@ti.com> <20171229114131.22296-2-vigneshr@ti.com> CC: Bjorn Helgaas , , , From: Kishon Vijay Abraham I Message-ID: <953c7aac-0429-8fc7-02ce-ace94aa735f3@ti.com> Date: Thu, 4 Jan 2018 11:38:53 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20171229114131.22296-2-vigneshr@ti.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Friday 29 December 2017 05:11 PM, Vignesh R wrote: > Legacy INTD IRQ handling is broken on dra7xx due to fact that driver > uses hwirq in range of 1-4 for INTA, INTD whereas IRQ domain is of size > 4 which is numbered 0-3. Therefore when INTD IRQ line is used with > pci-dra7xx driver following warning is seen: > > WARNING: CPU: 0 PID: 1 at kernel/irq/irqdomain.c:342 irq_domain_associate+0x12c/0x1c4 > error: hwirq 0x4 is too large for dummy > > Fix this by using pci_irqd_intx_xlate() helper to translate the INTx 1-4 > range into the 0-3 as done in other PCIe drivers. > > Suggested-by: Bjorn Helgaas > Reported-by: Chris Welch > Signed-off-by: Vignesh R Acked-by: Kishon Vijay Abraham I > --- > drivers/pci/dwc/pci-dra7xx.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c > index 58aed0896468..892f93910012 100644 > --- a/drivers/pci/dwc/pci-dra7xx.c > +++ b/drivers/pci/dwc/pci-dra7xx.c > @@ -226,6 +226,7 @@ static int dra7xx_pcie_intx_map(struct irq_domain *domain, unsigned int irq, > > static const struct irq_domain_ops intx_domain_ops = { > .map = dra7xx_pcie_intx_map, > + .xlate = pci_irqd_intx_xlate, > }; > > static int dra7xx_pcie_init_irq_domain(struct pcie_port *pp) > @@ -269,7 +270,7 @@ static irqreturn_t dra7xx_pcie_msi_irq_handler(int irq, void *arg) > case INTC: > case INTD: > generic_handle_irq(irq_find_mapping(dra7xx->irq_domain, > - ffs(reg))); > + ffs(reg) - 1)); > break; > } > >