From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37E2EC678D5 for ; Tue, 10 Jan 2023 15:10:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238427AbjAJPKV (ORCPT ); Tue, 10 Jan 2023 10:10:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238920AbjAJPJW (ORCPT ); Tue, 10 Jan 2023 10:09:22 -0500 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00E1C5BA1F; Tue, 10 Jan 2023 07:09:04 -0800 (PST) Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30AEusAW025378; Tue, 10 Jan 2023 15:09:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=FlBkg/a003hZIrFKGytGuevH+hsa3QYaD+3dG7LC/dE=; b=Fx/vaodiWJjT7luj2MBmS8x0/NaBlwhj+P8y8+0pI07Qa2+D9y15gZJeyJO3fSo7v3S8 eMHTfHMWA7Aq27yrYlFmMCmxuGHu2Kcxy2E6hjVi9WGqmGLEC3I91dqnbNuROYbeYmFy QYeNjLRvqezaxO6Hg/enTPazh9DxkAh6WVByLPQbDWpo9lPycVRP7GPYNVACWpo1tPxg //vogedMCrHOqEYD2vWWPZ6wKselbkkdJ7tZ4mnEVM+4+TXn0U+RwhWxr1OwzViVV0Tp 6Oei86QThatBhbvE9Xsbcg1yDGRJYhEbVkh9sXlndm+3pt3fc/zT75e64HOTZAb2Ja/P UA== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3n0x0jhghu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 10 Jan 2023 15:09:00 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 30AF8xSx020780 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 10 Jan 2023 15:08:59 GMT Received: from [10.50.61.82] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Tue, 10 Jan 2023 07:08:56 -0800 Message-ID: <9545ca51-ccda-64f0-bdd4-3b53e06785ad@quicinc.com> Date: Tue, 10 Jan 2023 20:38:54 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH V0 1/1] bootconfig: Increase max size of bootconfig from 32 KB to 256 KB for DCC support Content-Language: en-US To: "Masami Hiramatsu (Google)" CC: , Bjorn Andersson , , , "Sai Prakash Ranjan" , Sibi Sankar , Rajendra Nayak References: <654357bcbfd3974072a558c494a51edafaa73e1a.1673261071.git.quic_schowdhu@quicinc.com> <20230110001820.5ca81344286f614ed4ccec77@kernel.org> <20230110234643.7bbd340ece99c28f25fe7ad7@kernel.org> From: Souradeep Chowdhury In-Reply-To: <20230110234643.7bbd340ece99c28f25fe7ad7@kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: l8YAOWtJbJZDUYybS12xp0mJBjhOap51 X-Proofpoint-ORIG-GUID: l8YAOWtJbJZDUYybS12xp0mJBjhOap51 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2023-01-10_06,2023-01-10_03,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 clxscore=1015 suspectscore=0 priorityscore=1501 lowpriorityscore=0 phishscore=0 mlxscore=0 adultscore=0 mlxlogscore=999 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301100094 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/10/2023 8:16 PM, Masami Hiramatsu (Google) wrote: > On Tue, 10 Jan 2023 17:26:07 +0530 > Souradeep Chowdhury wrote: > >> >> >> On 1/9/2023 8:48 PM, Masami Hiramatsu (Google) wrote: >>> On Mon, 9 Jan 2023 20:01:05 +0530 >>> Souradeep Chowdhury wrote: >>> >>>> Increasing the memory size of bootconfig to be able to handle a max number of >>>> 8192 nodes to be fitted in memory size of 256KB. >>> >>> Sorry, but you missed the 'xbc_node::data' stores the index of the data and >>> that is uint16_t. So the XBC_DATA_MAX is fixed limitation. >>> >>> The number of nodes (XBC_NODE_MAX) can be expanded because I just decided it >>> to keep the pre-compiled array size ~8KB. Maybe expanding it to 64KB just >>> increase the size of kernel on init memory (and freed after boot). >>> >>> Could you tell me why you need such a big data for your DCC? >>> >>> Thank you, >> >> DCC is a debugging tool used in qcom which is needed to debug crashes >> that can happen at boot-time. For debugging purposes a large number of >> registers need to be configured in DCC driver which is to be fed via the >> bootconfig file. For that we need to expand the nodes as well as memory >> for using bootconfig. > > Hmm, how many registers does DCC usually use? And how big the bootconfig > file is usually? I have no idea about that. So a typical bootconfig file for consumption of DCC looks like as follows dcc_config { link_list_0 { qcom-curr-link-list = 6 qcom-link-list = R_0x1781005c_1_apb, R_0x1782005c_1_apb } link_list_1 { qcom-curr-link-list = 5 qcom-link-list = R_0x1784005c_1_apb } } The "qcom-link-list" field can have 1000s of register , based on that max nodes is increased to 8192. > >> Can you let us know the changes that you suggest for doing the same? Is >> it fine to just increase the XBC_NODE_MAX, do we also need to >> change the uint16_t to u32 for proper storing of index values? > > Expanding the number of max nodes is easy, just increase the XBC_NODE_MAX > (must be less than 64k). That will also increase the memory consumption > during the boot time even if the bootconfig is small. Anyway, it will be > freed after boot, so it maybe OK. So since the limit is 64K, 8192 is a valid value for max nodes. > > But expanding the size of max bootconfig needs to change the type of > the 'data' field to uint32_t (since that will be used for building > bootconfig tool) and you also must confirm that `tools/bootconfig/bootconfig` > can be built and pass the test-bootconfig.sh. > Hmm, comparing with expanding the max number of XBC node, changing the > 'data' type to uint32_t may not have much impact on memory consumption point > of view, because it may increase only 20% of memory, but expanding the > MAX_XBC_NODE always increases more than double. > > Thus, if we can accept increasing the number of node, it should be OK to > change the 'data' type. That means from DCC point of view only increasing the max nodes is enough as increasing the data size is unrelated to increasing the max nodes? > > BTW, I think now we don't need the ' __attribute__ ((__packed__))' for > struct xbc_node. It was packed for reducing the size of array and able to > pass 'compiled' bootconfig, but now it is just passed as a text data for > safety. > > Thank you, > >> >> >>> >>>> >>>> Signed-off-by: Souradeep Chowdhury >>>> --- >>>> include/linux/bootconfig.h | 6 +++--- >>>> 1 file changed, 3 insertions(+), 3 deletions(-) >>>> >>>> diff --git a/include/linux/bootconfig.h b/include/linux/bootconfig.h >>>> index 1611f9d..64d233b 100644 >>>> --- a/include/linux/bootconfig.h >>>> +++ b/include/linux/bootconfig.h >>>> @@ -55,11 +55,11 @@ struct xbc_node { >>>> } __attribute__ ((__packed__)); >>>> >>>> #define XBC_KEY 0 >>>> -#define XBC_VALUE (1 << 15) >>>> -/* Maximum size of boot config is 32KB - 1 */ >>>> +#define XBC_VALUE (1 << 18) >>>> +/* Maximum size of boot config is 256KB - 1 */ >>>> #define XBC_DATA_MAX (XBC_VALUE - 1) >>>> >>>> -#define XBC_NODE_MAX 1024 >>>> +#define XBC_NODE_MAX 8192 >>>> #define XBC_KEYLEN_MAX 256 >>>> #define XBC_DEPTH_MAX 16 >>>> >>>> -- >>>> 2.7.4 >>>> >>> >>> > >