From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=pass header.oldest-pass=0 smtp.remote-ip=40.93.201.0 ARC-Seal: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=pass; t=1794952488; b=eCZiNXgVeELU39LPAJzSDtlPWI4mxXC+dOTwn86yw/inz29TMyUbJyRkxdLc9eKWzsPs ICXDShjRpaVzVcPM5l2DrKuLcFcXauceNTTeLG817RkQn/m43k7TKd3HQWrMoZU2ewGqC 6syz4Al3/FS8P8RnqskqDuYcLibgx16iaS+mUgg/8rwFklei79zGK5UBFInoFt9I0VM4r 2b+/z4zewhp635OZbofnFuuLQP6BzGZmANIGeQBB3oCsJdhbDT1Dmciff3mTlyg2HD2ga gxGFKE7rjcRvG9NP815rZjJJBL41+dgwa4oZal6h//vCPNWeXvGZjFgQaL2l9w54+tA== ARC-Message-Signature: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794952488; h=DMARC-Filter:DKIM-Signature:Received:Received:From:To:Cc:Subject: Date:X-Mailer:Message-ID:In-Reply-To:References:Content-Type: X-MS-Reactions:X-ClientProxiedBy:MIME-Version:X-MS-PublicTrafficType: X-MS-TrafficTypeDiagnostic:X-MS-Office365-Filtering-Correlation-Id: X-MS-Exchange-SenderADCheck:X-MS-Exchange-AntiSpam-Relay: X-Microsoft-Antispam:X-Microsoft-Antispam-Message-Info: X-Forefront-Antispam-Report: X-MS-Exchange-AntiSpam-MessageData-ChunkCount: X-MS-Exchange-AntiSpam-MessageData-0:X-OriginatorOrg: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-AuthSource:X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-OriginalArrivalTime: X-MS-Exchange-CrossTenant-FromEntityHeader: X-MS-Exchange-CrossTenant-Id:X-MS-Exchange-CrossTenant-MailboxType: X-MS-Exchange-CrossTenant-UserPrincipalName: X-MS-Exchange-Transport-CrossTenantHeadersStamped; bh=wHU5zrrEwXt6w3PW1dDVDuO0Oi2GraxME73dYzFWQo4=; b=P0/B7GkwCAwT69Zi0VgznAZTm0xBlq72BT/GWEda1SnwiJdecDPcUids+h+wwM6LqQOR bnyUz2GrfzCcaBYrRffZ2u+4HQgk7T6PDZy4eoGsx1D+rpkIns4PlS97iceyJd2qmMt1d HgCHJ+2lnJnvj63OV+g88rfM9MIifeBBqit87dIjGg1ko5Z7tpUAzmrrT+Gpg6YjdoVTO L5FO1YHRGGn4cd5GEgoQLHtaZUpweZUO6+IiYBAYjArzqb91NuAl4Q1hgvMd1IEHadVNi qdhzKnMM5kAFwZzOrvYZatYmDGPPEc/nxCIU7gVnuU11lFYd8mfYK43sRLINzLZZydQ== ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=ZuLvIZx5; arc=pass header.oldest-pass=0 smtp.remote-ip=40.93.201.0 Received: from CY3PR05CU001.outbound.protection.outlook.com (mail-westcentralusazon11013000.outbound.protection.outlook.com [40.93.201.0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (secp384r1) server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F310C606A32A; Tue, 17 Nov 2026 21:54:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org F310C606A32A Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=ZuLvIZx5 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xD11Qvpo9QTDNKPPavqaOUs2G9pZosecRNpfm0Vg0vNeUa35GjQylVlx8syHonCHTVGZ/wr+4W6Qf+CflAV4kGBoQ5T/1bb6ZqxSXWCsm2ewP/y9CD1m4//pKGNoPcKj7ACceSmnWY6QAIrGLyiZRL4LPwMKbag+WtDsbj8+gXpIHL7mUzv26NhKYIjE6k2OMO18RA+yR5htIxzuj31rqpWnAOYv0d4HKc2LCWDtT1CqvTCVjAt5fImACW6VtY41LHKyvXVFSnNSl8Z8mU1kjDBGLshG0NjSLKvkci0VqeWrR5JClQ+JHZtcaBfYW0yeeDP/45QcLnbDHXWbMpkhUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wHU5zrrEwXt6w3PW1dDVDuO0Oi2GraxME73dYzFWQo4=; b=eDP4km14U9D1yb8UNsVG4agvhd0BR7ig8KexYbmOafXlYTg22KxQ/Xu/rXsZkOM4WcYeIBp8cjsAHchBvCcCLzpginkg13MT5Pkc57xKCTkZ19DjQhsqsgm04to6okL5ly1lUIPSgZUde9vDNJIUmF5/yh/yXKP+S3zoQqWaiVCFWLC8vYxECXKxCLx2e31R+BfAIEtJMe/9zN28Jncy7K6A8d4lsiPAa80430Iiw+JxbxXFE3ccrALSmtOsLCDs7Kcca4EWFGdbulNpDoaurlIGxYbNt7hjxB47jCbeo2pHUh7CSNjw0GRMQj3gwzHlUyetgBavaSMBnCfcFN9zCQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wHU5zrrEwXt6w3PW1dDVDuO0Oi2GraxME73dYzFWQo4=; b=ZuLvIZx5oLw1cF4Q+vmUGjI+N60683Ddavx5fEm/Txmpuc7qDMfHzIhv5Us+g6KWcPu/phFA0CMWaGRIDDPoFSaqsJpUqQftsVQ/gcLQ7h0CAmvr1o6EGU39AcsH2661i8irslYJ54Ds2GETvsv8zkwu+0J9ib8lOBCDc3mU5+mT6tsJMIMC17khVx/jPLIfcTBttaV2nHX8dhwYSbaj0hoDVVwn0er91o+mg8wdrGloGQBCgcCXY62xkqNvtOTP05jZaCqn6AUoksK35LBSrZqCHewDY4Koae855Tkht3XOvbHeI5XTcUzeaJTVaz2kQ9fBwa0ZOE9QFpr3DbZ/Lg== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) by SA0PR12MB7089.namprd12.prod.outlook.com (2603:10b6:806:2d5::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.615.14; Tue, 17 Nov 2026 21:54:43 +0000 Received: from IA0PR12MB8374.namprd12.prod.outlook.com ([fe80::d85f:4c87:ae84:3f16]) by IA0PR12MB8374.namprd12.prod.outlook.com ([fe80::d85f:4c87:ae84:3f16%6]) with mapi id 15.21.0615.009; Tue, 17 Nov 2026 21:54:43 +0000 From: Zi Yan To: "Lorenzo Stoakes (ARM)" Cc: Andrew Morton , David Hildenbrand , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Alex Williamson , Peter Xu , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Usama Arif , Kiryl Shutsemau , Wei Liu , Roman Kisel , Saurabh Sengar , Naman Jain , Michael Kelley , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Eliav Farber , stable@vger.kernel.org, "Jose A. Perez de Azpillaga" , "Gregory Price (Meta)" Subject: Re: [PATCH v2 4/4] mm/huge_memory: only compare PFNs of huge entries on huge fault insert Date: Tue, 17 Nov 2026 16:54:42 -0500 X-Mailer: MailMate (3.0r7038) Message-ID: <95493B29-E928-4AE4-B051-F0A9651561FB@nvidia.com> In-Reply-To: <20261117-huge-pfnmap-fault-races-v2-4-276007e73bcb@kernel.org> References: <20261117-huge-pfnmap-fault-races-v2-0-276007e73bcb@kernel.org> <20261117-huge-pfnmap-fault-races-v2-4-276007e73bcb@kernel.org> Content-Type: text/plain X-MS-Reactions: disallow X-ClientProxiedBy: MN0P220CA0013.NAMP220.PROD.OUTLOOK.COM (2603:10b6:208:52e::28) To IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA0PR12MB8374:EE_|SA0PR12MB7089:EE_ X-MS-Office365-Filtering-Correlation-Id: 9ee5bb42-5eb3-489d-52b7-08df44f5637d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|23010399003|366016|1800799024|5023799004|4143699003|11063799006|56012099006|261026121527099003|261026140227099003|261028144727099003|10067099003|261022075727099003|261021121427099003|261022105027099003|261102123227099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: tFY16f+DTF9O8uU+xFJzrxdh0aJh2OOgDgKyGzOWs0aRAuVORME3qa2kdyHF4EFeshZofYK25YZ1SkuLpmjfgyJrS2bHqYA709hteUooD5aUfKFQuPHTdEFbja+RDRQR8rWQWuCoeYeKofZlFhH0sVfSi0kYpyr9NphneLLEPaMdUPqyTjRMM+YaTVZm+BbLadRZ2wHL5KoqjlC1jJE79doDMDyCQzgJImLXk6XvPFO3rwU6uwBUHSsQKvJU/eVcQSy7hWNxrj9HD1pcP5T93lv+gjJE+o6dsJ5RBmVYDzuyrg7L5PI9lBenxICcfFh9FLyrDMVq9AIcP5mOq+uaaOXlhCcwAPTKaMDhJ9sosKc6kHxIkpC8/fQ5ebcPNpGIBgG3rRyudl11K6krqAKv+g73U7XRb5KQurngWjjQdJEuV49wvonEFaiWSuKJomH+vJAgogJRxPH/O3JWGn46L7j8dVyWak95E/OsolDu9arcrx2McG0hz/HFnqzqk54mtsuuA8akNR2UHasrUegthijjM/giDvaALImhwsoVKlT5hkY3jZh6h8Co+WI7gxsootnaoyu+fzTnNRX5X5+5ToMsX1twSWoPtH5TbMCQtCITSP4OlmKl99vOdPT+hsrjjztjvulWFIKlJt5o63RKPH4uIbqZrzPgzSw9Ksk1J0s= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA0PR12MB8374.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(23010399003)(366016)(1800799024)(5023799004)(4143699003)(11063799006)(56012099006)(261026121527099003)(261026140227099003)(261028144727099003)(10067099003)(261022075727099003)(261021121427099003)(261022105027099003)(261102123227099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3a6J/aUgs/on+2Bwu51rZ86ZoYDkDAj+8gIiBukrIWNr1TNj2yFpcJa5GfVQ?= =?us-ascii?Q?7OPNUpwmFohgGFfmA0D3Bh4p1xMkvJgw0BxlCCKHH+ZYRILviNbPkr9zeCxc?= =?us-ascii?Q?13Imf00ytI+BK4nQ+DHy4rIKr/3TONRBaM/0Us+ZbEwIdE4MSJnpTJNlSEsg?= =?us-ascii?Q?/sanyelKTqAGE01GdL3jCRWyLj/7hkynH5tTjXeyrgLMZ86vAAvqqoRwVER1?= =?us-ascii?Q?jThXB9JTOxeM6Hh8AG/2rEo0Dw1tBqnANr9UWwafz9KxNbOvrPm5XTnVyqDE?= =?us-ascii?Q?7oVDxzhLvXLuxFPUdYabaBzmbFcgGy83y2VjN9IIZoX2fgXN+zUKdZy3hd8V?= =?us-ascii?Q?PZCY98jcVCmPioCCYYPSNY/C9nQWeRX1xPMXw5Jss+P/iVy65z69Z2nqNXrS?= =?us-ascii?Q?Rguhnvfhj6EkFDyFfqfypdpjyYwnULeJNIM6gdN9/BtE79LyLQoMqRiOGS/V?= =?us-ascii?Q?Gjjt5InQTvy4qX5cKvLFYonrZEtuyfdMYkR9J68vkQwlrk7FEhJn+yvykyy2?= =?us-ascii?Q?BcQVIlKwAjrnL0f1H3cg9v1B/gbGthIVpjfaypaSzzK5gupdstdtGd6sORlA?= =?us-ascii?Q?TpVsLU6mLlpwAz0R80WQI6dzxW0fkMP994D60e7r8vwh0f9uDlnoFRIWVxyl?= =?us-ascii?Q?Z/n8kbRLjtxYhLQA9CDAOuZ4HFMTYT/rZSUanGaPxqqctOYCp5oTtqzJWmYC?= =?us-ascii?Q?U+DVOIhHEJfhNsAsPxWJ+5TWD7Pr3oAyBofg2lVGYAoNTzff+rCeYYbVKZTJ?= =?us-ascii?Q?AD+74DYiCBG89HpFEuJ42zqew27/N4iopsbL5dT3RplrCTU+64Z4MmBbQbb6?= =?us-ascii?Q?K6DIq6yCdZ6FaSgmqA7w0hlrlTzl4zgW/V2CCFjtKCess5WvRj79oN+XPkur?= =?us-ascii?Q?VvJ5Dk3LFVEVVbJS1TFZzxuiPpsc08av8egY1tb/0E9IA/P5dR4JYoH833u7?= =?us-ascii?Q?vguoVSljOHx569MG4zGKuUaOP76A7oFu5viAlPwKSGUH+RRdxdRPSOmaiAaf?= =?us-ascii?Q?CaXTGpRFr3KqAgyLP8dUqpKg+cCpjcv0FHx2Koly1mY8Xpb/Zn6PmIWzRrQk?= =?us-ascii?Q?Ch2KUpi/nZPu6YCkq1NWhfoLC7rqYTlvyBjEOa+e+rXHjldpTt6R6I1c+0U2?= =?us-ascii?Q?+UxRbYhiKrsXgCLfNkgu7KjLkM9B1Hj79ECMsIeFAqt0+dG7NR9aGz/LwnZn?= =?us-ascii?Q?/4QT9NO3ebsjiNITdawyGKdSZSVXnaJPlSWTGa0Gaaegj9jVLJPIN4CXURcU?= =?us-ascii?Q?p0FvhGifWj0DhZTV9KPdd49uxHb3eP65JXPSAhYafcpqzPgLb8yD6wnWkceB?= =?us-ascii?Q?AzG4nngk3Swqxp9yW9wU8SHvcvedeFUAxUSpe/to1Cts1gl1fEMKnBTeFLhr?= =?us-ascii?Q?w3nipZcH1Grsz6Nb3g6+QrGm09VtuExayoVPoxlKHVZm06zsW4FirHHCxkxW?= =?us-ascii?Q?xIsH2QdQbElhR9Af4Ul8NLkYLXze2e9Wb6iUV4EqDyqeU6l3LZZ89d3nOh47?= =?us-ascii?Q?SIbZHOIMRr+nr/BbpM/Z6HHihV9EjsHe0rln9JJZaG68lh7FQBnYzBxqwnvb?= =?us-ascii?Q?ohZDxjx6T9waNqDSpEAa7xYErUuj+vqhd25h5RjFwnRlBnEC0GhY6aFM/TuM?= =?us-ascii?Q?ATobuR0WwTlfoXXJxFHSykWmB3J+8rY67nHxXSGCKce4VjGE1ACwOeaRrFjM?= =?us-ascii?Q?JkhSLJ0naDD1CekEDC5ujI9+B3bpd1ExAN5w/aCVQiDDCc25xagpINXDjR+g?= =?us-ascii?Q?1JJfe0Rp3g=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9ee5bb42-5eb3-489d-52b7-08df44f5637d X-MS-Exchange-CrossTenant-AuthSource: IA0PR12MB8374.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2026 21:54:43.7622 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: L2Y23DeZaveSvdgGEWzhDZ5LqQKZpJhRC6IDymNeHdR3tBX+/9ZthUaRH8oYHO47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB7089 On 17 Nov 2026, at 13:31, Lorenzo Stoakes (ARM) wrote: > A driver that implements both ->fault and ->huge_fault must anticipate > concurrent use of both. > > This can happen, for example, if a user calls prctl(PR_SET_THP_DISABLE) > concurrent with faulting, as that only holds the mmap write lock and thus > does not exclude faulting threads stabilised by VMA lock. > > insert_pmd() and insert_pud() have issues with this as they both assume > that, if the page table entry being populated is not empty, it must be a > present huge entry. > > This is problematic as if it is a write fault, it compares its PFN against > the one being inserted, warning if they differ, on the assumption that the > entry is a huge leaf. > > Since the entry may be a page table, this is invalid and can result in > spurious warnings. > > Equally, the entry might be non-present. Nothing can install such an entry > in the VMAs that reach this code today, but there is no reason to rely upon > that. > > Therefore only examine the PFN if the entry is both present and huge, and > otherwise simply return VM_FAULT_NOPAGE so the fault is retried and handled > at the appropriate level. > > This is what already happens for a read fault, for which the existing entry > is not examined at all. > > Target the commit which introduced the first driver which both mixes fault > orders and passes the write flag for the fix (since this commit, both > drm_gem_shmem and panthor are prey to this issue). > > Reported-by: Eliav Farber > Closes: https://lore.kernel.org/all/20261112051440.16140-4-farbere@amazon.com/ > Fixes: 7bfe3b8ea6e3 ("Drivers: hv: Introduce mshv_vtl driver") > Cc: stable@vger.kernel.org > Reviewed-by: Jose A. Perez de Azpillaga > Acked-by: David Hildenbrand (Arm) > Tested-by: Gregory Price (Meta) > Reviewed-by: Gregory Price (Meta) > Signed-off-by: Lorenzo Stoakes (ARM) > --- > mm/huge_memory.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > My rb to v1 might be too late for you to pick it up. Reviewed-by: Zi Yan Best Regards, Yan, Zi