From: Angel Iglesias <ang.iglesiasg@gmail.com>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
"Jonathan Cameron" <jic23@kernel.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH v2 2/3] iio: pressure: bmp280: Use i2c_get_match_data
Date: Sun, 13 Aug 2023 21:09:13 +0200 [thread overview]
Message-ID: <954c859835aed6c41a356fdd999a8be51469eb9e.camel@gmail.com> (raw)
In-Reply-To: <55f8dc02de16a353f0449bc1c7cb487bd776dfaf.1691952005.git.ang.iglesiasg@gmail.com>
On Sun, 2023-08-13 at 21:03 +0200, Angel Iglesias wrote:
> Replaces device_get_match_data() and fallback match_id logic by new
> unified helper function i2c_get_match_data().
>
> Signed-off-by: Angel Iglesias <ang.iglesiasg@gmail.com>
>
> diff --git a/drivers/iio/pressure/bmp280-i2c.c b/drivers/iio/pressure/bmp280-
> i2c.c
> index 693eb1975fdc..34e3bc758493 100644
> --- a/drivers/iio/pressure/bmp280-i2c.c
> +++ b/drivers/iio/pressure/bmp280-i2c.c
> @@ -11,9 +11,7 @@ static int bmp280_i2c_probe(struct i2c_client *client)
> const struct bmp280_chip_info *chip_info;
> struct regmap *regmap;
>
> - chip_info = device_get_match_data(&client->dev);
> - if (!chip_info)
> - chip_info = (const struct bmp280_chip_info *) id->driver_data;
> + chip_info = i2c_get_match_data(client);
>
> regmap = devm_regmap_init_i2c(client, chip_info->regmap_config);
> if (IS_ERR(regmap)) {
Hi,
I noticed I submitted this change that was also submitted by Biju Das on another
patch:
https://lore.kernel.org/all/20230812175808.236405-1-biju.das.jz@bp.renesas.com/
Should I drop this patch from the series?
Kind regards,
Angel
next prev parent reply other threads:[~2023-08-13 19:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-13 19:03 [PATCH v2 0/3] iio: pressure: bmp280: Small driver cleanup Angel Iglesias
2023-08-13 19:03 ` [PATCH v2 1/3] iio: pressure: bmp280: i2c: Rearrange vars in reverse xmas tree order Angel Iglesias
2023-08-13 19:03 ` [PATCH v2 2/3] iio: pressure: bmp280: Use i2c_get_match_data Angel Iglesias
2023-08-13 19:09 ` Angel Iglesias [this message]
2023-08-14 6:57 ` Biju Das
2023-08-14 16:43 ` Angel Iglesias
2023-08-28 11:39 ` Jonathan Cameron
2023-09-07 7:09 ` Angel Iglesias
2023-09-07 7:11 ` Biju Das
2023-08-13 19:03 ` [PATCH v2 3/3] iio: pressure: bmp280: Use spi_get_device_match_data() Angel Iglesias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=954c859835aed6c41a356fdd999a8be51469eb9e.camel@gmail.com \
--to=ang.iglesiasg@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome