From: Amelie DELAUNAY <amelie.delaunay@st.com>
To: Nathan Chancellor <natechancellor@gmail.com>,
Lee Jones <lee.jones@linaro.org>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre TORGUE <alexandre.torgue@st.com>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"clang-built-linux@googlegroups.com"
<clang-built-linux@googlegroups.com>
Subject: Re: [PATCH] mfd: stmfx: Fix macro definition spelling
Date: Mon, 13 May 2019 07:10:59 +0000 [thread overview]
Message-ID: <954f759a-4e13-ef95-d461-03cdb385e0a3@st.com> (raw)
In-Reply-To: <20190511012301.2661-1-natechancellor@gmail.com>
On 5/11/19 3:23 AM, Nathan Chancellor wrote:
> Clang warns:
>
> In file included from drivers/mfd/stmfx.c:13:
> include/linux/mfd/stmfx.h:7:9: warning: 'MFD_STMFX_H' is used as a
> header guard here, followed by #define of a different macro
> [-Wheader-guard]
>
> Fixes: 06252ade9156 ("mfd: Add ST Multi-Function eXpander (STMFX) core driver")
> Link: https://github.com/ClangBuiltLinux/linux/issues/475
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Amelie Delaunay <amelie.delaunay@st.com>
> ---
> include/linux/mfd/stmfx.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/mfd/stmfx.h b/include/linux/mfd/stmfx.h
> index d890595b89b6..3c67983678ec 100644
> --- a/include/linux/mfd/stmfx.h
> +++ b/include/linux/mfd/stmfx.h
> @@ -5,7 +5,7 @@
> */
>
> #ifndef MFD_STMFX_H
> -#define MFX_STMFX_H
> +#define MFD_STMFX_H
>
> #include <linux/regmap.h>
>
>
next prev parent reply other threads:[~2019-05-13 7:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-11 1:23 Nathan Chancellor
2019-05-13 7:10 ` Amelie DELAUNAY [this message]
2019-05-13 7:30 ` Lee Jones
2019-05-14 18:39 ` Nathan Chancellor
2019-05-14 18:54 ` Lee Jones
2019-05-14 19:45 ` Nathan Chancellor
2019-06-14 3:57 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=954f759a-4e13-ef95-d461-03cdb385e0a3@st.com \
--to=amelie.delaunay@st.com \
--cc=alexandre.torgue@st.com \
--cc=clang-built-linux@googlegroups.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=natechancellor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®