From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0863E13AD1C for ; Sun, 24 May 2026 01:39:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779586796; cv=none; b=Y0cBa/R9koGlYLGqbWngaRjt/5zO74fk5jBbYFT0ZjW8AgNLP08d8mWYknnImfOX95+HdEiAaQ55JYfwjF8Y9tLWA7olGetB1AvH8sXf2m+qOBQeB2lz/1Qry5uaBcTVFQZNNpA8ABqTmMhxDQ4o3jX9n1CLiLebNRNw+jSS/Yk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779586796; c=relaxed/simple; bh=rwIIg4Z2p2m9t0mjqyz0adIOiHIb1pbQ6vm28q31QUU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=La+Wo5xXoQ0/URaRpUCxg3hwwu/LLzS44wh04rLTgUWgRZytZYhKyI3/3Ihg2CpJzK2/2VeXwfQSe7dBmY2Cwe4FTIJY7m3cZMy3H3ur9BWRZhmBQCE6LNRTE+Hq1GVAwUvGQILPVi+aDOhq1LoOiKpdu6EIx4xuo7ZX3lC/DcA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=X8k6GqZV; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="X8k6GqZV" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-835b78c3797so3738438b3a.2 for ; Sat, 23 May 2026 18:39:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779586794; x=1780191594; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vXQx8sp/1mlGOh839phUqYZokRTxQ/SO0fzQl6UHMdo=; b=X8k6GqZVZYVRkPvhTmejSM6TzIB7+WWvXYeiLNf+7G4IYwksApP3u+Z2w8tED/X4wc 1WQkV2FWvBpt4004w1BCmMBIRQPZfk2y3f1fX/8pz64Hh6UOOcn3tp8Z2ZYAxiIVpxX8 LLXqIjaThzIbFc0Sl5bnbmUSjn7+ukmzenkoaJax0kDjHYEObCWSAd9W357sGsJQ7dA4 n3i/LUP4SlCxYJQciD198EkvqkUa3xIsVNBEoC7s3b1XKGQuMN0CmiAVl18Ov4Z0v/TZ atzcLw0ZeXBZ3hWboQCy3J2Ev78EvFWF6KW1RE/smeTQfNnE3t5aUwDRM7yKrw49xTzC LukA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779586794; x=1780191594; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vXQx8sp/1mlGOh839phUqYZokRTxQ/SO0fzQl6UHMdo=; b=YTrO3Yfm781NotW5Bz12qxFf2ma+lAnsZYo8IQMb4y3nJmk5vEEcuHusZy6c6mN2WZ oANuYnq3uvwHI7w3t/MWAoj1CaGo4yTCFT6goh0dFlvDPGgQtX0Bpjvx5cTxxWhzSah1 VlVLKHD7mLGlXljC6Lec50ZGsPQfhQNSJZyYlizjeuDOQiKC0P93mhUJ+V+w2/JXsaZQ zhSWXmvGhQp5kwDmN5Ttfjv0V+p6hXSqM/gpSAQqcxuiwWtaI8LHW5qp1z7i6xk3M0Db 6ngtUsAAOme1Plu2eoFVY5dQHj0pz+i/HN4cOxqiznXmplrzkYSDxwmUlPTbnS4+w0Fr tIdg== X-Forwarded-Encrypted: i=1; AFNElJ9/gmQNB9dJbQqdjh4UYVpG8J/6pjEFBHXpU6LaVhExnyGuBk1I87EaDnmTXUHPensa7/7OXTdxsMUPfwU=@vger.kernel.org X-Gm-Message-State: AOJu0Yyb4bF6hXH5bEXFtj4mIPP0STF8ro4jb4WZvc7j/eDVtH2r9c2n PP2xzDORybMqZNG7C7623GsofHOo0GUF2n/OQLPCLQijyHkQtBGStKhjgkqNjXqb X-Gm-Gg: Acq92OHLxKl3GLYgKkg5a/yi4pyqkR1qMp5GU73kYJS2bcBq5UjPU3XcCQjdQAPi9q9 43GcwqfK6o2PFmuOxETK85rKV8EZIW1rugnXP25KLT9H/+5XVE4Z/fPTiZcVGJxdDbKoV/3TwWD d//CoHPxZxRn+rSD/naH1nLyjj0S6agcmUPi8Y2Bj7vuTg/XlWKA8rkIJTRlhJ9uBPDsAbKU9e3 eQd14VuMntB3EhU8GRb/6paFJWRIV5EmuGbWlAv/tO8z1eYOxwG8JFuOfez1Vma/Z+Zh0WGw5MK zZCrJ76MqoVo/EKz2uAOq8gqpwyovHOF3cy7IKuUMCmaZ5dz0S6KoUrJR5y2oQmNfTr8t4UmEfU jdByyk7KdQNpkY5vFSiSwrlodynJndblLrsU6hRxKBUtGBMmOxBJ6apGGJmjuvFdfdyc8fshWsD A4LTYu2F/xeqc08iihFE6G0i7EtPNKQPq27XZ8kN4nO2e+ya5yQ1BQtAoJp5/0kg== X-Received: by 2002:a05:6a00:4299:b0:838:af72:fb37 with SMTP id d2e1a72fcca58-8415f0f02e2mr8616345b3a.7.1779586793939; Sat, 23 May 2026 18:39:53 -0700 (PDT) Received: from [192.168.0.176] (c-73-83-32-130.hsd1.wa.comcast.net. [73.83.32.130]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84165009852sm5660631b3a.59.2026.05.23.18.39.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 23 May 2026 18:39:53 -0700 (PDT) Message-ID: <9553191e-b061-4fa1-a11c-5ad87cbf6862@gmail.com> Date: Sat, 23 May 2026 18:39:52 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] tpm: tpm_tis: Add optional delay after relinquish To: Jarkko Sakkinen Cc: linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, peterhuewe@gmx.de, jgg@ziepe.ca References: <20260519060926.103727-1-jbroadus@gmail.com> Content-Language: en-US From: Jim Broadus In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jarkko. The current manufacturer_id is in tpm_tis_data, not tpm_chip. I think it makes sense to move the new did_vid to tpm_chip so it can be used in tpm-sysfs, but it would only be set (at least initially) for the tpm_tis driver. What do you think? Thank you, Jim On 5/22/26 5:37 AM, Jarkko Sakkinen wrote: > On Thu, May 21, 2026 at 11:03:29PM -0700, Jim Broadus wrote: >> Thank you Jarkko. I'll do that. >> >> Jim > Yeah, in this form it is quite unsable e.g., for any Linux distribution, > and somewhat involved for the user :-) > > Conditionally on is much better with appropriate detection. Also, this > way the change improves the code base a bit given that chip->did_vid is > much more applicable than chip->manufaturer_id. > > BR, Jarkko